[tipc-discussion] [PATCH 0/2] New node removal netlink command

2015-12-02 Thread Richard Alpe
Add a new netlink command that can remove a dead node from the internal data structures. There is still an impediment here: When I wrote this a node was removed properly on the first call. After rebase it now requires the netlink command and the subsequent tipc_node_stop() function to be executed

[tipc-discussion] [PATCH 1/2] tipc: move netlink policies to netlink.h

2015-12-02 Thread Richard Alpe
Make the c files less cluttered and enable netlink attributes to be shared between files. This will prove useful in future patches where a node message contains a nested network. Signed-off-by: Richard Alpe --- net/tipc/bearer.c | 19 +--- net/tipc/link.c | 8 - net/tipc/n

[tipc-discussion] [PATCH 2/2] tipc: add node removal functionality

2015-12-02 Thread Richard Alpe
Add a new netlink command, TIPC_NL_NODE_REMOVE. This command can remove an offline peer node from the internal data structures. This will be supported by the tipc user space tool in iproute2. Signed-off-by: Richard Alpe --- include/uapi/linux/tipc_netlink.h | 1 + net/tipc/net.c

Re: [tipc-discussion] [PATCH 0/2] New node removal netlink command

2015-12-02 Thread Jon Maloy
> -Original Message- > From: Richard Alpe > Sent: Wednesday, 02 December, 2015 07:52 > To: tipc-discussion@lists.sourceforge.net > Cc: Jon Maloy; Ying Xue; Richard Alpe > Subject: [PATCH 0/2] New node removal netlink command > > Add a new netlink command that can remove a dead node from

Re: [tipc-discussion] [PATCH 1/2] tipc: move netlink policies to netlink.h

2015-12-02 Thread Jon Maloy
Very appreciated change. Maybe you should add the standard phrase "There are no functional changes in this commit" Acked-by: me ///jon > -Original Message- > From: Richard Alpe > Sent: Wednesday, 02 December, 2015 07:52 > To: tipc-discussion@lists.sourceforge.net > Cc: Jon Maloy; Ying

Re: [tipc-discussion] [PATCH 2/2] tipc: add node removal functionality

2015-12-02 Thread Jon Maloy
Looks good. Reviewed-by: me ///jon > -Original Message- > From: Richard Alpe > Sent: Wednesday, 02 December, 2015 07:52 > To: tipc-discussion@lists.sourceforge.net > Cc: Jon Maloy; Ying Xue; Richard Alpe > Subject: [PATCH 2/2] tipc: add node removal functionality > > Add a new netlink c

[tipc-discussion] [PATCH net-next 1/1] tipc: fix node reference count bug

2015-12-02 Thread Jon Maloy
Commit 5405ff6e15f40f2f ("tipc: convert node lock to rwlock") introduced a bug to the node reference counter handling. When a message is successfully sent in the function tipc_node_xmit(), we return directly after releasing the node lock, instead of continuing and decrementing the node reference co