Re: [tipc-discussion] [PATCH net-next v2 1/1] tipc: add neighbor monitoring framework

2016-04-25 Thread Parthasarathy Bhuvaragan
On 04/22/2016 05:25 PM, Jon Maloy wrote: > >> -Original Message- >> From: Parthasarathy Bhuvaragan >> Sent: Friday, 22 April, 2016 09:01 >> To: Jon Maloy; tipc-discussion@lists.sourceforge.net; Ying Xue; Richard Alpe >> Cc: ma...@donjonn.com >> Subject: Re: [PATCH net-next v2 1/1] tipc: ad

[tipc-discussion] [PATCH net-next v1] tipc: add the ability to get UDP options via

2016-04-25 Thread Richard Alpe
I started looking into adding multiple UDP remote addresses and it bugged me that there was no way of printing/checking the automatically generated UDP options for a particualar UDP bearer. So I added the ability to print these using the existing netlink API. Note that there is a user-space patch

[tipc-discussion] [PATCH net-next v1] tipc: add the ability to get UDP options via netlink

2016-04-25 Thread Richard Alpe
Add UDP bearer options to netlink bearer get message. This enables us to print UDP options from user space. The UDP bearer information is passed using either a sockaddr_in or sockaddr_in6 structs. This means the user space receiver should intermediately store the retrieved data in a large enough s

[tipc-discussion] [PATCH iproute2 1/3] tipc: fix UDP bearer synopsis

2016-04-25 Thread Richard Alpe
Local ip is not required to identify a UDP bearer and shouldn't be passed to bearer disable, set or get. In this patch we remove the localip entry from the synopsis of these functions. Signed-off-by: Richard Alpe --- man/man8/tipc-bearer.8 | 14 -- 1 file changed, 4 insertions(+), 10

[tipc-discussion] [PATCH iproute2 3/3] tipc: add the ability to print UDP bearer options

2016-04-25 Thread Richard Alpe
In this patch we add the ability to print local and remote UDP bearer information. More specifically local ip, local port, remote ip and remote port. --- man/man8/tipc-bearer.8 | 31 ++-- tipc/bearer.c | 134 - 2 files changed, 137

[tipc-discussion] [PATCH iproute2 2/3] tipc: remove redundant function enable_l2_bearer()

2016-04-25 Thread Richard Alpe
Signed-off-by: Richard Alpe --- tipc/bearer.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/tipc/bearer.c b/tipc/bearer.c index 30b54d9..32abad6 100644 --- a/tipc/bearer.c +++ b/tipc/bearer.c @@ -67,8 +67,7 @@ static void cmd_bearer_enable_udp_help(str

Re: [tipc-discussion] [PATCH net-next v3 1/1] tipc: add neighbor monitoring framework

2016-04-25 Thread Xue, Ying
Hi Jon, Please see my comments inline. Sorry I use outlook client to reply the mail. Regards, Ying -Original Message- From: Jon Maloy [mailto:jon.ma...@ericsson.com] Sent: 2016年4月21日 0:23 To: tipc-discussion@lists.sourceforge.net; parthasarathy.bhuvara...@ericsson.com; Xue, Ying; richa

Re: [tipc-discussion] [PATCH net-next v2 1/1] tipc: add neighbor monitoring framework

2016-04-25 Thread Jon Maloy
> -Original Message- > From: Parthasarathy Bhuvaragan > Sent: Monday, 25 April, 2016 04:25 > To: Jon Maloy; tipc-discussion@lists.sourceforge.net; Ying Xue; Richard Alpe > Cc: ma...@donjonn.com > Subject: Re: [PATCH net-next v2 1/1] tipc: add neighbor monitoring framework > > [...] > >

Re: [tipc-discussion] [PATCH net-next v3 1/1] tipc: add neighbor monitoring framework

2016-04-25 Thread Jon Maloy
> -Original Message- > From: Xue, Ying [mailto:ying@windriver.com] > Sent: Monday, 25 April, 2016 06:54 > To: Jon Maloy; tipc-discussion@lists.sourceforge.net; Parthasarathy > Bhuvaragan; > Richard Alpe > Cc: ma...@donjonn.com > Subject: RE: [PATCH net-next v3 1/1] tipc: add neighbor

Re: [tipc-discussion] [PATCH net-next v3 1/1] tipc: add neighbor monitoring framework

2016-04-25 Thread Jon Maloy
Hi Ying, See below. ///jon > -Original Message- > From: Jon Maloy [mailto:jon.ma...@ericsson.com] > Sent: Monday, 25 April, 2016 09:54 > To: Ying Xue; tipc-discussion@lists.sourceforge.net; Parthasarathy Bhuvaragan; > Richard Alpe > Subject: Re: [tipc-discussion] [PATCH net-next v3 1/1]