Re: [tipc-discussion] [PATCH net-next] tipc: check nl sock before parsing nested attributes

2016-05-16 Thread David Miller
From: Richard Alpe Date: Mon, 16 May 2016 11:14:54 +0200 > Make sure the socket for which the user is listing publication exists > before parsing the socket netlink attributes. > > Prior to this patch a call without any socket caused a NULL pointer > dereference in tipc_nl_publ_dump(). > > Test

Re: [tipc-discussion] [PATCH net-next] tipc: check nl sock before parsing nested attributes

2016-05-16 Thread Jon Maloy
This is a serious bug, so it should be posted to net, not net-next. Otherwise, Acked-by: Jon Maloy ///jon > -Original Message- > From: Richard Alpe [mailto:richard.a...@ericsson.com] > Sent: Monday, 16 May, 2016 05:15 > To: net...@vger.kernel.org > Cc: splovi...@gmail.com; tipc-discussi

Re: [tipc-discussion] [PATCH net-next] tipc: fix nametable publication field in nl compat

2016-05-16 Thread Jon Maloy
Acked-by: jon Send tis to net, since it is a bug correction. ///jon > -Original Message- > From: Richard Alpe > Sent: Monday, 16 May, 2016 09:50 > To: tipc-discussion@lists.sourceforge.net > Cc: Jon Maloy; Richard Alpe > Subject: [PATCH net-next] tipc: fix nametable publication field in

[tipc-discussion] [PATCH net-next] tipc: fix nametable publication field in nl compat

2016-05-16 Thread Richard Alpe
The publication field of the old netlink API should contain the publication key and not the publication reference. Signed-off-by: Richard Alpe --- net/tipc/netlink_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c i

Re: [tipc-discussion] [PATCH net-next v6 2/4] tipc: add neighbor monitoring framework

2016-05-16 Thread Parthasarathy Bhuvaragan
On 05/14/2016 02:07 AM, Jon Maloy wrote: > TIPC based clusters are by default set up with full-mesh link > connectivity between all nodes. Those links are expected to provide > a short failure detection time, by default set to 1500 ms. Because > of this, the background load for neighbor monitoring

[tipc-discussion] [PATCH net-next] tipc: check nl sock before parsing nested attributes

2016-05-16 Thread Richard Alpe
Make sure the socket for which the user is listing publication exists before parsing the socket netlink attributes. Prior to this patch a call without any socket caused a NULL pointer dereference in tipc_nl_publ_dump(). Tested-and-reported-by: Baozeng Ding Signed-off-by: Richard Alpe --- net/t