Re: [tipc-discussion] [PATCH net 1/1] tipc: unclone unbundled buffers before forwarding

2016-06-22 Thread David Miller
From: Jon Maloy Date: Mon, 20 Jun 2016 09:20:46 -0400 > When extracting an individual message from a received "bundle" buffer, > we just create a clone of the base buffer, and adjust it to point into > the right position of the linearized data area of the latter. This works > well for regular mes

Re: [tipc-discussion] [PATCH net-next 3/3] tipc: use sock addr family to indicate IP version

2016-06-22 Thread Jon Maloy
On 06/22/2016 11:40 AM, Erik Hugne wrote: > This change is not backwards compatible, udp_media_addr is carried in the > neighbor discovery messages. > > //E Not sure if backwards compatibility is a big issue at this stage, but as I remember it the 'media_id' field was meant to fulfill this role

Re: [tipc-discussion] [PATCH net-next 3/3] tipc: use sock addr family to indicate IP version

2016-06-22 Thread Erik Hugne
This change is not backwards compatible, udp_media_addr is carried in the neighbor discovery messages. //E On Jun 22, 2016 10:03, "Richard Alpe" wrote: > Use socket address family instead of ethernet protocol ID to identify > IP version internally. > --- > net/tipc/udp_media.c | 26

[tipc-discussion] [PATCH net-next 1/3] tipc: honor msg2addr return value

2016-06-22 Thread Richard Alpe
The UDP msg2addr function tipc_udp_msg2addr() can return -EINVAL which prior to this patch was unhanded in the caller. Signed-off-by: Richard Alpe --- net/tipc/discover.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/tipc/discover.c b/net/tipc/discover.c index ad9d4

[tipc-discussion] [PATCH net-next 2/3] tipc: rename udp_port in struct udp_media_addr

2016-06-22 Thread Richard Alpe
Context implies that port in struct "udp_media_addr" is referring to a UDP port. Signed-off-by: Richard Alpe --- net/tipc/udp_media.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index c9cf2be..b016c01

[tipc-discussion] [PATCH net-next 3/3] tipc: use sock addr family to indicate IP version

2016-06-22 Thread Richard Alpe
Use socket address family instead of ethernet protocol ID to identify IP version internally. --- net/tipc/udp_media.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index b016c01..c7df8bd 100644 --- a/net

[tipc-discussion] [PATCH net-next 0/3] tipc: minor UDP fixes and refactoring

2016-06-22 Thread Richard Alpe
Did some minor UDP refactoring in the midst of some UDP features I'm working on. Sending them in a separate patchset as they should make sense even without the rest of the changes I'm wokring on. Richard Alpe (3): tipc: honor msg2addr return value tipc: rename udp_port in struct udp_media_addr