Re: [tipc-discussion] [PATCH v3] tipc: add peer removal functionality

2016-08-17 Thread Jon Maloy
Yes, this looks ok. Reviewed-by: me On 08/17/2016 09:42 AM, Richard Alpe wrote: > Add TIPC_NL_PEER_REMOVE netlink command. This command can remove > an offline peer node from the internal data structures. > > This will be supported by the tipc user space tool in iproute2. > > Signed-off-by: Rich

[tipc-discussion] [PATCH v3] tipc: add peer removal functionality

2016-08-17 Thread Richard Alpe
Add TIPC_NL_PEER_REMOVE netlink command. This command can remove an offline peer node from the internal data structures. This will be supported by the tipc user space tool in iproute2. Signed-off-by: Richard Alpe Reviewed-by: Jon Maloy Acked-by: Ying Xue --- include/uapi/linux/tipc_netlink.h

Re: [tipc-discussion] [PATCH v2] tipc: add peer removal functionality

2016-08-17 Thread Jon Maloy
Hi Richard, Almost. Fix the issues I mention below, and it should be ok. ///jon On 08/17/2016 07:21 AM, Richard Alpe wrote: > Add TIPC_NL_PEER_REMOVE netlink command. This command can remove > an offline peer node from the internal data structures. > > This will be supported by the tipc user sp

[tipc-discussion] [PATCH v2] tipc: add peer removal functionality

2016-08-17 Thread Richard Alpe
Add TIPC_NL_PEER_REMOVE netlink command. This command can remove an offline peer node from the internal data structures. This will be supported by the tipc user space tool in iproute2. Signed-off-by: Richard Alpe Reviewed-by: Jon Maloy Acked-by: Ying Xue --- include/uapi/linux/tipc_netlink.h

Re: [tipc-discussion] [PATCH net-next v2 00/12] tipc: create socket FSM using sk_state only

2016-08-17 Thread Xue, Ying
I have found the following issue after the series is applied to the latest kernel: Test # 8 TIPC TIPC_IMPORTANCE test...STARTED! TEST FAILED unexpected number of send() errors errno = 113: No route to host Test # 1 Below is the procedure of how to reproduce above error: Prepare for two nodes. On

Re: [tipc-discussion] [PATCH net-next v2 00/12] tipc: create socket FSM using sk_state only

2016-08-17 Thread Xue, Ying
In the final code, it's found there is the following code: static bool filter_connect(struct tipc_sock *tsk, struct sk_buff *skb) { struct sock *sk = &tsk->sk; struct net *net = sock_net(sk); struct tipc_msg *hdr = buf_msg(skb); if (unlikely(msg_mcast(hdr)))

Re: [tipc-discussion] [PATCH 0/3] tipcutils: remove duplicated functionality

2016-08-17 Thread Parthasarathy Bhuvaragan
Hi Erik, Thanks for the patches. They are merged and is tagged with version v2.2.0. https://sourceforge.net/p/tipc/tipcutils/ci/dc8c2d324cda2e80a6e07ee1998fca0839d4a721/ regards partha On 08/15/2016 10:23 PM, Jon Maloy wrote: > If Erik doesn't have access to the tipcutils repository I suggest o

Re: [tipc-discussion] [PATCH net-next v2 07/12] tipc: create TIPC_LISTEN as a new sk_state

2016-08-17 Thread Xue, Ying
The name of tipc_set_state() is too general, so it's better to change it as: tipc_set_sk_state() Regards, Ying -Original Message- From: Parthasarathy Bhuvaragan [mailto:parthasarathy.bhuvara...@ericsson.com] Sent: Monday, August 15, 2016 5:19 PM To: tipc-discussion@lists.sourceforge.net;