Re: [tipc-discussion] [PATCH -next] tipc: use kfree_skb() instead of kfree()

2016-08-23 Thread David Miller
From: Wei Yongjun Date: Tue, 23 Aug 2016 23:01:02 + > From: Wei Yongjun > > Use kfree_skb() instead of kfree() to free sk_buff. > > Fixes: 0d051bf93c06 ("tipc: make bearer packet filtering generic") > Signed-off-by: Wei Yongjun Applied, thanks. --

Re: [tipc-discussion] [PATCH -next] tipc: use kfree_skb() instead of kfree()

2016-08-23 Thread David Miller
From: "Xue, Ying" Date: Wed, 24 Aug 2016 02:47:32 + > Acked-by: Ying Xue Please do not ACK patches like this. If you quote the patch with no demarcation in the initial column for the quoted text, like so: > From: Wei Yongjun [mailto:weiyj...@gmail.com] > Sent: Wednesday, August 24, 2016

Re: [tipc-discussion] [PATCH -next] tipc: use kfree_skb() instead of kfree()

2016-08-23 Thread Xue, Ying
Acked-by: Ying Xue -Original Message- From: Wei Yongjun [mailto:weiyj...@gmail.com] Sent: Wednesday, August 24, 2016 7:01 AM To: Jon Maloy; Xue, Ying; David S. Miller Cc: Wei Yongjun; net...@vger.kernel.org; tipc-discussion@lists.sourceforge.net Subject: [PATCH -next] tipc: use kfree_skb

[tipc-discussion] BC rcv link acked stuck after receiving a named with a BC ACK of 0

2016-08-23 Thread John THompson
Hi, I am running TIPC 2.0 on Linux 4.7 on a cluster of Freescale QorIQ P2040 and Marvell Armada-XP processors. There are 10 nodes in all. When 2 of the nodes are removed, then rejoin the cluster we sometimes see behaviour where the TIPC BC link gets stuck and eventually the backlog gets full. th

[tipc-discussion] [PATCH net-next v2 2/7] tipc: split UDP send function

2016-08-23 Thread Richard Alpe
Split the UDP send function into two. One callback that prepares the skb and one transmit function that sends the skb. This will come in handy in later patches, when we introduce UDP replicast. Signed-off-by: Richard Alpe Acked-by: Ying Xue Acked-by: Jon Maloy --- net/tipc/udp_media.c | 50 +++

[tipc-discussion] [PATCH net-next v2 7/7] tipc: add UDP remoteip dump to netlink API

2016-08-23 Thread Richard Alpe
When using replicast a UDP bearer can have an arbitrary amount of remote ip addresses associated with it. This means we cannot simply add all remote ip addresses to an existing bearer data message as it might fill the message, leaving us with a truncated message that we can't safely resume. To hand

[tipc-discussion] [PATCH net-next v2 5/7] tipc: add replicast peer discovery

2016-08-23 Thread Richard Alpe
Automatically learn UDP remote IP addresses of communicating peers by looking at the source IP address of incoming TIPC link configuration messages (neighbor discovery). This makes configuration slightly easier and removes the problematic scenario where a node receives directly addressed neighbor

[tipc-discussion] [PATCH net-next v2 4/7] tipc: introduce UDP replicast

2016-08-23 Thread Richard Alpe
This patch introduces UDP replicast. A concept where we emulate multicast by sending multiple unicast messages to configured peers. The purpose of replicast is mainly to be able to use TIPC in cloud environments where IP multicast is disabled. Using replicas to unicast multicast messages is costly

[tipc-discussion] [PATCH net-next v2 6/7] tipc: add the ability to get UDP options via netlink

2016-08-23 Thread Richard Alpe
Add UDP bearer options to netlink bearer get message. This is used by the tipc user space tool to display UDP options. The UDP bearer information is passed using either a sockaddr_in or sockaddr_in6 structs. This means the user space receiver should intermediately store the retrieved data in a lar

[tipc-discussion] [PATCH net-next v2 3/7] tipc: refactor multicast ip check

2016-08-23 Thread Richard Alpe
--- net/tipc/udp_media.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index 7033b4a..b8ec1a1 100644 --- a/net/tipc/udp_media.c +++ b/net/tipc/udp_media.c @@ -84,6 +84,17 @@ struct udp_bearer {

[tipc-discussion] [PATCH net-next v2 1/7] tipc: split UDP nl address parsing

2016-08-23 Thread Richard Alpe
Split the UDP netlink parse function so that it only parses one netlink attribute at the time. This makes the parse function more generic and allow future UDP API functions to use it for parsing. Signed-off-by: Richard Alpe Acked-by: Ying Xue Acked-by: Jon Maloy --- net/tipc/udp_media.c | 112

[tipc-discussion] [PATCH net-next v2 0/7] tipc: introduce UDP replicast

2016-08-23 Thread Richard Alpe
This series does some preparation and introduces UDP replicast. A concept where we emulate multicast by sending multiple unicast messages to configured peers. This is required for TIPC to work in environments where IP multicast is disabled. There is a corresponding patch series for the tipc user s

Re: [tipc-discussion] [PATCH net-next 1/3] tipc: transfer broadcast nacks in link state messages

2016-08-23 Thread Jon Maloy
> -Original Message- > From: Xue, Ying [mailto:ying@windriver.com] > Sent: Tuesday, 23 August, 2016 05:48 > To: Jon Maloy ; tipc-discussion@lists.sourceforge.net; > Parthasarathy Bhuvaragan ; Richard > Alpe > Cc: ma...@donjonn.com; gbala...@gmail.com > Subject: RE: [PATCH net-next 1/

Re: [tipc-discussion] [PATCH net-next 1/3] tipc: transfer broadcast nacks in link state messages

2016-08-23 Thread Xue, Ying
-Original Message- From: Jon Maloy [mailto:jon.ma...@ericsson.com] Sent: Wednesday, August 17, 2016 2:09 AM To: tipc-discussion@lists.sourceforge.net; parthasarathy.bhuvara...@ericsson.com; Xue, Ying; richard.a...@ericsson.com; jon.ma...@ericsson.com Cc: ma...@donjonn.com; gbala...@gmail