Re: [tipc-discussion] [net 5/5] tipc: remove unnecessary increasement of subscription refcount

Hi Ying, Thanks for the patches. I introduced these bugs and was sick for more than 2 weeks, so you had to fix them. I have few comments for the entire series. [tipc-discussion] [net 2/5] tipc: adjust the policy of holding subscription kref

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

> -Original Message- > From: Butler, Peter [mailto:pbut...@sonusnet.com] > Sent: Wednesday, February 22, 2017 04:31 PM > To: Jon Maloy ; tipc- > discuss...@lists.sourceforge.net > Cc: Butler, Peter > Subject: RE: TIPC Oops in tipc_sk_recv > > Hi Jon, > > I think I found the problem, wh

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

Hi Jon, Thanks for the info. The solution we are considering (to give the customer an emergency patch) is backport the TIPC code from kernel 4.4.50 into our 4.4.0 kernel source tree. From what I can see, I should be able to do so with little effort. I am assuming (?) that since 4.4.x is a lo

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

> -Original Message- > From: Butler, Peter [mailto:pbut...@sonusnet.com] > Sent: Thursday, February 23, 2017 10:25 AM > To: Jon Maloy ; tipc- > discuss...@lists.sourceforge.net > Cc: Butler, Peter > Subject: RE: TIPC Oops in tipc_sk_recv > > Hi Jon, > > Thanks for the info. The soluti

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

Hi Partha, I'll give you the short version here to save you the time of reading this entire thread. Basically I need to port the latest and greatest TIPC code (i.e. from the latest longterm kernel release, namely 4.9.11) into a 4.4.0 kernel source base. (I know that sounds ugly but it's for a

[tipc-discussion] [PATCH net 1/1] tipc: move premature initilalization of stack variables

In the function tipc_rcv() we initialize a couple of stack variables from the message header before that same header has been validated. In rare cases when the arriving header is non-linar, the validation function itself may linearize the buffer by calling skb_may_pull(), while the wrongly initiali

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

Partha - an update for you I've ported all the TIPC code from 4.9.11 into our 4.4.0 kernel code base. By this I mean I have completely removed all the existing TIPC files in their entirety from: include/uapi/linux/tipc* net/tipc/* in our 4.4.0 kernel source tree, and replaced these with all t

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

> -Original Message- > From: Butler, Peter [mailto:pbut...@sonusnet.com] > Sent: Thursday, February 23, 2017 01:09 PM > To: Jon Maloy ; tipc- > discuss...@lists.sourceforge.net; Parthasarathy Bhuvaragan > > Cc: Butler, Peter > Subject: RE: TIPC Oops in tipc_sk_recv > > Partha - an upda

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

That might be a possibility - I know the customer is close to 32 nodes however, so it might not be. I'm also looking at porting the required functionality from include/net/netlink.h and lib/nlattr.c directly into the TIPC monitor.c file (as opposed to changing any code directly in include/net a

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

> -Original Message- > From: Butler, Peter [mailto:pbut...@sonusnet.com] > Sent: Thursday, February 23, 2017 01:23 PM > To: Jon Maloy ; tipc- > discuss...@lists.sourceforge.net; Parthasarathy Bhuvaragan > > Cc: Butler, Peter > Subject: RE: TIPC Oops in tipc_sk_recv > > That might be a

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

I definitely don't want to be moving into dangerous waters, so I'll take your suggestion right now and start over -Original Message- From: Jon Maloy [mailto:jon.ma...@ericsson.com] Sent: February-23-17 1:43 PM To: Butler, Peter ; tipc-discussion@lists.sourceforge.net; Parthasarathy

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

I have changed TIPC_DEF_MON_THRESHOLD (in core.h) from 32 to 100 as suggested. I still (of course) had to comment all functionality within __tipc_nl_add_monitor_peer() so as to get around the undefined nla_put_u64_64bit() function call. As such, __tipc_nl_add_monitor_peer() is now reduced to

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

I have made the following change so as to work around the missing skwq_has_sleeper() function in our 4.4.0 kernel source stream (as required for the 4.9.11 TIPC source). This change was based on a comparison of 4.4.0 and 4.9.11 kernel code (include/net/sock.h and include/linux/wait.h). Change:

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

Just comment out all code within udp_media.c, and you should be fine. Since this sounds like legacy usage, I assume you are not planning to use UDP as bearer. ///jon > -Original Message- > From: Butler, Peter [mailto:pbut...@sonusnet.com] > Sent: Thursday, February 23, 2017 02:48 PM > T

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

Correct - we only use 'eth' as a bearer. -Original Message- From: Jon Maloy [mailto:jon.ma...@ericsson.com] Sent: February-23-17 3:03 PM To: Butler, Peter ; tipc-discussion@lists.sourceforge.net; Parthasarathy Bhuvaragan Subject: RE: TIPC Oops in tipc_sk_recv Just comment out all cod

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

I have made the following final change: this change works around the different function signature for udp_tunnel6_xmit_skb() in udp_media.c (function is defined in net/ipv6/ip6_udp_tunnel.c): Change: err = udp_tunnel6_xmit_skb(ndst, ub->ubsock->sk, skb, ndst->dev, &src->i

Re: [tipc-discussion] TIPC Oops in tipc_sk_recv

> -Original Message- > From: Butler, Peter [mailto:pbut...@sonusnet.com] > Sent: Thursday, February 23, 2017 03:30 PM > To: Jon Maloy ; tipc- > discuss...@lists.sourceforge.net; Parthasarathy Bhuvaragan > > Cc: Butler, Peter > Subject: RE: TIPC Oops in tipc_sk_recv > > I have made the