Re: [tipc-discussion] [PATCH] tipc: fix the big/little endian issue in tipc_dest

2018-08-22 Thread Jon Maloy
Now it looks good. You can add an "Acked-by" from me and send it to netdev. Note that the patch must be directed to 'net', not 'net-next', since it is a bug correction. You should also add a line "Fixes: " with reference to the patch that introduced the problem. BR ///jon > -Original

[tipc-discussion] [PATCH] tipc: fix the big/little endian issue in tipc_dest

2018-08-22 Thread Haiqing Bai
In function tipc_dest_push, the 32bit variables 'node' and 'port' are stored separately in uppper and lower part of 64bit 'value'. Then this value is assigned to dst->value which is a union like: union { struct { u32 port; u32 node; }; u64 value; } This works on little-endian