[tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-11-29 Thread Jon Maloy
We fix a very real starvation problem that may occur when the link level runs into send buffer congestion. At the same time we make the interaction between the socket and link layer simpler and more consistent. v2: - Simplified link congestion check to only check against own importance lim

Re: [tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-11-29 Thread Jon Maloy
Ying, Partha, It would be very nice I could get "acked" or "reviewed" on this so I can send it to David before net-next closes. ///jon > -Original Message- > From: Jon Maloy [mailto:jon.ma...@ericsson.com] > Sent: Tuesday, 29 November, 2016 12:04 > To: tipc-discussion@lists.sourceforge.

Re: [tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-11-30 Thread Parthasarathy Bhuvaragan
Hi Jon, With your patches, I get the following crash when loading the tipc module. Leaving home now, so couldnt investigate further. [ 58.201114] tipc: Started in single node mode [ 58.212991] Started in network mode [ 58.213796] Own node address <1.1.1>, network identity 4711 [ 58.23841

Re: [tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-11-30 Thread Jon Maloy
Weird. Looks like a corrupted incoming buffer directly at startup, before any of my new code is active. Is this repeatable? ///jon On 11/30/2016 08:52 AM, Parthasarathy Bhuvaragan wrote: > Hi Jon, > > With your patches, I get the following crash when loading the tipc > module. Leaving home now

Re: [tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-12-05 Thread Parthasarathy Bhuvaragan
Hi Jon, Sorry for the delay, could not work due to sick child. The crash occurs due to the last commit: "tipc: reduce risk of user starvation during link congestion" I examined the crash today, the crash due to array out of bounds for skb->cb[48]. The max size allowed for the callback area is 4

Re: [tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-12-05 Thread Jon Maloy
> -Original Message- > From: Parthasarathy Bhuvaragan > Sent: Monday, 05 December, 2016 15:11 > To: Jon Maloy ; Jon Maloy ; > tipc-discussion@lists.sourceforge.net; Ying Xue > Cc: thompa@gmail.com > Subject: Re: [PATCH net-next v2 0/3] tipc: improve interaction socket-link > > Hi Jo

Re: [tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-12-06 Thread Parthasarathy Bhuvaragan
On 12/05/2016 09:59 PM, Jon Maloy wrote: > > >> -Original Message- >> From: Parthasarathy Bhuvaragan >> Sent: Monday, 05 December, 2016 15:11 >> To: Jon Maloy ; Jon Maloy ; >> tipc-discussion@lists.sourceforge.net; Ying Xue >> Cc: thompa@gmail.com >> Subject: Re: [PATCH net-next v2 0/3

Re: [tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-12-06 Thread Jon Maloy
> -Original Message- > From: Parthasarathy Bhuvaragan > Sent: Tuesday, 06 December, 2016 03:46 > To: Jon Maloy ; Jon Maloy ; > tipc-discussion@lists.sourceforge.net; Ying Xue > Cc: thompa@gmail.com > Subject: Re: [PATCH net-next v2 0/3] tipc: improve interaction socket-link > > On 1

Re: [tipc-discussion] [PATCH net-next v2 0/3] tipc: improve interaction socket-link

2016-12-06 Thread Parthasarathy Bhuvaragan
On 12/06/2016 12:41 PM, Jon Maloy wrote: > > >> -Original Message- >> From: Parthasarathy Bhuvaragan >> Sent: Tuesday, 06 December, 2016 03:46 >> To: Jon Maloy ; Jon Maloy ; >> tipc-discussion@lists.sourceforge.net; Ying Xue >> Cc: thompa@gmail.com >> Subject: Re: [PATCH net-next v2