> -Original Message-
> From: Erik Hugne [mailto:erik.hu...@gmail.com]
> Sent: Wednesday, 08 June, 2016 15:39
> To: Ying Xue
> Cc: Jon Maloy; Richard Alpe; Parthasarathy Bhuvaragan; tipc-
> discuss...@lists.sourceforge.net
> Subject: Re: [RFC PATCH] tipc: fix timer handling when socket is
On Wed, Jun 08, 2016 at 01:58:18AM +, Xue, Ying wrote:
> Erik, please submit your patch to netdev with my acked-by and tested-by.
> It sounds like that Jon also acknowledged your patch :)
If you dont mind, it's better if you include it in your next batch of patches.
Also, i noticed this error
> Hi Jon,
>
> Frankly speaking, I more like to Erik's proposal than yours as Erik's
> method is more common in networking subsystem.
Ok. I have no strong opinions on this, so I accept being outvoted.
[Ying] That's great!
Erik, please submit your patch to netdev with my acked-by and tested-by
> -Original Message-
> From: Xue, Ying [mailto:ying@windriver.com]
> Sent: Saturday, 04 June, 2016 10:12
> To: Jon Maloy; Erik Hugne
> Cc: Richard Alpe; Parthasarathy Bhuvaragan; tipc-
> discuss...@lists.sourceforge.net
> Subject: RE: [RFC PATCH] tipc: fix timer handling when socket i
If/when all agrees on this, i leave it in your capable hands to
signoff/send to netdev when you feel the time is right.
//E
On Jun 7, 2016 09:46, "Xue, Ying" wrote:
> Tested-by: Ying Xue
>
> -Original Message-
> From: Erik Hugne [mailto:erik.hu...@gmail.com]
> Sent: 2016年5月31日 4:17
> To
Tested-by: Ying Xue
-Original Message-
From: Erik Hugne [mailto:erik.hu...@gmail.com]
Sent: 2016年5月31日 4:17
To: jon.ma...@ericsson.com; richard.a...@ericsson.com; Xue, Ying;
parthasarathy.bhuvara...@ericsson.com
Cc: tipc-discussion@lists.sourceforge.net; Erik Hugne
Subject: [RFC PATCH]
Hi Jon,
Frankly speaking, I more like to Erik's proposal than yours as Erik's method is
more common in networking subsystem.
Regarding the backtrace of the issue, it seems that we should not deliver
message without holding "owner" flag in BH. But we still don't hold "owner"
flag in your soluti
From: Erik Hugne [mailto:erik.hu...@gmail.com]
Sent: Thursday, 02 June, 2016 14:11
To: Ying Xue
Cc: Richard Alpe; Parthasarathy Bhuvaragan; Jon Maloy;
tipc-discussion@lists.sourceforge.net
Subject: RE: [RFC PATCH] tipc: fix timer handling when socket is owned
On Jun 2, 2016 1:03 PM, "Xue, Yin
On Jun 2, 2016 1:03 PM, "Xue, Ying" wrote:
>
> Acked-by: Ying Xue
>
> Jon, whatever the patch can fix Guna's issue or not, I think the change
is right because there is an obvious error that we deliver message through
tipc_node_xmit_skb() when "owner" flag is set.
> So, I suggest that the patch sh
Acked-by: Ying Xue
Jon, whatever the patch can fix Guna's issue or not, I think the change is
right because there is an obvious error that we deliver message through
tipc_node_xmit_skb() when "owner" flag is set.
So, I suggest that the patch should be submitted to upstream as soon as
possible.
This is just RFC for now, i have not tested it.
Following the example of tcp_write_timer, should the socket be owned
by user when the timer expires, we defer the processing to a release
callback which will be invoked when release_sock is called.
Signed-off-by: Erik Hugne
---
net/tipc/socket.c |
11 matches
Mail list logo
