Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-11-17 Thread Stephen Hicks
This looks great, thanks! On Nov 16, 2017 3:20 AM, "Nicholas Marriott" wrote: > Thanks. > > I have applied this, but I thought it was better to put the x-y and > x-y-and-cancel in the same if() block so I have changed to do that. Let > me know if you see any mistakes. > > I didn't change the def

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-11-16 Thread Nicholas Marriott
Thanks. I have applied this, but I thought it was better to put the x-y and x-y-and-cancel in the same if() block so I have changed to do that. Let me know if you see any mistakes. I didn't change the default keys. I don't want non-mouse default keys in the root table. I don't mind having binding

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-11-15 Thread Stephen Hicks
I've added the documentation. I also went ahead and added S-PageUp and S-PageDown bindings to the default keymap, the latter of which uses page-down-and-cancel. This mirrors the scrollback behavior of xterm and standard linux TTYs, and should therefore be natural for many users (provided their te

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-11-11 Thread Nicholas Marriott
thanks. you also need to add these to tmux.1 On Fri, Nov 10, 2017 at 02:53:26PM -0800, Stephen Hicks wrote: >Sorry for the delay.A I've redone the patch to instead provide the >-and-cancel versions of the three relevant commands >(cursor-down-and-cancel doesn't seem to make sense, i

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-11-11 Thread Stephen Hicks
Sorry for the delay. I've redone the patch to instead provide the -and-cancel versions of the three relevant commands (cursor-down-and-cancel doesn't seem to make sense, in my opinion, nor does it currently respect the copy-mode -e flag). On Mon, Oct 30, 2017 at 12:51 AM, Nicholas Marriott < nich

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-30 Thread Nicholas Marriott
OK well we can just leave -e for the moment and have the new commands as well assuming the new diff is pretty small. On Mon, Oct 30, 2017 at 03:50:15PM +1100, Cam Hutchison wrote: > Yes, I have Prefix-[ and Prefix-^[ set to copy-mode, and > MouseDrag1Pane, WheelUpPane and "-T root PPage" using c

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-29 Thread Cam Hutchison
Yes, I have Prefix-[ and Prefix-^[ set to copy-mode, and MouseDrag1Pane, WheelUpPane and "-T root PPage" using copy-mode -e. On 29 October 2017 at 19:34, Nicholas Marriott wrote: > Have you got some key bindings that do copy-mode -e and some that just > do plain copy-mode? > > > > On Sun, Oct 29,

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-29 Thread Nicholas Marriott
Have you got some key bindings that do copy-mode -e and some that just do plain copy-mode? On Sun, Oct 29, 2017 at 01:17:37PM +1100, Cam Hutchison wrote: > Stephen, > > Sorry for the delay in responding - life got in the way... > > Stephen Hicks wrote: > > In my mind, those two models are not

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-29 Thread Stephen Hicks
I'm not very familiar with how options work (for instance, I have no idea what the distinction is between global options and window options, aside from needing to set them slightly differently). Is the issue that there's no way to access the options from within the copy mode commands? Or that their

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-28 Thread Cam Hutchison
Stephen, Sorry for the delay in responding - life got in the way... Stephen Hicks wrote: > In my mind, those two models are not mutually exclusive. When I use the > mouse wheel to initiate a scrollback, I do tend to be in the second model, > but on the keyboard, how I enter copy mode is more rel

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-26 Thread Stephen Hicks
In my mind, those two models are not mutually exclusive. When I use the mouse wheel to initiate a scrollback, I do tend to be in the second model, but on the keyboard, how I enter copy mode is more related to whether the thing I'm looking for is on the screen or not, in addition to whether I'm sea

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-25 Thread Cam Hutchison
On 26 October 2017 at 05:39, Stephen Hicks wrote: > I appreciate the patch that went in a while back to add "copy-mode -e", > allowing to automatically exit copy-mode when reaching the bottom of the > buffer. But I find that this functionality is a bit of "spooky action at a > distance": the deci

Re: Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-25 Thread Nicholas Marriott
I think it is not a good idea to overload -R like this. There are only about four commands where this would make sense, so why not add cursor-down-and-cancel, scroll-down-and-cancel, etc. We don't need two ways to do this so then we should remove -e. On Wed, Oct 25, 2017 at 11:39:22AM -0700, St

Optionally exit copy-mode based on flag passed at scroll-down rather than scroll-up?

2017-10-25 Thread Stephen Hicks
I appreciate the patch that went in a while back to add "copy-mode -e", allowing to automatically exit copy-mode when reaching the bottom of the buffer. But I find that this functionality is a bit of "spooky action at a distance": the decision to exit depends not on the input the caused the scroll