Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Marcel Partap
>> server to crash. :) > uncrashed. ..mmh but dammit. Now only global session option "mouse-scroll-lines" will be checked, no per-session override. huh. also the code in window-copy.c would need to became an exact duplicate of the mouse-fake-scrolling code for consistency. Now what, masters of th

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Marcel Partap
> server to crash. :) uncrashed. >From 7f588c64242b3c1d8a31d3bc6aaa1b590027b776 Mon Sep 17 00:00:00 2001 From: Marcel Partap Date: Thu, 21 Jun 2012 12:01:55 +0200 Subject: [PATCH 4/4] Cleaned up implementation of mouse wheel scrolling emulation. --- trunk/examples/tmux.vim |2 +- trunk/in

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Marcel Partap
> You need to check the logic for "lines" in input_mouse() -- holding down > ctrl and scrolling down all the way to the bottom of the window causes the > server to crash. :) ANY scrolling caused crashing. Because fatalx("missing option"); Well I put the option inbetween the other mouse-* options

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Thomas Adam
On Thu, Jun 21, 2012 at 04:33:36PM +0200, Marcel Partap wrote: > G, what the rush^^ > have been working on this and here's what i have in tree right now. > > These are somewhat untested, will test and report back later... C: You need to check the logic for "lines" in input_mouse() -- holding down

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Marcel Partap
G, what the rush^^ have been working on this and here's what i have in tree right now. These are somewhat untested, will test and report back later... C: >From a824632d2fb794fbc0e64d47fc15ef6e9e219b47 Mon Sep 17 00:00:00 2001 From: Marcel Partap Date: Wed, 20 Jun 2012 15:48:27 +0200 Subject: [PAT

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Thomas Adam
On 21 June 2012 15:01, Fabio Spelta wrote: > If I move up over the first visible line and start scrolling, then getting > back works with the mouse wheel, and scrolling down with the keyboards puts > me back to the first line and exits copy mode when I am on the bottom. Not surprising. I don't h

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Fabio Spelta
2012/6/21 Fabio Spelta > >> Taking a very quick look at this, does the following help? > > > Yes, thanks, it works. > > The odd behavior is that if I have not scrolled the buffer upwards, I mean > I am browsing the screen in copy mode without getting past the top line > visible on the screen, eit

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Fabio Spelta
> > > Taking a very quick look at this, does the following help? Yes, thanks, it works. The odd behavior is that if I have not scrolled the buffer upwards, I mean I am browsing the screen in copy mode without getting past the top line visible on the screen, either moving the wheel down or pressi

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Thomas Adam
On Thu, Jun 21, 2012 at 02:43:30PM +0200, Fabio Spelta wrote: > > > > > > What exactly is the functionality you are missing Fabio? > > > None about the mouse wheel actually. :) > > I just realized, though, that it could be coherent and handy to have > a similar behavior while scrolling with the

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Fabio Spelta
> > > What exactly is the functionality you are missing Fabio? None about the mouse wheel actually. :) I just realized, though, that it could be coherent and handy to have a similar behavior while scrolling with the keyboard (hjkl, the arrow keys, or whatever one likes). When you have reached th