Re: [PATCH 2/2] Convert commands to support hooks

2013-04-11 Thread Thomas Adam
Hi, On Thu, Apr 11, 2013 at 11:32:21PM +0100, Nicholas Marriott wrote: > Should prepare actually do validation be able to return > CMD_RETURN_ERROR? Or would we want to run hooks even when we know the > command is going to fail? Thanks for this feedback, and the other point about hooks acting mor

Re: [PATCH 2/2] Convert commands to support hooks

2013-04-11 Thread Nicholas Marriott
Should prepare actually do validation be able to return CMD_RETURN_ERROR? Or would we want to run hooks even when we know the command is going to fail? I think struct cmd_ctx would be better than cmd_context, it matches all the others. Could struct cmd_q just contain a cmd_ctx rather than a point

Re: [PATCH 1/2] Define hooks infrasructure

2013-04-11 Thread Nicholas Marriott
On Mon, Apr 08, 2013 at 09:48:04AM +0100, Thomas Adam wrote: > This adds an implementation hooks using a RB tree to store the name of the > hook and the command-list it uses. These will be accessed via commands to > add/remove hooks. > --- > hooks.c | 114 > +++

Re: tmux and locales

2013-04-11 Thread Nicholas Marriott
I forgot that I did this before and just found it... diff --git a/clock.c b/clock.c index 49a883c..ec74288 100644 --- a/clock.c +++ b/clock.c @@ -103,13 +103,20 @@ clock_draw(struct screen_write_ctx *ctx, int colour, int style) struct grid_cell gc; char