Re: [PATCH] Disable 'normal' mode in copy-mode's prompt

2013-07-05 Thread Ben Boeckel
On Fri, Jul 05, 2013 at 17:47:30 +0100, Nicholas Marriott wrote: > We call them normal and command mode in the manpage under bind-key so it > should probably change that to insert and command. Ah, yep. > On Fri, Jul 05, 2013 at 12:43:05PM -0400, Ben Boeckel wrote: > > On Fri, Jul 05, 2013 at 15:5

Re: command too long

2013-07-05 Thread Nicholas Marriott
Hi On Fri, Jul 05, 2013 at 09:35:50AM -0700, Jack Bates wrote: > On 05/07/13 08:20 AM, Nicholas Marriott wrote: > >Hi > > > >On Wed, Jun 05, 2013 at 12:22:38PM -0700, Jack Bates wrote: > >>On 01/06/13 03:22 AM, Nicholas Marriott wrote: > >>>Hi > >>> > >>>What commands are you doing that regularly

Re: [PATCH] Disable 'normal' mode in copy-mode's prompt

2013-07-05 Thread Nicholas Marriott
We call them normal and command mode in the manpage under bind-key so it should probably change that to insert and command. On Fri, Jul 05, 2013 at 12:43:05PM -0400, Ben Boeckel wrote: > On Fri, Jul 05, 2013 at 15:51:32 +0100, Nicholas Marriott wrote: > > All the vi-copy defaults are for normal mo

Re: [PATCH 3/6] Don't loop in copy mode on first and last lines

2013-07-05 Thread Nicholas Marriott
Makes sense thanks. But your fix still wraps in some cases, can't spot why immediately probably due to broken EOL tracking where _down moves the cursor to the end. How about this instead? Index: window-copy.c === RCS file: /cvs/src/us

Re: [PATCH] Disable 'normal' mode in copy-mode's prompt

2013-07-05 Thread Ben Boeckel
On Fri, Jul 05, 2013 at 15:51:32 +0100, Nicholas Marriott wrote: > All the vi-copy defaults are for normal mode (insert mode), so > presumably this comment should be different. In vi, 'normal' is the command mode (inserting happens in 'insert' mode). > There is nothing stopping people binding com

Re: [PATCH 5/6] Move to the indentation of a line on scrolling

2013-07-05 Thread Ben Boeckel
On Fri, Jul 05, 2013 at 17:14:32 +0100, Nicholas Marriott wrote: > I don't really see this as better? At the moment I think we stick to the > column we were on which seems more sensible. emacs seems to move to > column 0 which seems worse than either though. Looking at the docs, Vim's behavior is

Re: [PATCH 4/6] Implement EOL tracking

2013-07-05 Thread Ben Boeckel
On Fri, Jul 05, 2013 at 17:12:03 +0100, Nicholas Marriott wrote: > The EOL tracking seems to be a bit broken at the moment but I don't > think this is right either, it should work like emacs - when you go to > the end of a line, that column becomes sticky. So with: > > xx > abcdef > abc > > If yo

Re: [PATCH 3/6] Don't loop in copy mode on first and last lines

2013-07-05 Thread Ben Boeckel
On Fri, Jul 05, 2013 at 16:56:33 +0100, Nicholas Marriott wrote: > Hi. What's the behaviour here before and after? Before, if you went "left" from the top-left corner was the top-right corner since (cy = = max(0, cy - 1); cx = end_of_line(cy);) was done. Something similar for the "right" of bottom

Re: [PATCH 5/6] Move to the indentation of a line on scrolling

2013-07-05 Thread Nicholas Marriott
I don't really see this as better? At the moment I think we stick to the column we were on which seems more sensible. emacs seems to move to column 0 which seems worse than either though. On Wed, Jun 12, 2013 at 02:17:59AM -0400, Ben Boeckel wrote: > When scrolling by page or half-page, vim moves

Re: [PATCH 4/6] Implement EOL tracking

2013-07-05 Thread Nicholas Marriott
Hi The EOL tracking seems to be a bit broken at the moment but I don't think this is right either, it should work like emacs - when you go to the end of a line, that column becomes sticky. So with: xx abcdef abc If you go to the second line and then press C-e to move to th end, then press up, th

Re: [PATCH 3/6] Don't loop in copy mode on first and last lines

2013-07-05 Thread Nicholas Marriott
Hi. What's the behaviour here before and after? On Wed, Jun 12, 2013 at 02:17:57AM -0400, Ben Boeckel wrote: > Because we first move to the first column, then down, on the last line, > the first column is to "the right" of the last column. To fix this, the > current line is checked and if it chan

Re: patch for tmux on cygwin

2013-07-05 Thread Nicholas Marriott
Are you sure ECHOPRT 0x20 is right on Cygwin? Maybe it should be 0 to leave it out if it isn't supported? Also some other minor tweaks. diff --git a/client.c b/client.c index 691ace3..b9e3b30 100644 --- a/client.c +++ b/client.c @@ -328,8 +328,13 @@ client_send_identify(int flags) str

Re: [PATCH] Add pane_synchronized window format

2013-07-05 Thread Nicholas Marriott
Applied, thanks. On Sun, Jun 02, 2013 at 07:34:46PM +0200, Romain Francoise wrote: > I would find it useful to have a visual reminder that panes are > synchronized in my status line, so add a 'pane_synchronized' > format that can be used as a conditional. > > Thanks, > > diff --git a/format.c b/

Re: command too long

2013-07-05 Thread Nicholas Marriott
Hi On Wed, Jun 05, 2013 at 12:22:38PM -0700, Jack Bates wrote: > On 01/06/13 03:22 AM, Nicholas Marriott wrote: > > Hi > > > > What commands are you doing that regularly exceed 2048 bytes and why > > Thank you Nicolas, I often use tmux as part of scripts that run long > processes on Amazon EC2 i

Re: [PATCH 1/1] FAQ: Mention copying tmux selection to clipboard

2013-07-05 Thread Nicholas Marriott
How about this instead? diff --git a/FAQ b/FAQ index 41b917c..f44384b 100644 --- a/FAQ +++ b/FAQ @@ -396,5 +396,25 @@ configuration file: Or the default window options: $ tmux -Lfoo -f/dev/null start\; show -gw + +* How do I copy a selection from tmux to the system's clipboard? + +When

Re: [PATCH 1/1] new-session: Allow start-directory via -c

2013-07-05 Thread Nicholas Marriott
I think it'd be better if $HOME, ~, . etc worked using c->cwd instead of s->cwd. Not sure if it'd be nicer to change arguments to cmd_get_default_path or add a new function... Although in the end this is just sugar to hide (cd /my/dir; tmux new). On Thu, Jul 04, 2013 at 09:42:22PM +0100, Thomas

Re: [PATCH] Disable 'normal' mode in copy-mode's prompt

2013-07-05 Thread Nicholas Marriott
All the vi-copy defaults are for normal mode (insert mode), so presumably this comment should be different. There is nothing stopping people binding commands in either mode though (and for all I know people do) so not sure we should prevent it like this. On Wed, Jun 12, 2013 at 09:31:52PM -0400