[PATCH 3d/3] Allow custom key tables for e.g. multiple keystroke bindings.

2014-05-15 Thread Keith Amling
> > + format_add(ft, "client_keytablename", "%s", c->keytable->name); > > Let's call it client_key_table to fit the style of most of the others. Done. > > +struct key_table * > > +key_bindings_lookup_table(const char *name, int create) > > I don't think it is intuitive for a lookup function t

Re: [PATCH 2/3] Copy mode commands left-prune and right-prune to match screen's c and C.

2014-05-15 Thread Keith Amling
> I don't really see this, why not start a rectangle selection on the "s" > then go to the end of the longest line and move down from there? For much longer status outputs it can be a long trip from the longest line to the bottom and it may not even be obvious without serious eyeball work which li

Re: [PATCH 3c/3] Allow custom key tables for e.g. multiple keystroke bindings.

2014-05-15 Thread Nicholas Marriott
Hi A few comments inline: > diff --git a/format.c b/format.c > index 6f988b9ac2cc..8630aabed5d7 100644 > --- a/format.c > +++ b/format.c > @@ -435,7 +435,8 @@ format_client(struct format_tree *ft, struct client *c) > *strchr(tim, '\n') = '\0'; > format_add(ft, "client_activity_string"

Re: [PATCH 2/3] Copy mode commands left-prune and right-prune to match screen's c and C.

2014-05-15 Thread Nicholas Marriott
I don't really see this, why not start a rectangle selection on the "s" then go to the end of the longest line and move down from there? If that's too awkward, I don't like this as an extra adjustment to the selection, I think it should be a special case of rectangle selection - something like a k

Re: [tmux:tickets] #122 Configuration of pane switching behavior

2014-05-15 Thread Nicholas Marriott
It went into OpenBSD, not sure it made it to SF yet. On Wed, May 14, 2014 at 09:08:27AM -0700, Suraj Kurapati wrote: > On Sun, Apr 20, 2014 at 2:22 PM, Suraj Kurapati wrote: > > On Sun, Apr 20, 2014 at 12:38 AM, Nicholas Marriott wrote: > >> I don't want to have two ways to do directional movemen