Re: [PATCH] vi-copy: select line with V

2014-08-07 Thread Juho Pohjala
Hi Thanks for the comments! Please check the updated patch. > in mode-keys.c you should also update the mode_key_cmdstr_copy array Yes, new line was already included in the previous patch. BR, Juho On Thu, Aug 7, 2014 at 11:06 PM, Nicholas Marriott wrote: > Yes I will look at this after Open

Re: [PATCH] Implement command to enable / disable input

2014-08-07 Thread Anish Athalye
Thanks for the quick feedback! I've attached an updated patch. –Anish 0001-Add-feature-to-enable-or-disable-keyboard-input.patch Description: Binary data > On Aug 7, 2014, at 1:01 PM, Nicholas Marriott > wrote: > > Ok but in that case you also need to add it to the last-pane synopsis. > >

Re: [PATCH] vi-copy: select line with V

2014-08-07 Thread Nicholas Marriott
Yes I will look at this after OpenBSD tree unlocks. On Wed, Jul 23, 2014 at 09:49:13PM +0100, Balazs Kezes wrote: > On 2014-07-13 00:59 +0300, Juho Pohjala wrote: > > Please have a look at the updated patch. > > Thanks, this works surprisingly well! Some nits: in mode-keys.c you > should also up

Re: [PATCH] Add wait-for signaling to commands that create new panes

2014-08-07 Thread Nicholas Marriott
Hi What is this useful for? This seems like a job for hooks if they are ever finished. On Mon, Aug 04, 2014 at 01:59:26PM -0400, Nathaniel W Filardo wrote: > Greetings list, > > The attached patch adds options to new-window, new-session, and split-window > (commands which create panes) to sign

Re: [PATCH] Implement command to enable / disable input

2014-08-07 Thread Nicholas Marriott
Ok but in that case you also need to add it to the last-pane synopsis. Also I don't see a need for any more one-line helper functions, just set and clear the flag directly and do without server_enable/disable_input. This: + "[-ed] [-lDLRU] " CMD_TARGET_PANE_USAGE, Should be changed to -Dd

Re: [PATCH] Implement command to enable / disable input

2014-08-07 Thread Anish Athalye
The last-pane section is also the part that runs if you `select-pane -l`. As the patch is now, running `select-pane -d -l` will disable input for the last pane that you were in. I think that behavior is more intuitive than having that function not work (because something like `select-pane -d -U`

Re: [PATCH] Implement command to enable / disable input

2014-08-07 Thread Nicholas Marriott
Hi You don't need to add these to the last-pane section as well, just to select-pane. Also can you update the man page? Cheers On Thu, Aug 07, 2014 at 04:09:30PM +, Anish R Athalye wrote: > Oh, good idea. I think adding it to the select-pane command makes more sense. > > Please see attach

Re: [PATCH] Implement command to enable / disable input

2014-08-07 Thread Anish R Athalye
Oh, good idea. I think adding it to the select-pane command makes more sense. Please see attached patch. –Anish 0001-Add-feature-to-enable-or-disable-keyboard-input.patch Description: Binary data On Aug 7, 2014, at 8:16 AM, Nicholas Marriott wrote: > Please make this a flag or a pair of

Re: [PATCH] Implement command to enable / disable input

2014-08-07 Thread Nicholas Marriott
Please make this a flag or a pair of flags on an existing command. Maybe select-pane or kill-pane. On Thu, Aug 07, 2014 at 07:25:27AM +, Anish R Athalye wrote: > Here?s a slightly modified version of the patch ? changed the interface > slightly (better names). > > ?Anish > > > > > On A

Re: [PATCH] Implement command to enable / disable input

2014-08-07 Thread Anish R Athalye
Here’s a slightly modified version of the patch — changed the interface slightly (better names).–Anish 0001-Implement-command-to-enable-disable-input.patch Description: Binary data On Aug 6, 2014, at 11:58 PM, Anish R Athalye wrote:I think that it would be nice to have the abili

[PATCH] Implement command to enable / disable input

2014-08-07 Thread Anish R Athalye
I think that it would be nice to have the ability to make specific panes read only (switching from read/write).I’ve wanted this feature to keep myself from accidentally sending input to certain processes that I’ve started in certain panes (that I’m just monitoring). This would be great for things l