Re: [PATCH] Mouse wheel support v6

2014-06-19 Thread Nicholas Marriott
Ok, I went with your other diff to set it to 3 in the wheel case. Thanks. On Sat, May 31, 2014 at 11:41:02AM +0100, Balazs Kezes wrote: > On 2014-05-27 13:58 +0100, Nicholas Marriott wrote: > > --- tty-keys.c 8 May 2014 07:54:47 - 1.66 > > +++ tty-keys.c 27 May 2014 12:58:40 -

Re: [PATCH] Mouse wheel support v6

2014-05-31 Thread Balazs Kezes
On 2014-05-27 13:58 +0100, Nicholas Marriott wrote: > --- tty-keys.c8 May 2014 07:54:47 - 1.66 > +++ tty-keys.c27 May 2014 12:58:40 - > @@ -782,8 +782,8 @@ tty_keys_mouse(struct tty *tty, const ch > m->sy = y; > m->event = MO

Re: [PATCH] Mouse wheel support v6

2014-05-27 Thread Nicholas Marriott
Hmm, can you try this please instead? I don't have a mouse wheel... Index: tty-keys.c === RCS file: /cvs/src/usr.bin/tmux/tty-keys.c,v retrieving revision 1.66 diff -u -p -r1.66 tty-keys.c --- tty-keys.c 8 May 2014 07:54:47 -

Re: [PATCH] Mouse wheel support v6

2014-05-24 Thread Balazs Kezes
On 2014-05-23 11:59 +0100, Nicholas Marriott wrote: > Shouldn't we instead reset m->button when the mouse wheel is used? Yep, that works as well. I've chosen 3 as the reset value because that's what I've seen in server_client_create as initialization value. Here's the patch: diff --git a/tty-keys

Re: [PATCH] Mouse wheel support v6

2014-05-23 Thread Nicholas Marriott
Shouldn't we instead reset m->button when the mouse wheel is used? On Sat, May 17, 2014 at 10:44:17AM +0100, Balazs Kezes wrote: > Sorry, forgot to attach a simple patch to fix this: > > diff --git a/input-keys.c b/input-keys.c > index 7531f22..4c4da91 100644 > --- a/input-keys.c > +++ b/input-k

Re: [PATCH] Mouse wheel support v6

2014-05-17 Thread Balazs Kezes
Sorry, forgot to attach a simple patch to fix this: diff --git a/input-keys.c b/input-keys.c index 7531f22..4c4da91 100644 --- a/input-keys.c +++ b/input-keys.c @@ -259,7 +259,7 @@ input_mouse(struct window_pane *wp, struct session *s, struct mouse_event *m) paste_send_pan

Re: [PATCH] Mouse wheel support v6

2014-05-16 Thread Balazs Kezes
On 2014-03-05 11:50 +0100, Marcel Partap wrote: > diff --git a/input-keys.c b/input-keys.c > index 7582a63..b76dd6c 100644 > --- a/input-keys.c > +++ b/input-keys.c > @@ -244,7 +260,7 @@ input_mouse(struct window_pane *wp, struct session *s, > struct mouse_event *m) > paste_s

Re: [PATCH] Mouse wheel support v6

2014-04-03 Thread Nicholas Marriott
never mind, this was the latest, i'd just tweaked it. found it in a git rather than a cvs tree. i've applied all of this except the emulation-in-cup-mode bit so far which i'm not entirely convinced about right now thanks! On Wed, Apr 02, 2014 at 07:29:06PM +0100, Nicholas Marriott wrote: > Hi

Re: [PATCH] Mouse wheel support v6

2014-04-02 Thread Nicholas Marriott
Hi Did you send me a later version of this? I can't find it :-/. Cheers On Thu, Mar 06, 2014 at 12:46:28PM +, Nicholas Marriott wrote: > Some changes, notably: > > - Broke the define changes into separate diffs and applied them. > > - I don't like it assuming that if m->scroll != 0 the w

Re: [PATCH] Mouse wheel support v6

2014-03-06 Thread Nicholas Marriott
Some changes, notably: - Broke the define changes into separate diffs and applied them. - I don't like it assuming that if m->scroll != 0 the wheel is in use, it is more understandable if it checks the event. - In window-choose.c the return was in the wrong place. Originally the idea of havin

[PATCH] Mouse wheel support v6

2014-03-05 Thread Marcel Partap
(+ some other changes regarding mouse implementation) - is u_int for i ok? - was there a valid reason to use bit shifts for MOUSE_EVENT_* constants? - ... --- input-keys.c| 18 +- server-fn.c | 1 + tmux.h | 23 +-- tty-keys.c | 27 +