Re: [PATCH] Give descriptive message when no sessions present

2015-04-21 Thread Nicholas Marriott
I've tweaked the errors slightly anyway to hopefully make them a bit simpler. thanks On Wed, Apr 15, 2015 at 08:47:05PM +0530, Karthik K wrote: >Hmm.. Your arguments do hold merit. It's just that everyone I know have >been stumped by this message when they start using tmux. Just felt that

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Nicholas Marriott
I think we should change it to just "no server running" or something, it better matches the "no sessions" that you get if you try "tmux attach": diff --git a/client.c b/client.c index 042ec92..e8d2b25 100644 --- a/client.c +++ b/client.c @@ -261,8 +261,12 @@ client_main(int argc, char **argv, int

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Karthik K
Hmm.. Your arguments do hold merit. It's just that everyone I know have been stumped by this message when they start using tmux. Just felt that the error message should be more descriptive explaining the most common reason for connection being refused. On Apr 15, 2015 8:33 PM, "Nicholas Marriott"

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Nicholas Marriott
We could change it to something like "couldn't connect to server" or ask "is the server running?" but I don't see much difference from "failed to connect to server". I don't think it is sensible to mention sessions, for tmux the server is "the process that contains the sessions" by definition, we

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Thomas Adam
On 15 April 2015 at 15:50, Karthik K wrote: > Although the explanation for what a server is, is given in the man page, the > argument still holds. The error message just makes you think that there is > something wrong with the connection. Which is correct; no sessions means no server. I really w

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Karthik K
Although the explanation for what a server is, is given in the man page, the argument still holds. The error message just makes you think that there is something wrong with the connection. If it's not possible to patch the code, maybe atleast an entry can be added at the end of the manpage detaili

Re: [PATCH] Give descriptive message when no sessions present

2015-04-15 Thread Nicholas Marriott
Hi I think the current message is fine. We describe what is meant by "server" in the first few paragraphs of the man page. On Wed, Apr 15, 2015 at 08:06:58PM +0530, Karthik K wrote: > --- > client.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/client.c