Re: patch allowing attach to take and select a pane

2014-01-22 Thread Nicholas Marriott
Yes - applied, thanks. On Sun, Jan 12, 2014 at 12:10:48AM -0600, J Raynor wrote: > On Mon, Jan 6, 2014 at 9:22 AM, Nicholas Marriott > wrote: > > Hmm... I don't know, people who include periods in session names are > > probably just asking for trouble but maybe we should ban them earlier. > >

Re: patch allowing attach to take and select a pane

2014-01-11 Thread J Raynor
On Mon, Jan 6, 2014 at 9:22 AM, Nicholas Marriott wrote: > Hmm... I don't know, people who include periods in session names are > probably just asking for trouble but maybe we should ban them earlier. By "ban them earlier" do you mean never allow periods in session names? If so, the attached pa

Re: patch allowing attach to take and select a pane

2014-01-06 Thread Nicholas Marriott
Hmm... I don't know, people who include periods in session names are probably just asking for trouble but maybe we should ban them earlier. On Tue, Dec 10, 2013 at 05:10:16PM -0600, J Raynor wrote: > This works fine. However, as of 1.8, it is possible to have a period > in the session name and t

Re: patch allowing attach to take and select a pane

2013-12-10 Thread J Raynor
This works fine. However, as of 1.8, it is possible to have a period in the session name and to attach to it. With this patch, it's no longer possible to attach to such a session since the period is interpreted as a pane specifier. Does that matter? -

Re: patch allowing attach to take and select a pane

2013-12-10 Thread Nicholas Marriott
Hi This can be a little simpler since cmd_lookup_*id will do the check for % or @ for you. Also -t.1 is valid for a pane, it doesn't need a :. Try this please: Index: cmd-attach-session.c === RCS file: /cvs/src/usr.bin/tmux/cmd-att

Re: patch allowing attach to take and select a pane

2013-11-19 Thread J Raynor
> Can't you just use cmd_find_pane? If the user doesn't specify a pane > it'll default to the active pane anyway so selecting it'll be a no-op. Your suggestion got me to look at my patch again, and I think it could've been clearer. I've attached an updated patch. Everything should behave the sam

Re: patch allowing attach to take and select a pane

2013-11-18 Thread J Raynor
> Can't you just use cmd_find_pane? If the user doesn't specify a pane > it'll default to the active pane anyway so selecting it'll be a no-op. Do you mean use a patch like this: diff --git a/cmd-attach-session.c b/cmd-attach-session.c index e4c0b23..7f7153e 100644 --- a/cmd-attach-session.c +++

Re: patch allowing attach to take and select a pane

2013-11-18 Thread Nicholas Marriott
Hi Can't you just use cmd_find_pane? If the user doesn't specify a pane it'll default to the active pane anyway so selecting it'll be a no-op. On Sat, Nov 16, 2013 at 11:44:37PM -0600, J Raynor wrote: > The TODO list has this item: > > * attach should take a pane and select it as well as attach

patch allowing attach to take and select a pane

2013-11-16 Thread J Raynor
The TODO list has this item: * attach should take a pane and select it as well as attaching I've attached a patch that implements this. You can specify a pane with %, or a window with @, just as before, but tmux will switch to that pane or window. You can also specify windows and panes with th