Re: Portable SSL Support

2001-11-16 Thread William Barker
I was thinking of moving it to Http10Interceptor.getInfo, but otherwise that was more or less what I was thinking. - Original Message - From: "jean-frederic clere" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Friday, November 16, 2001 3:10 AM Subject: Re: Port

Re: Wrap an HttpServletRequest

2001-11-14 Thread William Barker
Craig's correct. It's not legal in 3.x (and also won't work). However, if all you want to do is to set parameters, you can simply add them to the query string of the URL that you pass to getRequestDispatcher. - Original Message - From: "Craig R. McClanahan" <[EMAIL PROTECTED]> To: "Tomca

Re: Portable SSL Support

2001-11-14 Thread William Barker
- Original Message - From: "Eric Rescorla" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Wednesday, November 14, 2001 9:17 AM Subject: Re: Portable SSL Support > jean-frederic clere <[EMAIL PROTECTED]> writes: > > Eric Rescorla wrote:

Re: Portable SSL Support

2001-11-13 Thread William Barker
I was originally leaning towards 2a, but Costin has convinced me of the merits of 2b+1. It is simplest and more generalizable to Ajp14/JNI in j-t-c. It also allows you to skip implementing the pooling/recycling stuff (since it should be possible to reuse one instance per connector). If you deci

Re: [VOTE] Release Plan for Tomcat 3.3 (final release)

2001-09-10 Thread William Barker
For what it's worth (since I can't vote), I agree with Jon. TC3.3 hasn't had a long enough beta cycle yet to push through an RC cycle this fast. As it is, I'm going to be lucky to have time to install RC1 before RC2 comes out. Keeping up with 4.0 isn't a good enough reason, since I'm sure that

[PATCH] Potential security problem with '?' in jsp file name TC3.3B1

2001-08-15 Thread William Barker
Using: Apache 1.3.17 TC3.3 B1 Ajp13 Java 1.3.1 making the request http://myserver/%3f%41%3d%42.jsp was interpreted as a request for the file "/?A=B.jsp". JspInterceptor then happily creates a page containing the contents of the ROOT directory. The attached patch forbids such silliness. JspI

[PATCH] ajp13 logs 500 code on stop button

2001-08-06 Thread William Barker
This is only a cosmetic patch, so it may not make the cut for TC3.3, but the diff is against TC3.3B1. At the moment, when the user hits the "stop" button, it shows up in the Apache logs with a status code of 500 (regardless of the status code returned by Tomcat). With this patch, the Apache

[PATCH] Smart mappings + map-root confuses Apache TC3.3B1

2001-07-30 Thread William Barker
The configuration: causes ApacheConfig to output a line of the form: Alias / /path/to/ROOT which makes Apache very unhappy when trying to find static files. One alternative to the attached patch would be to simply output a DocumentRoot directive for this special case, but I thought that t

[PATCH] Ajp13 wrong Response

2001-07-09 Thread William Barker
This fixes the problem reported by Angel Aray in thread 23795. The diff is against TC3.3 M4. What was happening is that the user hitting the "stop" button in the browser was invoking the re-try broken connection logic. This totally freaks out the proxy server who now thinks that the re-sent pag

[PATCH] Exporting servlet-mappings to Apache/mod_jk TC3.3-M4

2001-07-02 Thread William Barker
I don't really expect this to be approved for inclusion, since it relies on ApacheConfig having too much knowledge about Context internals. I'm submitting it primarily to demonstrate to the ajp14/warp crowd that it is possible to auto-generate mappings short of "JkMount /my-app/* ajp13". Apa

[PATCH] JspInterceptor compilation class path wrong TC3.3M2

2001-04-26 Thread William Barker
When setting the classpath for compilation, JspInterceptor (or more correctly, JasperLiaison) includes the "container" and excludes the "apps". This sort of defeats the purpose of having the "apps" in the first place. I've patched my copy of JspInterceptor.java as follows: *** JspInterceptor.j

[PATCH] bufferSize overflows in BodyContentImpl TC3.3M2

2001-04-03 Thread William Barker
The bufferSize variable in BodyContentImpl is declared as an int. This results in an integer overflow very quickly for even moderately big output. (Think displaying the results of a SQL table as a HTML table). I imagine that the ultimate solution will be to declare it as a long, but in the mean

[PATCH] JspInterceptor can't find jsp file in TC3.3M2

2001-04-03 Thread William Barker
If you use a in your web.xml file, JspInterceptor attempts to compile the mapped name rather than the actual jsp file. I've patched my copy of tomcat by: *** JspInterceptor.java.origTue Apr 3 12:56:11 2001 --- JspInterceptor.java Tue Apr 3 12:59:58 2001 *** *** 585,590

Re: TC3.3m1 Possible bug with session.invalidate

2001-03-06 Thread William Barker
Title: Re: TC3.3m1 Possible bug with session.invalidate The place to look is src/share/org/apache/tomcat/modules/session/SimpleSessionStore.java.  Or, better, get the latest version of this file since the bug was fixed about two weeks ago. - Original Message - From: Dunlop,

Re: Tag Handler Pooling Clarification

2001-03-06 Thread William Barker
My reading of the spec is that after calling Tag.release, the tag handler could be safely put back into the pool. However calling Tag.release after doEndTag isn't mandatory. If the compiler is smart enough, it may re-use a tag without releasing it first if the second invocation uses a super-set o

[PATCH] Exporting Servlet mappings for mod_jk

2001-03-01 Thread William Barker
It was getting to be too much work to keep my web.xml files synced with httpd.conf, so I got ApacheConfig.java to do it for me. The following is for Tomcat 3.3M1: *** ApacheConfig.java.orig Thu Mar 1 16:40:46 2001 --- ApacheConfig.java Thu Mar 1 16:38:26 2001 *** *** 328,337

Re: Bugzilla #512 is Bunk

2001-03-01 Thread William Barker
JkWorkersFiles is the main problem inside of a VirtualHost. I don't know about JkLogFile. JkMount is legal inside of a VirtualHost. - Original Message - From: "Stephen Jones" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Wednesday, February 28

Re: [Security Issue] Sessions are visible across multiple clients

2001-02-28 Thread William Barker
It has more to do with a bug in SimpleSessionStore.java. It recycles the session on create, so then the instance is re-used for the next new session. I've patched it via: *** SimpleSessionStore.java.origMon Feb 26 14:59:53 2001 --- SimpleSessionStore.java Wed Feb 28 09:36:40 2001

[PATCH] JspInterceptor losing jsp file name - Tomcat 3.3M1

2001-02-27 Thread William Barker
When a JSP file is specified via a servlet-mapping in the web.xml file, tomcat tries to compile the mapping rather than the JSP file. *** JspInterceptor.java.origTue Feb 27 18:58:50 2001 --- JspInterceptor.java Tue Feb 27 18:59:10 2001 *** *** 585,590 --- 585,591

Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup Main.java

2001-02-26 Thread William Barker
This is a very nice feature. Just for cleanliness, you might want to remove the "tomcat.cp" property logic at line #426. - Original Message - From: <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, February 26, 2001 1:42 AM Subject: cvs commit: jakarta-tomcat/src/share/org/apache/

Bug in Request.isUserInRole - Tomcat 3.3

2001-02-23 Thread William Barker
Request.isUserInRole doesn't allow an interceptor to DECLINE (and is inconsistent with Context). The following change to org/apache/tomcat/core/Request.java brings it in line: 488c488 < if ( status != 0 ) { --- > if ( status != BaseInterceptor.DECLINED ) { 492c492 < r

ClassPath problem with Tomcat 3.3

2001-02-22 Thread William Barker
It seems that the only way to add files to the CLASSPATH in 3.3 is via the tomcat.cp property, but it doesn't seem to be working quite right. Below is the patch to org/apache/tomcat/startup/Main.java that works for me. 133,134c133,134 < if( ! base.endsWith( "/" ) ) < ba