RE: [PATCH] log output can get messed up with org.apache.catalina.logger.FileLogger

2002-02-20 Thread Kevin Seguin
> > Another way to fix this would be to use String concatenation. > The question > is, which is more expensive, the synchronization or the > String concatenation? > yeah, that occurred to me too... anybody have an answer? > This is how the code would be with String concatenation: > >

Re: [PATCH] log output can get messed up with org.apache.catalina.logger.FileLogger

2002-02-19 Thread Remy Maucherat
> attached is a patch with one possible solution - i could commit this, but i generally > don't commit on tomcat4, so i'd like some +1's before committing :) +1, but you don't need my permission (I'd complain if I don't like a patch). If you can, commit the patch on both branches. Thanks, Remy

[PATCH] log output can get messed up with org.apache.catalina.logger.FileLogger

2002-02-19 Thread Kevin Seguin
if a lot of log messages are being written to a file by a lot of threads using org.apache.catalina.logger.FileLogger, the output can get messed up so that you get things like this: [timestamp-1] [timestamp-2] [message-1] [message-2] instead of this: [timestamp-1] [message-1] [timestamp-2] [me