Hi Kurt,
> I've reviewed your patch and have some comments included inline below.
> regcomp and ap_pregcomp are not interchangeable like this. ap_pregcomp
> needs an apr_pool to be passed to it and it returns the regex_t. I
> think (apr_pool_t *)uriEnv->pool->_private is correct here (Henri?,
> Je
Hi Guenter,
Just a tweak or two and its ready. The preg calloc only applies to the
HAS_PCRE case and PREGCOMP isn't needed. Otherwise it looks good. I'll
test and commit it tomorrow.
-Kurt
From: "Guenter Knauf" <[EMAIL PROTECTED]>
> Hi Kurt,
> > I've reviewed your patch and have some comments in
Hi Kurt,
> Just a tweak or two and its ready. The preg calloc only applies to the
> HAS_PCRE case and PREGCOMP isn't needed. Otherwise it looks good. I'll
> test and commit it tomorrow.
yep, forgot to remove PREGCOMP.
you mean perhaps so:
{
#ifdef HAS_AP_PCRE
regex_t *preg = a
