Re: TC3.2.1 - response commit on included JSPs

2001-02-26 Thread cmanolache
> > " if that destination is another character or > > byte stream, flush it." > > > > In this case, the destination is the servlet output > > stream - and it has to be flushed. > > That is only because the particular servlet engine > implementation implements the ServletOutputStream of > the Re

Re: TC3.2.1 - response commit on included JSPs

2001-02-24 Thread Mel Martinez
--- [EMAIL PROTECTED] wrote: > > I won't contest that, but I would suggest > considering > > the idea that the final, or intended destination > is > > not necessarily the browser. In the case of an > > included resource, it is the calling servlet that > is > > acting as client to the included re

Re: TC3.2.1 - response commit on included JSPs

2001-02-23 Thread cmanolache
> I won't contest that, but I would suggest considering > the idea that the final, or intended destination is > not necessarily the browser. In the case of an > included resource, it is the calling servlet that is > acting as client to the included resource. In good OO > design, it should be in

Re: TC3.2.1 - response commit on included JSPs

2001-02-23 Thread Mel Martinez
--- [EMAIL PROTECTED] wrote: > > > My expectation ( as a java user ) would be that if I > call > out.flush() the data will be written to the final > destination. > I won't contest that, but I would suggest considering the idea that the final, or intended destination is not necessarily the br

Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread cmanolache
> > The problem is that flush() must still be executed > > as expected, > > i.e. if an included JSP or servlet is actually > > calling flush(), > > it expects the response to be commited. > > > > But does that necessarily mean to commit it to the > browser? Or should it instead just commit it

Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread Mel Martinez
--- [EMAIL PROTECTED] wrote: > > > Second, while there is a flushBuffer() method in > > JspWriterImpl, this method is NOT a part of the > > javax.servlet.jsp.JspWriter interface nor is it > public > > (it is protected). > > We can make it public - and the generated servlets > already depends >

Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread cmanolache
> Two points come to mind here. First off, I totally > agree that at the end of the page the buffer should be > 'committed' to the underlying ServletOutputStream - > but I also believe that the ServletResponse should not > be committed from within a dynamically included > servlet or JSP page - is

Autoreply: Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread bwheeler
EMAIL PROTECTED]> Delivered-To: mailing list [EMAIL PROTECTED] Message-ID: <[EMAIL PROTECTED]> Date: Thu, 22 Feb 2001 11:45:52 -0800 (PST) From: Mel Martinez <[EMAIL PROTECTED]> Subject: Re: TC3.2.1 - response commit on included JSPs To: [EMAIL PROTECTED], [EMAIL PROTECTED] Cc: [

Autoreply: Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread bwheeler
EMAIL PROTECTED]> Delivered-To: mailing list [EMAIL PROTECTED] Message-ID: <[EMAIL PROTECTED]> Date: Thu, 22 Feb 2001 11:45:52 -0800 (PST) From: Mel Martinez <[EMAIL PROTECTED]> Subject: Re: TC3.2.1 - response commit on included JSPs To: [EMAIL PROTECTED], [EMAIL PROTECTED] Cc: [

Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread Mel Martinez
Re: out.flush() sets the 'committed' state in the response in tc3.2.1 JspWriterImpl. --- [EMAIL PROTECTED] wrote: > Hi Mel, > > First, JspWriter needs to be flushed at the end of > the page - it has a > buffer, and if the buffer is not commited the data > will be lost. > There is a method ( flus

Autoreply: Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread bwheeler
PROTECTED]> Delivered-To: mailing list [EMAIL PROTECTED] From: [EMAIL PROTECTED] Date: Thu, 22 Feb 2001 09:52:58 -0800 (PST) X-Sender: [EMAIL PROTECTED] To: [EMAIL PROTECTED] cc: [EMAIL PROTECTED] Subject: Re: TC3.2.1 - response commit on included JSPs In-Reply-To: <[EMAIL PROTECTED]> M

Re: TC3.2.1 - response commit on included JSPs

2001-02-22 Thread cmanolache
On Wed, 21 Feb 2001, Mel Martinez wrote: > IMHO out.flush() should not commit the response. Only > response.flushBuffer() should commit the response. > And response.flushBuffer() should not be called from > an inside an 'include' request. Hi Mel, First, JspWriter needs to be flushed at the en

RE: TC3.2.1 - response commit on included JSPs

2001-02-21 Thread Mel Martinez
--- Larry Isaacs <[EMAIL PROTECTED]> wrote: > to the spec. Your discussion below about the > JspWriterImpl > seems to be something different. > > So rather than quess, let me ask exactly what are > you > referring to when you say, "dynamic include of a JSP > page"? > > Is this , PageContext.in

Re: TC3.2.1 - response commit on included JSPs

2001-02-21 Thread Mel Martinez
--- Incze Lajos <[EMAIL PROTECTED]> wrote: > Maybe it's not correct in general but the JSP 1.1 > syntax > contains the flush="true" attribute - obligatory in > case > of jsp:include. So, it's inconvenient but tomcat3 is > an > jsp 1.1 implementation. Am I missing something? incze The JSP 1.1

Re: TC3.2.1 - response commit on included JSPs

2001-02-20 Thread Craig R. McClanahan
Mel Martinez wrote: > Without getting stuck on the details of either of the > above issues, the real issue is that as it stands > above, if you do a dynamic include of a JSP page then > the response object is committed upon the return of > the method. I don't believe that is correct behavior. >