[tor-commits] [tor/master] fix minor grammar error in comment

commit 4e3ea6d5c8b81d195101d09478d362ab09da66fb Author: Roger Dingledine Date: Mon May 22 20:06:38 2017 -0400 fix minor grammar error in comment --- src/or/directory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/directory.c

[tor-commits] [tor-browser/tor-browser-52.1.0esr-7.0-2] fixup! TB4: Tor Browser's Firefox preference overrides.

commit 726b6d699e101570b14e3eb091ec94e9d5ee1946 Author: Georg Koppen Date: Mon May 22 12:52:09 2017 + fixup! TB4: Tor Browser's Firefox preference overrides. Adapt preferences to take new EME related ones into account. ---

[tor-commits] [tor-browser/tor-browser-52.1.0esr-7.0-2] Bug 16285: Exclude ClearKey system for now

commit 46d6d3a534c8f8c56194415c0839a4a90d17049b Author: Georg Koppen Date: Mon May 22 12:44:40 2017 + Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and

[tor-commits] [tor-browser/tor-browser-52.1.0esr-7.0-2] fixup! TB3: Tor Browser's official .mozconfigs.

commit 62546181d759aaf44216e6f32a79c89e55335c4e Author: Georg Koppen Date: Mon May 22 12:41:17 2017 + fixup! TB3: Tor Browser's official .mozconfigs. Make EME comment clearer for ESR52. --- .mozconfig | 2 +- .mozconfig-mac | 3 +--

[tor-commits] [tor-browser/tor-browser-52.1.1esr-7.0-1] fixup! TB4: Tor Browser's Firefox preference overrides.

commit ba7cbd186c5692267ba80eb6a998c7abab2a76a9 Author: Georg Koppen Date: Mon May 22 12:52:09 2017 + fixup! TB4: Tor Browser's Firefox preference overrides. Adapt preferences to take new EME related ones into account. ---

[tor-commits] [tor-browser/tor-browser-52.1.1esr-7.0-1] fixup! TB3: Tor Browser's official .mozconfigs.

commit 100fea0348ed02fd181080fbc2b131994adaab4b Author: Georg Koppen Date: Mon May 22 12:41:17 2017 + fixup! TB3: Tor Browser's official .mozconfigs. Make EME comment clearer for ESR52. --- .mozconfig | 2 +- .mozconfig-mac | 3 +--

[tor-commits] [tor-browser/tor-browser-52.1.1esr-7.0-1] Bug 16285: Exclude ClearKey system for now

commit e948ae5d404321a1ed0316ffb97baf45ee0163a5 Author: Georg Koppen Date: Mon May 22 12:44:40 2017 + Bug 16285: Exclude ClearKey system for now In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and

[tor-commits] [stem/master] Move remaining run_tests.py helpers

commit bb7975928a07893699b26528989d39bac941b82d Author: Damian Johnson Date: Sun May 21 18:57:00 2017 -0700 Move remaining run_tests.py helpers Most of the remaining helpers are solely used by run_tests.py. Might as well have them in there. I probably

[tor-commits] [stem/master] Replace test/util.py

commit 7ae6e853a9bfe8566b0e3d9d79e859854644f61d Merge: 157d9a8 2170254 Author: Damian Johnson Date: Sun May 21 19:32:37 2017 -0700 Replace test/util.py Everything is miscellaneous. Moving or replacing the utilities this module held. run_tests.py

[tor-commits] [stem/master] Drop get_protocolinfo_response() helper

commit 7087dad486dc5d3cfb2eb75da83750d61ce40ef6 Author: Damian Johnson Date: Sun May 21 18:27:04 2017 -0700 Drop get_protocolinfo_response() helper Replace the little usage of get_protocolinfo_response() we had. --- test/unit/connection/authentication.py |

[tor-commits] [stem/master] Moving test tasks to its own module

commit f52141e1e0becb4b3899b7da8d62f1591b1b2a36 Author: Damian Johnson Date: Thu May 18 11:38:09 2017 -0700 Moving test tasks to its own module Everything is miscellaneous. Our test.util module does two distinct things: startup tasks and testing

[tor-commits] [stem/master] Merge remaining test.util into base test module

commit 2170254997d5a3e44bc12898a0c3acb94f70f7c7 Author: Damian Johnson Date: Sun May 21 19:26:52 2017 -0700 Merge remaining test.util into base test module Now that we got this down to a small size we can merge what remains into test/__init__.py. ---

[tor-commits] [stem/master] Simplify requirement helpers

commit f72fa77b79afea50a2ca6deb8cad7b19c3f897fa Author: Damian Johnson Date: Fri May 12 17:47:05 2017 -0700 Simplify requirement helpers Decorators that don't need a constructor arg can be simplified. All we need is a helper to do the required check.

[tor-commits] [stem/master] Simplify startup tasks

commit 22cde36e3b912e8a4c2ae30d5ba170246212ee89 Author: Damian Johnson Date: Thu May 18 13:12:08 2017 -0700 Simplify startup tasks Moving more into our new task module and simplifying it. --- run_tests.py | 59 ++-- test/task.py | 144

[tor-commits] [stem/master] Drop get_prereq() helper

commit bf94336ecec090a27f47fe4754c8bf13bc8b023e Author: Damian Johnson Date: Sun May 21 18:41:54 2017 -0700 Drop get_prereq() helper Huh. Not sure why we even had this. Only caller is run_tests.py and it can do this just as well itself. ---

[tor-commits] [stem/master] Drop test runner's is_ptraceable() method

commit 1b7cb4ff2ba853ee5021d8d5eb137f5922a06431 Author: Damian Johnson Date: Fri May 12 17:34:02 2017 -0700 Drop test runner's is_ptraceable() method This method is effectively only used in one spot, and the caller can do this. ---

[tor-commits] [stem/master] Move test requirements to its own module

commit a29627184ea7d50dc4072dfc4115e68372c52d5f Author: Damian Johnson Date: Thu May 18 15:35:32 2017 -0700 Move test requirements to its own module Moving the @require_* annotations to its own dedicated module. Besides the obvious breakup of test.util

[tor-commits] [stem/master] Drop random_fingerprint() helper

commit dfeb747947f5974e7d0fac9e55671685bc84629d Author: Damian Johnson Date: Sun May 21 18:32:19 2017 -0700 Drop random_fingerprint() helper We don't actually need a random fingerprint. Just filling in a value. --- test/integ/control/base_controller.py | 3

[tor-commits] [stem/master] Add normalize argument to ControlMessage.from_str()

commit 144692cb801bd421b107db142e6e1e034961518e Author: Damian Johnson Date: Sun May 21 18:16:47 2017 -0700 Add normalize argument to ControlMessage.from_str() Our get_message() testing helper just did a little normalization. Adding this to

[tor-commits] [stem/master] Drop unused run_target from test runner

commit 08c290474d9f78c87016420458e2f4e517975c16 Author: Damian Johnson Date: Tue May 9 10:51:22 2017 -0700 Drop unused run_target from test runner Our Runner class provided a run_target attribute but nothing used it. This is because testing requirements

[tor-commits] [webwml/master] 0.3.1.1-alpha is tagged

commit ffea450359526e3d6ceb0912ba3f6f9ea84657a3 Author: Nick Mathewson Date: Mon May 22 14:23:58 2017 -0400 0.3.1.1-alpha is tagged --- Makefile | 2 +- include/versions.wmi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile

[tor-commits] [tor-browser-bundle/master] Bug 22324: Fix broken tab crash pages on higher security levels

commit 78de9734135f21077410d295b689751d60727592 Author: Georg Koppen Date: Mon May 22 09:30:33 2017 + Bug 22324: Fix broken tab crash pages on higher security levels We need to allow JavaScript on `about:tabcrashed` pages explicitly. Otherwise are

[tor-commits] [tor/master] pick a date

commit 615dbdb0e094d4ef0b1982d06e62a8058463a28a Author: Nick Mathewson Date: Mon May 22 12:03:45 2017 -0400 pick a date --- ChangeLog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index abc6db4..9617af9 100644 ---

[tor-commits] [tor/master] Merge remote-tracking branch 'ahf/bugs/22305'

commit d9b14713033e263a8ae008eb6fad580f959bcce3 Merge: 281f06a 9604980 Author: Nick Mathewson Date: Mon May 22 11:57:03 2017 -0400 Merge remote-tracking branch 'ahf/bugs/22305' src/or/directory.c | 13 + src/or/directory.h | 1 + 2 files changed, 14

[tor-commits] [tor/master] Log a warning if we receive a disallowed compression method for an anonymous connection.

commit 9604980733c30cabbdeee818e82ea647ace5b0c0 Author: Alexander Færøy Date: Mon May 22 15:52:41 2017 + Log a warning if we receive a disallowed compression method for an anonymous connection. See: https://bugs.torproject.org/22305 ---

[tor-commits] [tor/master] bump to 0.3.1.1-alpha

commit 281f06a094434269bf4d62041c5683c1265a436f Author: Nick Mathewson Date: Mon May 22 11:52:19 2017 -0400 bump to 0.3.1.1-alpha --- configure.ac| 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h| 2 +- 3

[tor-commits] [translation/tor-browser-manual_completed] Update translations for tor-browser-manual_completed

commit f6b88e04c5ae1c56d9275ddc35e66105ad4d21cf Author: Translation commit bot Date: Mon May 22 15:48:20 2017 + Update translations for tor-browser-manual_completed --- pt_BR/pt_BR.po | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[tor-commits] [translation/tor-browser-manual] Update translations for tor-browser-manual

commit 2168005f9fc8f038b9041e4180d158cf0be8eab7 Author: Translation commit bot Date: Mon May 22 15:48:16 2017 + Update translations for tor-browser-manual --- pt_BR/pt_BR.po | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[tor-commits] [translation/torbutton-torbuttonproperties] Update translations for torbutton-torbuttonproperties

commit 3d9ad4f28f8df252bc7863f79aa55569fd306c98 Author: Translation commit bot Date: Mon May 22 15:46:32 2017 + Update translations for torbutton-torbuttonproperties --- pt_BR/torbutton.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[tor-commits] [tor/master] Fold new entries into changelog

commit 94754c54145f62f6106f9c05563f3ba1f995ad84 Author: Nick Mathewson Date: Mon May 22 11:40:52 2017 -0400 Fold new entries into changelog --- ChangeLog| 9 + changes/bug20509 | 5 - changes/bug21969 | 3 --- 3 files changed, 9 insertions(+), 8

[tor-commits] [tor/master] Run format_changelog again

commit 363538e345df5654c5056c7eb167471898aedc4c Author: Nick Mathewson Date: Mon May 22 11:41:25 2017 -0400 Run format_changelog again --- ChangeLog | 58 +- 1 file changed, 29 insertions(+), 29 deletions(-)

[tor-commits] [tor/master] Merge remote-tracking branch 'ahf/bugs/22305'

commit 9a50c731040fea3b85b0c84726d56194993f09e9 Merge: cfe0a45 5a0eab6 Author: Nick Mathewson Date: Mon May 22 10:57:26 2017 -0400 Merge remote-tracking branch 'ahf/bugs/22305' src/or/directory.c | 87 --

[tor-commits] [tor/master] Refactor error path handling in connection_dir_client_reached_eof().

commit 2b26ac139086c4ce3067b6d27644cb37808a9eb0 Author: Alexander Færøy Date: Mon May 22 14:42:18 2017 + Refactor error path handling in connection_dir_client_reached_eof(). This patch lifts the return value, rv, variable to the beginning of the

[tor-commits] [tor/master] Ensure that only GZip and Zlib compression is handled for anonymous connections.

commit 5a0eab68e1ca2c1f76ac3834b1e38938a5cb4546 Author: Alexander Færøy Date: Mon May 22 14:45:12 2017 + Ensure that only GZip and Zlib compression is handled for anonymous connections. See: https://bugs.torproject.org/22305 --- src/or/directory.c | 53

[tor-commits] [tor/master] Don't add "Accept-Encoding" header if directory connection is anonymous.

commit 26795da900d7b487b80e19b804475ad7b132188d Author: Alexander Færøy Date: Mon May 22 12:34:57 2017 + Don't add "Accept-Encoding" header if directory connection is anonymous. See: https://bugs.torproject.org/22305 --- src/or/directory.c | 13

[tor-commits] [tor/master] Fix a compilation warning about duplicate typedef

commit cfe0a45750341c33f6f523f7eec734a7b551ad25 Author: Nick Mathewson Date: Mon May 22 10:39:43 2017 -0400 Fix a compilation warning about duplicate typedef --- src/or/directory.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[tor-commits] [atlas/master] Reverts not recommended icon to red (from black)

commit cec47db1f15825ffb64c22995b4ea2750927fb23 Author: Iain R. Learmonth Date: Mon May 22 15:20:41 2017 +0100 Reverts not recommended icon to red (from black) Closes: #22293 --- img/properties/not_recommended_16x16.png | Bin 260 -> 323 bytes 1 file changed, 0

[tor-commits] [atlas/master] Ignore git mergetool backup files

commit 46fb73bf4d3b3e654c71ba8dd195d53a05e2fe5c Author: cypherpunks Date: Sat May 20 17:16:16 2017 + Ignore git mergetool backup files Closes #22314. --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore new

[tor-commits] [atlas/master] Improves the "Not recommended" tooltip text

commit abd945a809090e248e5690c901ff80aadef158c2 Author: Iain R. Learmonth Date: Fri May 19 00:22:20 2017 +0100 Improves the "Not recommended" tooltip text * This renames the "Not recommended" property to "Outdated Tor Version" * The description is amended to

[tor-commits] [atlas/master] Adds Vim swap files to the .gitignore

commit 3a72c09363bd6f2ebe3f7669c97444c211cd4d3d Author: Iain R. Learmonth Date: Mon May 22 14:52:35 2017 +0100 Adds Vim swap files to the .gitignore --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 66685a5..ebb65bf 100644

[tor-commits] [tor/master] amend changes file to note that one case is still unfixed

commit 3d27954f2e932cf1965fabd2672a52f0ea13d940 Author: Nick Mathewson Date: Mon May 22 09:10:00 2017 -0400 amend changes file to note that one case is still unfixed --- changes/bug21969 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[tor-commits] [tor/master] Merge remote-tracking branch 'asn/bug21969_bridges'

commit b2e9a107b7a69f29f88d9c5f67fea3cee3082cf0 Merge: 90894c8 52498b8 Author: Nick Mathewson Date: Mon May 22 09:09:16 2017 -0400 Merge remote-tracking branch 'asn/bug21969_bridges' changes/bug21969| 3 +++ src/or/bridges.c| 6 ++ src/or/directory.c

[tor-commits] [tor/master] Raise common code for creating circuit_guard_state_t

commit e5a929fef8df61b41b0f2e4a12bbcbe8d931a5cf Author: Nick Mathewson Date: Mon May 22 09:13:18 2017 -0400 Raise common code for creating circuit_guard_state_t This will help if we ever need to add more fields or change the semantics of existing fields.

[tor-commits] [tor/master] Set guard state on bridge descriptor fetches.

commit 52498b8183a2ab1da525180ee76f704d8257ebc6 Author: George Kadianakis Date: Mon May 22 14:10:38 2017 +0300 Set guard state on bridge descriptor fetches. We used to not set the guard state in launch_direct_bridge_descriptor_fetch(). So when a bridge

[tor-commits] [tor/release-0.2.9] Merge branch 'maint-0.2.9' into release-0.2.9

commit 54bfbc08ce2d756c3f40549dd9e7ae4222e34c20 Merge: 480aa72 6e5486b Author: Nick Mathewson Date: Mon May 22 08:31:46 2017 -0400 Merge branch 'maint-0.2.9' into release-0.2.9 changes/bug20509 | 5 + src/or/dirserv.c | 11 +++ 2 files changed, 16

[tor-commits] [tor/release-0.3.0] Merge branch 'maint-0.3.0' into release-0.3.0

commit 94b51283954e5bc8d68c8a4bc7e6c168eb82e008 Merge: 647fa4b 5c52d3c Author: Nick Mathewson Date: Mon May 22 08:32:13 2017 -0400 Merge branch 'maint-0.3.0' into release-0.3.0 changes/bug20509 | 5 + src/or/dirserv.c | 11 +++ 2 files changed, 16

[tor-commits] [tor/release-0.3.0] Merge branch 'maint-0.2.9' into maint-0.3.0

commit 5c52d3c2c05a42c9535789d335a51f09a7855d68 Merge: d1340bd 6e5486b Author: Nick Mathewson Date: Mon May 22 08:32:07 2017 -0400 Merge branch 'maint-0.2.9' into maint-0.3.0 changes/bug20509 | 5 + src/or/dirserv.c | 11 +++ 2 files changed, 16

[tor-commits] [tor/master] Merge branch 'maint-0.3.0'

commit 90894c87a542c8671b4fb13d8e088e1e5c89d9b6 Merge: 0698a0b 5c52d3c Author: Nick Mathewson Date: Mon May 22 08:32:18 2017 -0400 Merge branch 'maint-0.3.0' changes/bug20509 | 5 + src/or/dirserv.c | 11 +++ 2 files changed, 16 insertions(+)

[tor-commits] [tor/release-0.3.0] dir auths reject 0.2.9.x for x<5, due to bug 20499

commit 6e5486b11ac113ab7cf42d167ddb5916ddbc Author: Roger Dingledine Date: Sun May 21 02:05:32 2017 -0400 dir auths reject 0.2.9.x for x<5, due to bug 20499 Directory authorities now reject relays running versions 0.2.9.1-alpha through 0.2.9.4-alpha,

[tor-commits] [tor/master] Merge branch 'maint-0.2.9' into maint-0.3.0

commit 5c52d3c2c05a42c9535789d335a51f09a7855d68 Merge: d1340bd 6e5486b Author: Nick Mathewson Date: Mon May 22 08:32:07 2017 -0400 Merge branch 'maint-0.2.9' into maint-0.3.0 changes/bug20509 | 5 + src/or/dirserv.c | 11 +++ 2 files changed, 16

[tor-commits] [tor/maint-0.2.9] dir auths reject 0.2.9.x for x<5, due to bug 20499

commit 6e5486b11ac113ab7cf42d167ddb5916ddbc Author: Roger Dingledine Date: Sun May 21 02:05:32 2017 -0400 dir auths reject 0.2.9.x for x<5, due to bug 20499 Directory authorities now reject relays running versions 0.2.9.1-alpha through 0.2.9.4-alpha,

[tor-commits] [tor/maint-0.3.0] Merge branch 'maint-0.2.9' into maint-0.3.0

commit 5c52d3c2c05a42c9535789d335a51f09a7855d68 Merge: d1340bd 6e5486b Author: Nick Mathewson Date: Mon May 22 08:32:07 2017 -0400 Merge branch 'maint-0.2.9' into maint-0.3.0 changes/bug20509 | 5 + src/or/dirserv.c | 11 +++ 2 files changed, 16

[tor-commits] [tor/release-0.2.9] dir auths reject 0.2.9.x for x<5, due to bug 20499

commit 6e5486b11ac113ab7cf42d167ddb5916ddbc Author: Roger Dingledine Date: Sun May 21 02:05:32 2017 -0400 dir auths reject 0.2.9.x for x<5, due to bug 20499 Directory authorities now reject relays running versions 0.2.9.1-alpha through 0.2.9.4-alpha,

[tor-commits] [tor/master] dir auths reject 0.2.9.x for x<5, due to bug 20499

commit 6e5486b11ac113ab7cf42d167ddb5916ddbc Author: Roger Dingledine Date: Sun May 21 02:05:32 2017 -0400 dir auths reject 0.2.9.x for x<5, due to bug 20499 Directory authorities now reject relays running versions 0.2.9.1-alpha through 0.2.9.4-alpha,

[tor-commits] [tor/maint-0.3.0] dir auths reject 0.2.9.x for x<5, due to bug 20499

commit 6e5486b11ac113ab7cf42d167ddb5916ddbc Author: Roger Dingledine Date: Sun May 21 02:05:32 2017 -0400 dir auths reject 0.2.9.x for x<5, due to bug 20499 Directory authorities now reject relays running versions 0.2.9.1-alpha through 0.2.9.4-alpha,

[tor-commits] [torspec/master] Add some handshake terminology to glossary

commit 6049c9517c17d8aa5ad7a0ba53778637388816b6 Author: Taylor Yu Date: Thu May 18 12:25:56 2017 -0400 Add some handshake terminology to glossary --- glossary.txt | 44 1 file changed, 40 insertions(+), 4 deletions(-)

[tor-commits] [torspec/master] Merge remote-tracking branch 'argonblue/glossary'

commit 1d4e05b9626e4554606b90e83301a71d199c1295 Merge: c71d8c9 6049c95 Author: Nick Mathewson Date: Mon May 22 08:39:38 2017 -0400 Merge remote-tracking branch 'argonblue/glossary' glossary.txt | 44 1 file changed, 40

[tor-commits] [sandboxed-tor-browser/master] Bump the version to 0.0.8-dev, so I can do development again.

commit 3ebd74a7b1cf05e07cb518078998789f753bb5c1 Author: Yawning Angel Date: Mon May 22 10:09:28 2017 + Bump the version to 0.0.8-dev, so I can do development again. --- ChangeLog| 2 ++ data/version | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)

[tor-commits] [sandboxed-tor-browser/master] Do the release ritual for sandboxed-tor-browser-0.0.7.

commit e8d953fca8088816e6fe8afbe4b57845dfaeecaa Author: Yawning Angel Date: Mon May 22 10:06:53 2017 + Do the release ritual for sandboxed-tor-browser-0.0.7. --- ChangeLog| 2 +- data/version | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[tor-commits] [sandboxed-tor-browser/master] Add a note in the README about the MIT-SHM bug. No functional changes.

commit 7d55a23cafe770471becd7b2ebded005ae04e9d1 Author: Yawning Angel Date: Mon May 22 10:05:11 2017 + Add a note in the README about the MIT-SHM bug. No functional changes. --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md

[tor-commits] [tor-browser/tor-browser-52.1.1esr-7.0-1] fixup! TB4: Tor Browser's Firefox preference overrides.

commit 886808dc4e21eef3595fa1042f792927bb898193 Author: Georg Koppen Date: Mon May 22 08:36:35 2017 + fixup! TB4: Tor Browser's Firefox preference overrides. The Battery API is not available to content anymore since Firefox 52. Thus, we don't need to

[tor-commits] [tor-browser/tor-browser-52.1.0esr-7.0-2] fixup! TB4: Tor Browser's Firefox preference overrides.

commit 885479878d591ce61fa573912eae4ea062dc54c6 Author: Georg Koppen Date: Mon May 22 08:36:35 2017 + fixup! TB4: Tor Browser's Firefox preference overrides. The Battery API is not available to content anymore since Firefox 52. Thus, we don't need to

[tor-commits] [tor-browser/tor-browser-52.1.0esr-7.0-2] fixup! Bug 19273: Avoid JavaScript patching of the external app helper dialog.

commit 1d1fdea85218586354a1294cb94026279e74a0e3 Author: Kathy Brade Date: Fri May 19 11:25:31 2017 -0400 fixup! Bug 19273: Avoid JavaScript patching of the external app helper dialog. For e10s compatibility, send the "external-app-requested" observer

[tor-commits] [tor-browser/tor-browser-52.1.1esr-7.0-1] fixup! Bug 19273: Avoid JavaScript patching of the external app helper dialog.

commit 4a4285cbd06a825e5f2277d12a2e5165eab59837 Author: Kathy Brade Date: Fri May 19 11:25:31 2017 -0400 fixup! Bug 19273: Avoid JavaScript patching of the external app helper dialog. For e10s compatibility, send the "external-app-requested" observer