[tor-commits] [translation/tails-perl5lib_completed] Update translations for tails-perl5lib_completed

2018-04-03 Thread translation
commit d9acf97794f66558063704912730366f611dc207 Author: Translation commit bot Date: Wed Apr 4 05:17:54 2018 + Update translations for tails-perl5lib_completed --- id.po | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/id.po

[tor-commits] [translation/tails-perl5lib] Update translations for tails-perl5lib

2018-04-03 Thread translation
commit dedd4e18351503d9e5cbb10af423d20ff9d6d5dc Author: Translation commit bot Date: Wed Apr 4 05:17:49 2018 + Update translations for tails-perl5lib --- id.po | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/id.po b/id.po index

[tor-commits] [translation/https_everywhere] Update translations for https_everywhere

2018-04-03 Thread translation
commit d0b9652f2e33ad38c7da24e3d2bd8ce51e7235d5 Author: Translation commit bot Date: Wed Apr 4 05:15:35 2018 + Update translations for https_everywhere --- id/https-everywhere.dtd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[tor-commits] [translation/https_everywhere_completed] Update translations for https_everywhere_completed

2018-04-03 Thread translation
commit d860f12989244a64a05e4460b86e9faf22a14029 Author: Translation commit bot Date: Wed Apr 4 05:15:46 2018 + Update translations for https_everywhere_completed --- id/https-everywhere.dtd | 2 ++ 1 file changed, 2 insertions(+) diff --git

[tor-commits] [translation/https_everywhere_completed] Update translations for https_everywhere_completed

2018-04-03 Thread translation
commit a21bdd102b807c685243ed378d25d6b9d9aa1a2a Author: Translation commit bot Date: Wed Apr 4 02:16:54 2018 + Update translations for https_everywhere_completed --- templates/https-everywhere.dtd | 2 ++ 1 file changed, 2 insertions(+) diff --git

[tor-commits] [torspec/master] specify that Guard needs the V2Dir flag too

2018-04-03 Thread arma
commit a442ab92e84a044ffe90cad37cd517e0f98e1bea Author: Roger Dingledine Date: Mon Apr 2 00:32:56 2018 -0400 specify that Guard needs the V2Dir flag too part of the change made by ticket 22310, where dir auths no longer vote in favor of the Guard flag for

[tor-commits] [torspec/master] Merge remote-tracking branch 'teor/bug25284'

2018-04-03 Thread nickm
commit 486455bbed02276c0dd5b228f06b15b90b521d47 Merge: 815a710 43c2f78 Author: Nick Mathewson Date: Tue Apr 3 19:17:06 2018 -0400 Merge remote-tracking branch 'teor/bug25284' dir-spec.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[tor-commits] [torspec/master] Tor has never supported versions in the hidden-service-dir descriptor line

2018-04-03 Thread nickm
commit 43c2f78f0238e2cccd9f58d630f6f441f4504feb Author: teor Date: Fri Mar 30 07:16:59 2018 +1100 Tor has never supported versions in the hidden-service-dir descriptor line Instead, we use the HSDir "proto" versions, or default to version 2. Closes

[tor-commits] [tor/release-0.3.3] Merge branch 'maint-0.3.3' into release-0.3.3

2018-04-03 Thread nickm
commit 753840a8a7c946dbf2188cb4f8b03b8ff7cfbe61 Merge: 5bdc18b2d 7ccb1c5a8 Author: Nick Mathewson Date: Tue Apr 3 19:03:38 2018 -0400 Merge branch 'maint-0.3.3' into release-0.3.3 changes/bug24031| 13 + src/or/protover.c |

[tor-commits] [tor/release-0.3.3] add a missing word

2018-04-03 Thread nickm
commit 7ccb1c5a859873656ab074c88935865bcf4b4c38 Author: Nick Mathewson Date: Tue Apr 3 15:31:30 2018 -0400 add a missing word --- changes/bug24031 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changes/bug24031 b/changes/bug24031 index

[tor-commits] [tor/release-0.3.3] rust: Fix ProtoSet and ProtoEntry to use the same DoS limits as C.

2018-04-03 Thread nickm
commit c65088cb1943748412e1a390de655e20bdb28692 Author: Isis Lovecruft Date: Tue Mar 27 22:46:14 2018 + rust: Fix ProtoSet and ProtoEntry to use the same DoS limits as C. Previously, the limit for MAX_PROTOCOLS_TO_EXPAND was actually being applied in

[tor-commits] [tor/release-0.3.3] rust: Port all C protover_all_supported tests to Rust.

2018-04-03 Thread nickm
commit 4b4e36a413bb5d0e2ea499dd6bc34b3d24bd3375 Author: Isis Lovecruft Date: Tue Mar 27 21:38:29 2018 + rust: Port all C protover_all_supported tests to Rust. The behaviours still do not match, unsurprisingly, but now we know where a primary difference

[tor-commits] [tor/release-0.3.3] rust: Refactor Rust implementation of protover_is_supported_here().

2018-04-03 Thread nickm
commit fd127bfbfa13d407e5fb5d22a567f51a30af4c2e Author: Isis Lovecruft Date: Wed Mar 21 03:08:35 2018 + rust: Refactor Rust implementation of protover_is_supported_here(). It was changed to take borrows instead of taking ownership. * REFACTOR

[tor-commits] [tor/release-0.3.3] rust: Refactor Rust impl of protover_list_supports_protocol().

2018-04-03 Thread nickm
commit 63eeda89ea11bf719ec6fddc7619994cc7f654ca Author: Isis Lovecruft Date: Wed Mar 21 02:52:04 2018 + rust: Refactor Rust impl of protover_list_supports_protocol(). This includes a subtle difference in behaviour, as in 4258f1e18, where we return

[tor-commits] [tor/release-0.3.3] rust: Refactor protover tests with new methods; note altered behaviours.

2018-04-03 Thread nickm
commit 493e565226fb6e5c985f787333bb0c89d661 Author: Isis Lovecruft Date: Wed Mar 21 02:13:40 2018 + rust: Refactor protover tests with new methods; note altered behaviours. Previously, the rust implementation of protover considered an empty string to

[tor-commits] [tor/release-0.3.3] protover: Change protover_all_supported() to return only unsupported.

2018-04-03 Thread nickm
commit ad369313f87cba286a4f3347553e7322608dbd9c Author: Isis Lovecruft Date: Tue Mar 27 16:59:49 2018 + protover: Change protover_all_supported() to return only unsupported. Previously, if "Link=1-5" was supported, and you asked protover_all_supported()

[tor-commits] [tor/release-0.3.3] Merge remote-tracking branch 'isis-github/bug24031_r5_squashed_033' into maint-0.3.3

2018-04-03 Thread nickm
commit 8d6b1da2e6729c0cf8331e663bdfeee5d5660237 Merge: 961d2ad59 b503df277 Author: Nick Mathewson Date: Tue Apr 3 15:29:29 2018 -0400 Merge remote-tracking branch 'isis-github/bug24031_r5_squashed_033' into maint-0.3.3 changes/bug24031| 13 +

[tor-commits] [tor/release-0.3.3] rust: Add new ProtoverVote type and refactor functions to methods.

2018-04-03 Thread nickm
commit 2eb1b7f2fd05eb0302e41b55f5cb61959cc9528e Author: Isis Lovecruft Date: Wed Mar 21 01:52:41 2018 + rust: Add new ProtoverVote type and refactor functions to methods. This adds a new type for votes upon `protover::ProtoEntry`s (technically, on

[tor-commits] [tor/release-0.3.3] rust: Implement error types for Rust protover implementation.

2018-04-03 Thread nickm
commit 88204f91df3e01b69e79b89ba029b42a4025d11f Author: Isis Lovecruft Date: Wed Mar 21 00:24:46 2018 + rust: Implement error types for Rust protover implementation. This will allow us to do actual error handling intra-crate in a more rusty manner,

[tor-commits] [tor/master] tests: Run all existing protover tests in both languages.

2018-04-03 Thread nickm
commit 6739a69c590a12af0f1cb2af62972f4305803670 Author: Isis Lovecruft Date: Tue Mar 27 21:36:10 2018 + tests: Run all existing protover tests in both languages. There's now no difference in these tests w.r.t. the C or Rust: both fail miserably (well,

[tor-commits] [tor/release-0.3.3] tests: Make inline comments in test_protover.c more accurate.

2018-04-03 Thread nickm
commit f769edd148bfbb381a48217e9016902f036b9ed8 Author: Isis Lovecruft Date: Tue Mar 27 21:34:00 2018 + tests: Make inline comments in test_protover.c more accurate. The DoS potential is slightly higher in C now due to some differences to the Rust

[tor-commits] [tor/release-0.3.3] rust: Add new protover::ProtoEntry type which uses new datatypes.

2018-04-03 Thread nickm
commit 54c964332b27104e56442128f8ce85110af89c96 Author: Isis Lovecruft Date: Wed Mar 21 01:18:02 2018 + rust: Add new protover::ProtoEntry type which uses new datatypes. This replaces the `protover::SupportedProtocols` (why would you have a type just

[tor-commits] [tor/release-0.3.3] tests: Run all existing protover tests in both languages.

2018-04-03 Thread nickm
commit 6739a69c590a12af0f1cb2af62972f4305803670 Author: Isis Lovecruft Date: Tue Mar 27 21:36:10 2018 + tests: Run all existing protover tests in both languages. There's now no difference in these tests w.r.t. the C or Rust: both fail miserably (well,

[tor-commits] [tor/release-0.3.3] rust: Refactor Rust impl of protover_all_supported().

2018-04-03 Thread nickm
commit c7bcca0233d1d4c9805f78da5e7186be2c1bcdca Author: Isis Lovecruft Date: Wed Mar 21 02:45:41 2018 + rust: Refactor Rust impl of protover_all_supported(). This includes differences in behaviour to before, which should now more closely match the C

[tor-commits] [tor/release-0.3.3] rust: Refactor protover::compute_for_old_tor().

2018-04-03 Thread nickm
commit cd28b4c7f5cefd319d6ded635d25911b4323b50b Author: Isis Lovecruft Date: Tue Mar 27 02:41:25 2018 + rust: Refactor protover::compute_for_old_tor(). During code review and discussion with Chelsea Komlo, she pointed out that

[tor-commits] [tor/master] rust: Refactor Rust implementation of protover_is_supported_here().

2018-04-03 Thread nickm
commit fd127bfbfa13d407e5fb5d22a567f51a30af4c2e Author: Isis Lovecruft Date: Wed Mar 21 03:08:35 2018 + rust: Refactor Rust implementation of protover_is_supported_here(). It was changed to take borrows instead of taking ownership. * REFACTOR

[tor-commits] [tor/master] changes: Add changes file for #24031.

2018-04-03 Thread nickm
commit b503df2775d22cff0b74740357121ba5195e4a12 Author: Isis Lovecruft Date: Tue Apr 3 19:19:40 2018 + changes: Add changes file for #24031. (cherry picked from commit 5a8cdec3f8617920f19e3ab7707233ad3f02424f) --- changes/bug24031 | 13 + 1

[tor-commits] [tor/release-0.3.3] changes: Add changes file for #24031.

2018-04-03 Thread nickm
commit b503df2775d22cff0b74740357121ba5195e4a12 Author: Isis Lovecruft Date: Tue Apr 3 19:19:40 2018 + changes: Add changes file for #24031. (cherry picked from commit 5a8cdec3f8617920f19e3ab7707233ad3f02424f) --- changes/bug24031 | 13 + 1

[tor-commits] [tor/master] Fix bug24031 changes file

2018-04-03 Thread nickm
commit 21c81348a39dd235c40656c34abb76daf88e81f3 Author: Nick Mathewson Date: Tue Apr 3 19:03:33 2018 -0400 Fix bug24031 changes file --- changes/bug24031 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changes/bug24031 b/changes/bug24031 index

[tor-commits] [tor/release-0.3.3] rust: Refactor Rust impl of protover_list_supports_protocol_or_later().

2018-04-03 Thread nickm
commit 269053a3801ebe925707db5a8e519836ad2242c9 Author: Isis Lovecruft Date: Wed Mar 21 02:59:25 2018 + rust: Refactor Rust impl of protover_list_supports_protocol_or_later(). This includes a subtle difference in behaviour, as in 4258f1e18, where we

[tor-commits] [tor/release-0.3.3] rust: Add new protover::UnvalidatedProtoEntry type.

2018-04-03 Thread nickm
commit 3c47d31e1f29a016e2f0f21ca8445430ed7aad0a Author: Isis Lovecruft Date: Wed Mar 21 01:29:36 2018 + rust: Add new protover::UnvalidatedProtoEntry type. This adds a new protover::UnvalidatedProtoEntry type, which is the UnknownProtocol variant of a

[tor-commits] [tor/release-0.3.3] rust: Refactor Rust impl of protover_compute_vote().

2018-04-03 Thread nickm
commit 32638ed4a6c47a03b899cd09582888674ae3bf08 Author: Isis Lovecruft Date: Wed Mar 21 03:05:56 2018 + rust: Refactor Rust impl of protover_compute_vote(). This includes a subtle difference in behaviour to the previous Rust implementation, where, for

[tor-commits] [tor/master] add a missing word

2018-04-03 Thread nickm
commit 7ccb1c5a859873656ab074c88935865bcf4b4c38 Author: Nick Mathewson Date: Tue Apr 3 15:31:30 2018 -0400 add a missing word --- changes/bug24031 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changes/bug24031 b/changes/bug24031 index

[tor-commits] [tor/master] rust: Refactor protover::compute_for_old_tor().

2018-04-03 Thread nickm
commit cd28b4c7f5cefd319d6ded635d25911b4323b50b Author: Isis Lovecruft Date: Tue Mar 27 02:41:25 2018 + rust: Refactor protover::compute_for_old_tor(). During code review and discussion with Chelsea Komlo, she pointed out that

[tor-commits] [tor/release-0.3.3] rust: Add macro for `impl ToString for {Unvalidated}ProtoEntry`.

2018-04-03 Thread nickm
commit fa15ea104d5b9f05192afa3a023d0e2405c3842a Author: Isis Lovecruft Date: Wed Mar 21 01:44:59 2018 + rust: Add macro for `impl ToString for {Unvalidated}ProtoEntry`. This implements conversions from either a ProtoEntry or an UnvalidatedProtoEntry

[tor-commits] [tor/release-0.3.3] rust: Refactor protover::is_supported_here().

2018-04-03 Thread nickm
commit 35b86a12e60a8696b512261e96dc6f1c75ecebfc Author: Isis Lovecruft Date: Wed Mar 21 02:09:04 2018 + rust: Refactor protover::is_supported_here(). This changes `protover::is_supported_here()` to be aware of new datatypes (e.g. don't call `.0` on

[tor-commits] [tor/release-0.3.3] rust: Implement more memory-efficient protover datatype.

2018-04-03 Thread nickm
commit e6625113c98c281b0a649598d7daa347c28915e9 Author: Isis Lovecruft Date: Wed Mar 21 00:43:55 2018 + rust: Implement more memory-efficient protover datatype. * ADD new protover::protoset module. * ADD new protover::protoset::ProtoSet class for

[tor-commits] [tor/master] rust: Port all C protover_all_supported tests to Rust.

2018-04-03 Thread nickm
commit 4b4e36a413bb5d0e2ea499dd6bc34b3d24bd3375 Author: Isis Lovecruft Date: Tue Mar 27 21:38:29 2018 + rust: Port all C protover_all_supported tests to Rust. The behaviours still do not match, unsurprisingly, but now we know where a primary difference

[tor-commits] [tor/master] changes: Add changes file for #24031.

2018-04-03 Thread nickm
commit 5a8cdec3f8617920f19e3ab7707233ad3f02424f Author: Isis Lovecruft Date: Tue Apr 3 19:19:40 2018 + changes: Add changes file for #24031. --- changes/bug24031 | 13 + 1 file changed, 13 insertions(+) diff --git a/changes/bug24031 b/changes/bug24031

[tor-commits] [tor/master] rust: Fix ProtoSet and ProtoEntry to use the same DoS limits as C.

2018-04-03 Thread nickm
commit c65088cb1943748412e1a390de655e20bdb28692 Author: Isis Lovecruft Date: Tue Mar 27 22:46:14 2018 + rust: Fix ProtoSet and ProtoEntry to use the same DoS limits as C. Previously, the limit for MAX_PROTOCOLS_TO_EXPAND was actually being applied in

[tor-commits] [tor/master] Merge branch 'maint-0.3.3'

2018-04-03 Thread nickm
commit c2c616eb1958e32995577bdaa5f2c9507fd09c22 Merge: 3df954549 7ccb1c5a8 Author: Nick Mathewson Date: Tue Apr 3 15:33:29 2018 -0400 Merge branch 'maint-0.3.3' ___ tor-commits mailing list

[tor-commits] [tor/release-0.3.3] rust: Add new protover::UnknownProtocol type.

2018-04-03 Thread nickm
commit 60daaa68b153cdca6d48b09f1951d6ba580609e5 Author: Isis Lovecruft Date: Wed Mar 21 01:07:18 2018 + rust: Add new protover::UnknownProtocol type. * ADD new type, protover::UnknownProtocol, so that we have greater type safety and our protover

[tor-commits] [tor/master] tests: Make inline comments in test_protover.c more accurate.

2018-04-03 Thread nickm
commit f769edd148bfbb381a48217e9016902f036b9ed8 Author: Isis Lovecruft Date: Tue Mar 27 21:34:00 2018 + tests: Make inline comments in test_protover.c more accurate. The DoS potential is slightly higher in C now due to some differences to the Rust

[tor-commits] [tor/master] Merge remote-tracking branch 'isis-github/bug24031_r5_squashed'

2018-04-03 Thread nickm
commit 29b3b485b9722ceead4b931af521b999d3c2aeb3 Merge: c2c616eb1 5a8cdec3f Author: Nick Mathewson Date: Tue Apr 3 15:33:50 2018 -0400 Merge remote-tracking branch 'isis-github/bug24031_r5_squashed' changes/bug24031| 13 + src/or/protover.c

[tor-commits] [tor/master] rust: Add new ProtoverVote type and refactor functions to methods.

2018-04-03 Thread nickm
commit 2eb1b7f2fd05eb0302e41b55f5cb61959cc9528e Author: Isis Lovecruft Date: Wed Mar 21 01:52:41 2018 + rust: Add new ProtoverVote type and refactor functions to methods. This adds a new type for votes upon `protover::ProtoEntry`s (technically, on

[tor-commits] [tor/master] protover: Change protover_all_supported() to return only unsupported.

2018-04-03 Thread nickm
commit ad369313f87cba286a4f3347553e7322608dbd9c Author: Isis Lovecruft Date: Tue Mar 27 16:59:49 2018 + protover: Change protover_all_supported() to return only unsupported. Previously, if "Link=1-5" was supported, and you asked protover_all_supported()

[tor-commits] [tor/master] Merge remote-tracking branch 'isis-github/bug24031_r5_squashed_033' into maint-0.3.3

2018-04-03 Thread nickm
commit 8d6b1da2e6729c0cf8331e663bdfeee5d5660237 Merge: 961d2ad59 b503df277 Author: Nick Mathewson Date: Tue Apr 3 15:29:29 2018 -0400 Merge remote-tracking branch 'isis-github/bug24031_r5_squashed_033' into maint-0.3.3 changes/bug24031| 13 +

[tor-commits] [tor/master] rust: Add new protover::UnknownProtocol type.

2018-04-03 Thread nickm
commit 60daaa68b153cdca6d48b09f1951d6ba580609e5 Author: Isis Lovecruft Date: Wed Mar 21 01:07:18 2018 + rust: Add new protover::UnknownProtocol type. * ADD new type, protover::UnknownProtocol, so that we have greater type safety and our protover

[tor-commits] [tor/master] rust: Refactor Rust impl of protover_all_supported().

2018-04-03 Thread nickm
commit c7bcca0233d1d4c9805f78da5e7186be2c1bcdca Author: Isis Lovecruft Date: Wed Mar 21 02:45:41 2018 + rust: Refactor Rust impl of protover_all_supported(). This includes differences in behaviour to before, which should now more closely match the C

[tor-commits] [tor/master] rust: Refactor protover::is_supported_here().

2018-04-03 Thread nickm
commit 35b86a12e60a8696b512261e96dc6f1c75ecebfc Author: Isis Lovecruft Date: Wed Mar 21 02:09:04 2018 + rust: Refactor protover::is_supported_here(). This changes `protover::is_supported_here()` to be aware of new datatypes (e.g. don't call `.0` on

[tor-commits] [tor/master] rust: Refactor Rust impl of protover_list_supports_protocol().

2018-04-03 Thread nickm
commit 63eeda89ea11bf719ec6fddc7619994cc7f654ca Author: Isis Lovecruft Date: Wed Mar 21 02:52:04 2018 + rust: Refactor Rust impl of protover_list_supports_protocol(). This includes a subtle difference in behaviour, as in 4258f1e18, where we return

[tor-commits] [tor/master] rust: Refactor Rust impl of protover_compute_vote().

2018-04-03 Thread nickm
commit 32638ed4a6c47a03b899cd09582888674ae3bf08 Author: Isis Lovecruft Date: Wed Mar 21 03:05:56 2018 + rust: Refactor Rust impl of protover_compute_vote(). This includes a subtle difference in behaviour to the previous Rust implementation, where, for

[tor-commits] [tor/master] rust: Refactor Rust impl of protover_list_supports_protocol_or_later().

2018-04-03 Thread nickm
commit 269053a3801ebe925707db5a8e519836ad2242c9 Author: Isis Lovecruft Date: Wed Mar 21 02:59:25 2018 + rust: Refactor Rust impl of protover_list_supports_protocol_or_later(). This includes a subtle difference in behaviour, as in 4258f1e18, where we

[tor-commits] [tor/master] rust: Add new protover::ProtoEntry type which uses new datatypes.

2018-04-03 Thread nickm
commit 54c964332b27104e56442128f8ce85110af89c96 Author: Isis Lovecruft Date: Wed Mar 21 01:18:02 2018 + rust: Add new protover::ProtoEntry type which uses new datatypes. This replaces the `protover::SupportedProtocols` (why would you have a type just

[tor-commits] [tor/master] rust: Add new protover::UnvalidatedProtoEntry type.

2018-04-03 Thread nickm
commit 3c47d31e1f29a016e2f0f21ca8445430ed7aad0a Author: Isis Lovecruft Date: Wed Mar 21 01:29:36 2018 + rust: Add new protover::UnvalidatedProtoEntry type. This adds a new protover::UnvalidatedProtoEntry type, which is the UnknownProtocol variant of a

[tor-commits] [tor/master] rust: Add macro for `impl ToString for {Unvalidated}ProtoEntry`.

2018-04-03 Thread nickm
commit fa15ea104d5b9f05192afa3a023d0e2405c3842a Author: Isis Lovecruft Date: Wed Mar 21 01:44:59 2018 + rust: Add macro for `impl ToString for {Unvalidated}ProtoEntry`. This implements conversions from either a ProtoEntry or an UnvalidatedProtoEntry

[tor-commits] [tor/master] rust: Refactor protover tests with new methods; note altered behaviours.

2018-04-03 Thread nickm
commit 493e565226fb6e5c985f787333bb0c89d661 Author: Isis Lovecruft Date: Wed Mar 21 02:13:40 2018 + rust: Refactor protover tests with new methods; note altered behaviours. Previously, the rust implementation of protover considered an empty string to

[tor-commits] [tor/master] rust: Implement error types for Rust protover implementation.

2018-04-03 Thread nickm
commit 88204f91df3e01b69e79b89ba029b42a4025d11f Author: Isis Lovecruft Date: Wed Mar 21 00:24:46 2018 + rust: Implement error types for Rust protover implementation. This will allow us to do actual error handling intra-crate in a more rusty manner,

[tor-commits] [tor/master] rust: Fix ProtoSet and ProtoEntry to use the same DoS limits as C.

2018-04-03 Thread nickm
commit f2daf82794c59c37756abeaf3e41e5ebe1e7fcde Author: Isis Lovecruft Date: Tue Mar 27 22:46:14 2018 + rust: Fix ProtoSet and ProtoEntry to use the same DoS limits as C. Previously, the limit for MAX_PROTOCOLS_TO_EXPAND was actually being applied in

[tor-commits] [tor/master] rust: Implement more memory-efficient protover datatype.

2018-04-03 Thread nickm
commit e6625113c98c281b0a649598d7daa347c28915e9 Author: Isis Lovecruft Date: Wed Mar 21 00:43:55 2018 + rust: Implement more memory-efficient protover datatype. * ADD new protover::protoset module. * ADD new protover::protoset::ProtoSet class for

[tor-commits] [tor/master] rust: Port all C protover_all_supported tests to Rust.

2018-04-03 Thread nickm
commit 6eea0dc5f186429d598edda046156afc2a93120c Author: Isis Lovecruft Date: Tue Mar 27 21:38:29 2018 + rust: Port all C protover_all_supported tests to Rust. The behaviours still do not match, unsurprisingly, but now we know where a primary difference

[tor-commits] [tor/master] rust: Refactor protover::compute_for_old_tor().

2018-04-03 Thread nickm
commit fc2a42cc49fdcab9bbc0d90212c3c7bebda238b8 Author: Isis Lovecruft Date: Tue Mar 27 02:41:25 2018 + rust: Refactor protover::compute_for_old_tor(). During code review and discussion with Chelsea Komlo, she pointed out that

[tor-commits] [tor/master] rust: Refactor protover::is_supported_here().

2018-04-03 Thread nickm
commit aa241e99dedeadf92ca72e29d16ed3e31a439392 Author: Isis Lovecruft Date: Wed Mar 21 02:09:04 2018 + rust: Refactor protover::is_supported_here(). This changes `protover::is_supported_here()` to be aware of new datatypes (e.g. don't call `.0` on

[tor-commits] [tor/master] rust: Refactor Rust impl of protover_list_supports_protocol_or_later().

2018-04-03 Thread nickm
commit 0a5494b81df684109986354a3d31051b6f8d0bec Author: Isis Lovecruft Date: Wed Mar 21 02:59:25 2018 + rust: Refactor Rust impl of protover_list_supports_protocol_or_later(). This includes a subtle difference in behaviour, as in 4258f1e18, where we

[tor-commits] [tor/master] rust: Add macro for `impl ToString for {Unvalidated}ProtoEntry`.

2018-04-03 Thread nickm
commit 26bafb3c335241c01e1f165c64d4167d26acfcc6 Author: Isis Lovecruft Date: Wed Mar 21 01:44:59 2018 + rust: Add macro for `impl ToString for {Unvalidated}ProtoEntry`. This implements conversions from either a ProtoEntry or an UnvalidatedProtoEntry

[tor-commits] [tor/master] protover: Change protover_all_supported() to return only unsupported.

2018-04-03 Thread nickm
commit 6e353664dd7c7a362be82af578954797e348d298 Author: Isis Lovecruft Date: Tue Mar 27 16:59:49 2018 + protover: Change protover_all_supported() to return only unsupported. Previously, if "Link=1-5" was supported, and you asked protover_all_supported()

[tor-commits] [tor/master] rust: Refactor protover tests with new methods; note altered behaviours.

2018-04-03 Thread nickm
commit 15e59a1fedf47e7e689e06e5649849552d8b8c0d Author: Isis Lovecruft Date: Wed Mar 21 02:13:40 2018 + rust: Refactor protover tests with new methods; note altered behaviours. Previously, the rust implementation of protover considered an empty string to

[tor-commits] [tor/master] rust: Add new protover::ProtoEntry type which uses new datatypes.

2018-04-03 Thread nickm
commit 88b2f170e451567a3b0095a420544a675a5826b0 Author: Isis Lovecruft Date: Wed Mar 21 01:18:02 2018 + rust: Add new protover::ProtoEntry type which uses new datatypes. This replaces the `protover::SupportedProtocols` (why would you have a type just

[tor-commits] [tor/master] rust: Refactor Rust impl of protover_compute_vote().

2018-04-03 Thread nickm
commit 6f252e098637bbac87b4ad99ece7fa4a7e404cdb Author: Isis Lovecruft Date: Wed Mar 21 03:05:56 2018 + rust: Refactor Rust impl of protover_compute_vote(). This includes a subtle difference in behaviour to the previous Rust implementation, where, for

[tor-commits] [tor/master] rust: Implement more memory-efficient protover datatype.

2018-04-03 Thread nickm
commit 9925d2e68709aa7346f4c5bc98ea1349df6741f3 Author: Isis Lovecruft Date: Wed Mar 21 00:43:55 2018 + rust: Implement more memory-efficient protover datatype. * ADD new protover::protoset module. * ADD new protover::protoset::ProtoSet class for

[tor-commits] [tor/master] rust: Add new protover::UnknownProtocol type.

2018-04-03 Thread nickm
commit 811178434eae16fd673b67ebda06b630aa27dec4 Author: Isis Lovecruft Date: Wed Mar 21 01:07:18 2018 + rust: Add new protover::UnknownProtocol type. * ADD new type, protover::UnknownProtocol, so that we have greater type safety and our protover

[tor-commits] [tor/maint-0.3.3] Merge remote-tracking branch 'isis-github/bug24031_r5_squashed_033' into maint-0.3.3

2018-04-03 Thread nickm
commit 8d6b1da2e6729c0cf8331e663bdfeee5d5660237 Merge: 961d2ad59 b503df277 Author: Nick Mathewson Date: Tue Apr 3 15:29:29 2018 -0400 Merge remote-tracking branch 'isis-github/bug24031_r5_squashed_033' into maint-0.3.3 changes/bug24031| 13 +

[tor-commits] [tor/master] tests: Make inline comments in test_protover.c more accurate.

2018-04-03 Thread nickm
commit 22c65a0e4bc7da08e216a769bba1b91f7b2a0ca1 Author: Isis Lovecruft Date: Tue Mar 27 21:34:00 2018 + tests: Make inline comments in test_protover.c more accurate. The DoS potential is slightly higher in C now due to some differences to the Rust

[tor-commits] [tor/master] rust: Refactor Rust implementation of protover_is_supported_here().

2018-04-03 Thread nickm
commit 9766d53cf990432f25fb70916fe9b165f1d4a36d Author: Isis Lovecruft Date: Wed Mar 21 03:08:35 2018 + rust: Refactor Rust implementation of protover_is_supported_here(). It was changed to take borrows instead of taking ownership. * REFACTOR

[tor-commits] [tor/master] rust: Add new protover::UnvalidatedProtoEntry type.

2018-04-03 Thread nickm
commit b786b146edd33b025774819f54d7bba3d07bf832 Author: Isis Lovecruft Date: Wed Mar 21 01:29:36 2018 + rust: Add new protover::UnvalidatedProtoEntry type. This adds a new protover::UnvalidatedProtoEntry type, which is the UnknownProtocol variant of a

[tor-commits] [tor/master] rust: Add new ProtoverVote type and refactor functions to methods.

2018-04-03 Thread nickm
commit 9abbd23df7104f1f46a172c2eaa62bec0afc6d9c Author: Isis Lovecruft Date: Wed Mar 21 01:52:41 2018 + rust: Add new ProtoverVote type and refactor functions to methods. This adds a new type for votes upon `protover::ProtoEntry`s (technically, on

[tor-commits] [tor/master] tests: Run all existing protover tests in both languages.

2018-04-03 Thread nickm
commit 527a2398634ecf1c244422121653f431c8df94fc Author: Isis Lovecruft Date: Tue Mar 27 21:36:10 2018 + tests: Run all existing protover tests in both languages. There's now no difference in these tests w.r.t. the C or Rust: both fail miserably (well,

[tor-commits] [tor/master] rust: Implement error types for Rust protover implementation.

2018-04-03 Thread nickm
commit b6059297d7cb76f0e00e2098e38d6677d3033340 Author: Isis Lovecruft Date: Wed Mar 21 00:24:46 2018 + rust: Implement error types for Rust protover implementation. This will allow us to do actual error handling intra-crate in a more rusty manner,

[tor-commits] [tor/maint-0.3.3] rust: Refactor Rust implementation of protover_is_supported_here().

2018-04-03 Thread nickm
commit fd127bfbfa13d407e5fb5d22a567f51a30af4c2e Author: Isis Lovecruft Date: Wed Mar 21 03:08:35 2018 + rust: Refactor Rust implementation of protover_is_supported_here(). It was changed to take borrows instead of taking ownership. * REFACTOR

[tor-commits] [tor/master] rust: Refactor Rust impl of protover_list_supports_protocol().

2018-04-03 Thread nickm
commit 52c3ea50454bcbcbcf5b18e628a1490441962b33 Author: Isis Lovecruft Date: Wed Mar 21 02:52:04 2018 + rust: Refactor Rust impl of protover_list_supports_protocol(). This includes a subtle difference in behaviour, as in 4258f1e18, where we return

[tor-commits] [tor/maint-0.3.3] rust: Refactor Rust impl of protover_list_supports_protocol().

2018-04-03 Thread nickm
commit 63eeda89ea11bf719ec6fddc7619994cc7f654ca Author: Isis Lovecruft Date: Wed Mar 21 02:52:04 2018 + rust: Refactor Rust impl of protover_list_supports_protocol(). This includes a subtle difference in behaviour, as in 4258f1e18, where we return

[tor-commits] [tor/maint-0.3.3] rust: Refactor Rust impl of protover_all_supported().

2018-04-03 Thread nickm
commit c7bcca0233d1d4c9805f78da5e7186be2c1bcdca Author: Isis Lovecruft Date: Wed Mar 21 02:45:41 2018 + rust: Refactor Rust impl of protover_all_supported(). This includes differences in behaviour to before, which should now more closely match the C

[tor-commits] [tor/maint-0.3.3] rust: Refactor Rust impl of protover_compute_vote().

2018-04-03 Thread nickm
commit 32638ed4a6c47a03b899cd09582888674ae3bf08 Author: Isis Lovecruft Date: Wed Mar 21 03:05:56 2018 + rust: Refactor Rust impl of protover_compute_vote(). This includes a subtle difference in behaviour to the previous Rust implementation, where, for

[tor-commits] [tor/maint-0.3.3] rust: Port all C protover_all_supported tests to Rust.

2018-04-03 Thread nickm
commit 4b4e36a413bb5d0e2ea499dd6bc34b3d24bd3375 Author: Isis Lovecruft Date: Tue Mar 27 21:38:29 2018 + rust: Port all C protover_all_supported tests to Rust. The behaviours still do not match, unsurprisingly, but now we know where a primary difference

[tor-commits] [tor/maint-0.3.3] add a missing word

2018-04-03 Thread nickm
commit 7ccb1c5a859873656ab074c88935865bcf4b4c38 Author: Nick Mathewson Date: Tue Apr 3 15:31:30 2018 -0400 add a missing word --- changes/bug24031 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changes/bug24031 b/changes/bug24031 index

[tor-commits] [tor/maint-0.3.3] rust: Fix ProtoSet and ProtoEntry to use the same DoS limits as C.

2018-04-03 Thread nickm
commit c65088cb1943748412e1a390de655e20bdb28692 Author: Isis Lovecruft Date: Tue Mar 27 22:46:14 2018 + rust: Fix ProtoSet and ProtoEntry to use the same DoS limits as C. Previously, the limit for MAX_PROTOCOLS_TO_EXPAND was actually being applied in

[tor-commits] [tor/master] rust: Refactor Rust impl of protover_all_supported().

2018-04-03 Thread nickm
commit 2f3a7376c06e39942ac3c4d447ca94759f12a5c3 Author: Isis Lovecruft Date: Wed Mar 21 02:45:41 2018 + rust: Refactor Rust impl of protover_all_supported(). This includes differences in behaviour to before, which should now more closely match the C

[tor-commits] [tor/maint-0.3.3] rust: Add new protover::UnknownProtocol type.

2018-04-03 Thread nickm
commit 60daaa68b153cdca6d48b09f1951d6ba580609e5 Author: Isis Lovecruft Date: Wed Mar 21 01:07:18 2018 + rust: Add new protover::UnknownProtocol type. * ADD new type, protover::UnknownProtocol, so that we have greater type safety and our protover

[tor-commits] [tor/maint-0.3.3] rust: Refactor protover::compute_for_old_tor().

2018-04-03 Thread nickm
commit cd28b4c7f5cefd319d6ded635d25911b4323b50b Author: Isis Lovecruft Date: Tue Mar 27 02:41:25 2018 + rust: Refactor protover::compute_for_old_tor(). During code review and discussion with Chelsea Komlo, she pointed out that

[tor-commits] [tor/maint-0.3.3] tests: Run all existing protover tests in both languages.

2018-04-03 Thread nickm
commit 6739a69c590a12af0f1cb2af62972f4305803670 Author: Isis Lovecruft Date: Tue Mar 27 21:36:10 2018 + tests: Run all existing protover tests in both languages. There's now no difference in these tests w.r.t. the C or Rust: both fail miserably (well,

[tor-commits] [tor/maint-0.3.3] rust: Implement error types for Rust protover implementation.

2018-04-03 Thread nickm
commit 88204f91df3e01b69e79b89ba029b42a4025d11f Author: Isis Lovecruft Date: Wed Mar 21 00:24:46 2018 + rust: Implement error types for Rust protover implementation. This will allow us to do actual error handling intra-crate in a more rusty manner,

[tor-commits] [tor/maint-0.3.3] rust: Implement more memory-efficient protover datatype.

2018-04-03 Thread nickm
commit e6625113c98c281b0a649598d7daa347c28915e9 Author: Isis Lovecruft Date: Wed Mar 21 00:43:55 2018 + rust: Implement more memory-efficient protover datatype. * ADD new protover::protoset module. * ADD new protover::protoset::ProtoSet class for

[tor-commits] [tor/maint-0.3.3] changes: Add changes file for #24031.

2018-04-03 Thread nickm
commit b503df2775d22cff0b74740357121ba5195e4a12 Author: Isis Lovecruft Date: Tue Apr 3 19:19:40 2018 + changes: Add changes file for #24031. (cherry picked from commit 5a8cdec3f8617920f19e3ab7707233ad3f02424f) --- changes/bug24031 | 13 + 1

[tor-commits] [tor/maint-0.3.3] rust: Refactor protover::is_supported_here().

2018-04-03 Thread nickm
commit 35b86a12e60a8696b512261e96dc6f1c75ecebfc Author: Isis Lovecruft Date: Wed Mar 21 02:09:04 2018 + rust: Refactor protover::is_supported_here(). This changes `protover::is_supported_here()` to be aware of new datatypes (e.g. don't call `.0` on

[tor-commits] [tor/maint-0.3.3] tests: Make inline comments in test_protover.c more accurate.

2018-04-03 Thread nickm
commit f769edd148bfbb381a48217e9016902f036b9ed8 Author: Isis Lovecruft Date: Tue Mar 27 21:34:00 2018 + tests: Make inline comments in test_protover.c more accurate. The DoS potential is slightly higher in C now due to some differences to the Rust

[tor-commits] [tor/maint-0.3.3] protover: Change protover_all_supported() to return only unsupported.

2018-04-03 Thread nickm
commit ad369313f87cba286a4f3347553e7322608dbd9c Author: Isis Lovecruft Date: Tue Mar 27 16:59:49 2018 + protover: Change protover_all_supported() to return only unsupported. Previously, if "Link=1-5" was supported, and you asked protover_all_supported()

[tor-commits] [tor/maint-0.3.3] rust: Add new protover::ProtoEntry type which uses new datatypes.

2018-04-03 Thread nickm
commit 54c964332b27104e56442128f8ce85110af89c96 Author: Isis Lovecruft Date: Wed Mar 21 01:18:02 2018 + rust: Add new protover::ProtoEntry type which uses new datatypes. This replaces the `protover::SupportedProtocols` (why would you have a type just

[tor-commits] [tor/maint-0.3.3] rust: Add macro for `impl ToString for {Unvalidated}ProtoEntry`.

2018-04-03 Thread nickm
commit fa15ea104d5b9f05192afa3a023d0e2405c3842a Author: Isis Lovecruft Date: Wed Mar 21 01:44:59 2018 + rust: Add macro for `impl ToString for {Unvalidated}ProtoEntry`. This implements conversions from either a ProtoEntry or an UnvalidatedProtoEntry

[tor-commits] [tor/maint-0.3.3] rust: Add new ProtoverVote type and refactor functions to methods.

2018-04-03 Thread nickm
commit 2eb1b7f2fd05eb0302e41b55f5cb61959cc9528e Author: Isis Lovecruft Date: Wed Mar 21 01:52:41 2018 + rust: Add new ProtoverVote type and refactor functions to methods. This adds a new type for votes upon `protover::ProtoEntry`s (technically, on

[tor-commits] [tor/maint-0.3.3] rust: Refactor Rust impl of protover_list_supports_protocol_or_later().

2018-04-03 Thread nickm
commit 269053a3801ebe925707db5a8e519836ad2242c9 Author: Isis Lovecruft Date: Wed Mar 21 02:59:25 2018 + rust: Refactor Rust impl of protover_list_supports_protocol_or_later(). This includes a subtle difference in behaviour, as in 4258f1e18, where we

  1   2   >