Hi,
I have submitted a small patch some time ago to fix some issues in
onionoo. Could someone have a look?
https://trac.torproject.org/projects/tor/ticket/16626
** firebrand
___
tor-dev mailing list
tor-dev@lists.torproject.org
Hi Cristobal, again apologies for the delay in getting you feedback. Just gave
RWSD a whirl and worked great - nice work!
From a UI perspective only feedback on what we have so far is...
* Both graphs just have the title of 'Graph component'. Better would be to
say if it's inboud or
Damian Johnson ata...@torproject.org writes:
Very minor thing, but little odd using dict() that way.
Personally, I don't find it that odd ;) and prefer it since braces can
define sets or dicts in Python, and using dict(...) makes it a little
more explicit.
BTW, your counter-example is a syntax
def get_websockets(ws_type = None):
websocket = WEBSOCKETS.get(ws_type, [])
return websocket if websocket else None
How about just:
def get_websockets(ws_type=None):
return WEBSOCKETS.get(ws_type, None)
Thanks meejah for the additional feedback! For this last one as
Sorry for the noise, I found the code (develop branch of
https://github.com/leivaburto/rwsd) and add a couple more comments:
1. The WEBSOCKETS global seems like it wants to be a class instead:
you've basically got a bunch of static functions (add_websocket, etc)
that manipulate a global
Just to touch base on this, and to give a rough status of where things
are.
The tor codebase no longer includes the C tor-fw-helper as of:
d2cb92332009567ae778b3570e8fd3420c207446
Closes https://trac.torproject.org/projects/tor/ticket/13338
The new (Go based code) now lives at:
On 6 Aug 2015, at 02:53 , Damian Johnson ata...@torproject.org wrote:
client/templates/index.html
10 link
