cvs commit: db-torque/src/generator/src/java/org/apache/torque/engine/database/model TypeMap.java

2004-08-25 Thread seade
seade 2004/08/25 22:18:39 Modified:src/generator/src/templates/om Object.vm Peer.vm ObjectWithManager.vm src/generator/src/java/org/apache/torque/engine/database/model TypeMap.java Log: Hennings Findbugs patch. Thi

cvs commit: db-torque/src/generator/src/java/org/apache/torque/engine/database/model TypeMap.java

2004-08-25 Thread seade
seade 2004/08/25 22:16:03 Modified:src/generator/src/templates/om Tag: TORQUE_3_1_BRANCH ObjectWithManager.vm Peer.vm Object.vm src/generator/src/java/org/apache/torque/engine/database/model Tag: TORQUE_3_1_BRANCH TypeMap.j

Re: Findbugs Patch for 3.1.1

2004-08-25 Thread Scott Eade
Henning P. Schmiedehausen wrote: There are some a == b checks where a and b are Strings in the peers Index: src/generator/src/templates/om/Peer.vm === --- src/generator/src/templates/om/Peer.vm (revision 2582) +++ src/generator/sr

Re: Findbugs Patch for 3.1.1

2004-08-25 Thread Scott Eade
I will apply this for 3.1.1, but it would have been easier if you had provided a patch against cvs rather than against your version that includes the boolean getter patch that I don't see going in as part of 3.1.1 (3.1.2-dev is more acceptable I think). I assume there will be some correspondin

Findbugs Patch for 3.1.1

2004-08-25 Thread Henning P. Schmiedehausen
Hi, we should consider applying the attached patch to Torque before releasing 3.1.1 I ran Findbugs on an application of mine with roughly 80 peer and object classes and this patch reduces the number of warnings / error reports from about 500 to one (which is bogus. :-) This is mainly working aro

Re: Deployment to repository [was" [SOURCE] Issue #TRQS217 modified]

2004-08-25 Thread Henning P. Schmiedehausen
Scott Eade <[EMAIL PROTECTED]> writes: >Thanks Henning, this sounds really good. I know it is OT, but would you >mind listing for me the properties that I need to set to make this work. >Maven tells me that I need: >maven.username I have maven.username=henning maven.ssh.args=-o ForwardX1