Re: change name of retrieveByPks method to retrieveByObjectKeys?

2015-09-22 Thread Thomas Fox
Thanks, Greg. This seems a good way to go, I will do this. Thomas Greg Monroe wrote: This seems like it might have an impact on existing code. Any reason not to deprecate the existing methods and go with retrieveByObjectPKs and retrieveByIntegerPKs? This would define a clear naming con

Re: change name of retrieveByPks method to retrieveByObjectKeys?

2015-09-21 Thread Greg Monroe
This seems like it might have an impact on existing code. Any reason not to deprecate the existing methods and go with retrieveByObjectPKs and retrieveByIntegerPKs? This would define a clear naming convention for any future convenience method.. e.g. retrieveByStringPKs and the like. On 9/1

Re: change name of retrieveByPks method to retrieveByObjectKeys?

2015-09-20 Thread Thomas Vandahl
On 19.09.15 23:02, Thomas Fox wrote: > Hi, > > for > https://issues.apache.org/jira/browse/TORQUE-334 > I'd like to change the name of the existing retriebeByPks methods to > retrieveByObjectKeys. > > Any objections or better ideas ? > > Example: > BaseBookPeer now has 2 methods: > > public s

change name of retrieveByPks method to retrieveByObjectKeys?

2015-09-19 Thread Thomas Fox
Hi, for https://issues.apache.org/jira/browse/TORQUE-334 I'd like to change the name of the existing retriebeByPks methods to retrieveByObjectKeys. Any objections or better ideas ? Example: BaseBookPeer now has 2 methods: public static List retrieveByPKs(Collection pks); public static List re