CLogDlg::MonitorEditProject remove \r and \n from encrypted username/password

2022-11-21 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, While investigating another issue in the Project Monitor, I saw the following code in MonitorEditProject: [[[ pEditProject->username = CStringUtils::Encrypt(dlg.m_sUsername); pEditProject->password = CStringUtils::Encrypt(dlg.m_sPassword); pEditProject->username.Remov

"You have to update your working copy" doesn't offer to update

2022-11-21 Thread Daniel Sahlberg via TortoiseSVN-dev
Hi, There has been reports about commits (and merge?) failing with "You have to update your working copy first" but without the subsequent offer to update. Today I stumbled on one such case. I traced it to CommitCommand::IsOutOfDate not checking for error 155011 (SVN_ERR_WC_NOT_UP_TO_DATE). I