[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-02 Thread Guilherme G. Piccoli
** Patch added: "debdiff v2" https://bugs.launchpad.net/ubuntu/artful/+source/systemd/+bug/1750013/+attachment/5067376/+files/lp1750013-trusty_v2.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu.

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-02 Thread Guilherme G. Piccoli
Dan, please let me know if the debdiff v2 above addresses your concern and if it's properly following your suggestion. I tested the modification and it's working fine. Thanks, Guilherme -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-02 Thread Guilherme G. Piccoli
Dan, really well-observed! Thanks for the suggestion, it makes total sense. I'll update the approach: instead of using session_remove_fifo() to add the session on GC, I'll use the DBus handler itself. After testing, I'll submit a debdiff_v2 here. Thanks, Guilherme -- You received this bug

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-02 Thread Guilherme G. Piccoli
Dan, thanks for looking at the patch and for your question! I tried to explain this a bit in comment #1, not too much detailed though: "[...]closing session should be somehow added to gc [...] and then (the gc) performs the clean-up. To include a session in gc, the function

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-02-28 Thread Guilherme G. Piccoli
** Description changed: - It was observed that systemd-logind tool is leaking memory at each session - connected. The issue happens in systemd from Trusty (14.04), which latest - version currently (Feb/2018) is 204-5ubuntu20.26 (and still reproduces - the bug). - - The basic test-case is to run

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-02-16 Thread Guilherme G. Piccoli
** Changed in: systemd (Ubuntu Trusty) Importance: Undecided => Medium ** Changed in: systemd (Ubuntu Trusty) Status: New => In Progress ** Changed in: systemd (Ubuntu Trusty) Assignee: (unassigned) => Guilherme G. Piccoli (gpiccoli) ** Changed in: systemd (Ubun

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-02-16 Thread Guilherme G. Piccoli
** Changed in: systemd (Ubuntu) Importance: Undecided => Medium ** Changed in: systemd (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to systemd in Ubuntu.

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-02-16 Thread Guilherme G. Piccoli
As already briefly mentioned, Trusty systemd's package has additional patches to customize systemd - specially, we have the addition of glue code to make Trusty's systemd work with cgmanager. This is necessary due to the choice of upstart as init manager - it prevents regular cgroup handling from

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-02-16 Thread Guilherme G. Piccoli
It was noticed that during the logind manager logic for creating a session based on dbus event, the sessions's initialization procedure will allocate 2 structures related to cgroup management of a session: controllers and reset_controllers. Both these structs are filled with cgroup controllers

[Touch-packages] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-02-16 Thread Guilherme G. Piccoli
After some debug, it was observed that the only path in which a session is freed (other than in user/seat free or manager free) is in garbage collecting, specifically in the function manager_gc(). It means a closing session should be somehow added to gc in order gc has a chance to validate if the

[Touch-packages] [Bug 1750013] [NEW] systemd-logind: memory leaks on session's connections (trusty-only)

2018-02-16 Thread Guilherme G. Piccoli
essions alive. This can be verified through the command "loginctl list-session" - each session that once connected is present there "forever". The memory leaks can eventually lead to OOM situation of this process. Debug progress will be tracked here, in this LP. ** Affects: systemd

<    1   2