[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-07-12 Thread Daniel van Vugt
See related bug 1578612 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity8 in Ubuntu. https://bugs.launchpad.net/bugs/1372530 Title: Button text color doesn't offer great contrast, and looks disabled when it's not

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-05-30 Thread Daniel van Vugt
** Tags added: visual-quality -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity8 in Ubuntu. https://bugs.launchpad.net/bugs/1372530 Title: Button text color doesn't offer great contrast, and looks disabled when it's

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-05-27 Thread Rae Shambrook
The new button designs have a lighter background (#f7f7f7) and darker text that is #11. Currently Pierre is working on the updated design. ** Changed in: ubuntu-ux Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-02-17 Thread Pierre Bertet
** Branch linked: lp:~bpierre/ubuntu-ui-toolkit/combobutton-standalone ** Branch linked: lp:~bpierre/ubuntu-ui-toolkit/newbutton -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity8 in Ubuntu.

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-02-17 Thread Zsombor Egri
Pierre, maybe then it would be wiser to assign the bug to those MRs? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity8 in Ubuntu. https://bugs.launchpad.net/bugs/1372530 Title: Button text color doesn't offer great

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-02-17 Thread Pierre Bertet
With the new styles, the color of the Button and the ComboButton doesn’t rely on the luminance anymore. Related merge requests: https://code.launchpad.net/~bpierre/ubuntu-ui-toolkit/combobutton-standalone/+merge/280703 https://code.launchpad.net/~bpierre/ubuntu-ui-toolkit/newbutton/+merge/286085

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-02-17 Thread Daniel van Vugt
Wow, I got that wrong. 0x5D is roughly luminance 0.36f so will only work with bright backgrounds. Not dark or mid-tone backgrounds like we see. So another aspect of this bug is that the background is a mid-grey, which does not contrast with text that is #5d5d5d. The designed colours however seem

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-02-16 Thread Daniel van Vugt
Sorry, ignore my personal suggestion. I got that backwards and think design's choice of #5D5D5D will be better. Although darker again might be more better :) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity8 in Ubuntu.

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-02-16 Thread Daniel van Vugt
Just looked at the current design docs with kgunn's help. It appears the common 'dark' text colour for light backgrounds Ubuntu Design wants is #5D5D5D (but I personally think #88 might look better). So it's seemingly just the threshold we've got wrong in ButtonStyle.qml: textColor:

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-02-16 Thread Daniel van Vugt
Is that right? We had a design at least in September 2014 without this issue and we just haven't implemented the right colours? Or is there some newer design that the current implementation is closer to? -- You received this bug notification because you are a member of Ubuntu Touch seeded

[Touch-packages] [Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not

2016-02-16 Thread Daniel van Vugt
Perhaps it should be implemented more like: textColor: ColorUtils.luminance(button.color) < 0.5 && !(stroke && !pressed) ? "#FF" : "#00" -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity8 in Ubuntu.