[Touch-packages] [Bug 1492343] Re: Pages hidden in an AdpativePageLayout stack have their width changed to zero

2015-10-22 Thread Zsombor Egri
** Changed in: ubuntu-ui-toolkit (Ubuntu) Assignee: (unassigned) => Zsombor Egri (zsombi) ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed

[Touch-packages] [Bug 1492343] Re: Pages hidden in an AdpativePageLayout stack have their width changed to zero

2015-09-24 Thread Zsombor Egri
While implementing the bug fix for #1499178 I started to get segfault on UITK Gallery when one column mode was set. Every time I tried to push a second page in a column was causing segfault. Sizing invisible item to fill the AdaptivePageLayout solves the segfault, however would not solve the pages

[Touch-packages] [Bug 1492343] Re: Pages hidden in an AdpativePageLayout stack have their width changed to zero

2015-09-07 Thread Tim Peeters
Actually the Page does not fill its parent, but anchors to all sides except the top, and the Page.height depends on the parent, the header, and whether the Page has a flickable. As long as we don't move the header into the page, I don't see a better solution than what we have now. If we don't

[Touch-packages] [Bug 1492343] Re: Pages hidden in an AdpativePageLayout stack have their width changed to zero

2015-09-06 Thread Zsombor Egri
Tim, sorry, this auto-correct reformulated my words, I meant concepted badly :) Page filling its parent is what causes the width changes when reparented, do you agree? I do not say that width becoming 0 is right, but I disagree Page filling its parent is also a wanted behaviour. You can always

[Touch-packages] [Bug 1492343] Re: Pages hidden in an AdpativePageLayout stack have their width changed to zero

2015-09-06 Thread Zsombor Egri
The root cause of the problem you see is because the Page itself anchor fills to its parent. This was connected badly, and because of that we have this problem. A fix would be to have property change for each Page added into the hidden item to unset the anchor.fill of the page and restore it

[Touch-packages] [Bug 1492343] Re: Pages hidden in an AdpativePageLayout stack have their width changed to zero

2015-09-06 Thread Tim Peeters
Zsombi what do you mean with "connected badly"? The page fills its parent, but that is what you want, also when it is (visible) inside the AdaptivePageLayout. You should not set a fixed width because the columns can be resized (by changing the window size, changing the column layouts, or directly

[Touch-packages] [Bug 1492343] Re: Pages hidden in an AdpativePageLayout stack have their width changed to zero

2015-09-04 Thread Andrew Hayzen
OK, so for music the pages that are noticeable with this bug use the custom ColumnFlow, so I have patched [1] this to only update the widths of the cards when the view is visible, which appears to have resolved the issue for us. However, this should probably still be a bug in the SDK as it was

[Touch-packages] [Bug 1492343] Re: Pages hidden in an AdpativePageLayout stack have their width changed to zero

2015-09-04 Thread Tim Peeters
Internally the AdaptivePageLayout has an Item with id hiddenPages which is the parent for the Pages that were added but not visible. We did not set its anchors, that is why it is null. A quick fix to make its width not 0 is to make it fill its parent (the AdaptivePageLayout), but then still the