[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

** Tags added: id-58e22b4afdee5f97b3bfbfd7 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ntp in Ubuntu. https://bugs.launchpad.net/bugs/1656801 Title: ntp: changing the default config from server to pool broke the dhcp

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

This bug was fixed in the package ntp - 1:4.2.8p4+dfsg-3ubuntu5.4 --- ntp (1:4.2.8p4+dfsg-3ubuntu5.4) xenial; urgency=medium * Fix ntp.dhcp to also check for pool and better handle spaces and tabs. (LP: #1656801) -- Phil Roche Thu, 19 Jan 2017

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

I have verified that ntp 1:4.2.8p4+dfsg-3ubuntu5.4 in xenial-proposed passes the test case outlined in the description above. * Launch GCE instance * Enabled proposed * Upgrade ntp * Reboot * Confirm `ntpq -p` returns only one entry ** Tags removed: verification-needed ** Tags added:

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

Hello Philip, or anyone else affected, Accepted ntp into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ntp/1:4.2.8p4+dfsg- 3ubuntu5.4 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

** Description changed: In 1:4.2.8p3+dfsg-1, the default config was changed to "Use pool instead of server". This needs a corresponding update to /etc/dhcp/dhclient-exit-hooks.d/ntp, since the DHCP specified servers now get added to the default pool config instead of replacing them.

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

Hi mterry. RE: test case steps. This surfaced for me initially while testing on GCE. On GCE NTP servers are provided via DHCP so the easiest test case is to launch an instance on GCE without our workaround configured. One such image is "daily-ubuntu-ntpdebug-1604-xenial-v20170331" in project

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

I've uploaded the patch in comment #3 to xenial. I've also added some SRU bits to the description -- if either Robie or Philip could maybe add some test case steps, that would be swell. Thanks! ** Description changed: In 1:4.2.8p3+dfsg-1, the default config was changed to "Use pool instead

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

Given that Debian has already applied the patch which eliminates the distinction between tabs & spaces, there doesn't seem a lot of point in keeping a different patch in place. Best to apply the patch as is, and deal with the issue of augmenting the list separately, if necessary. -- You

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

Correction to my comment above: the patch at https://bugs.debian.org /cgi-bin/bugreport.cgi?bug=809344 is preferable to the patch as proposed; thanks @philroche. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ntp in Ubuntu.

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

** Changed in: ntp (Debian) Status: Unknown => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ntp in Ubuntu. https://bugs.launchpad.net/bugs/1656801 Title: ntp: changing the default config from server

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

One comment on @philroche's patch: at present, there is no supported way to allow DHCP to augment (rather than replace) NTP servers in /etc/ntp.conf. The different handling of tabs & spaces is a known- useful workaround for those of us who wish to allow DHCP to specify additional servers, without

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

** Changed in: ntp (Ubuntu) Importance: Undecided => Medium ** Changed in: ntp (Ubuntu Xenial) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ntp in Ubuntu.

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

** Also affects: ntp (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809344 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ntp in Ubuntu.

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

Please find attached patch for this bug. This is the same fix as upstream (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806676 and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809344) The patch adds "pool" to the "server" and "peer" list as well as handling tabs and spaces in the

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

Thank you for identifying this. I agree it makes sense to fix it in Xenial. Though I wonder about how the change might adversely impact existing users. For example, if a DHCP user is receiving a broken set of NTP servers that doesn't work, currently his NTP won't be broken because the default set

[Touch-packages] [Bug 1656801] Re: ntp: changing the default config from server to pool broke the dhcp hook

The issue if a broken set of NTP servers is received and having no fallback is the case in Yakkety now too though and previously in Xenial prior to the server/pool changeover in 1:4.2.8p3+dfsg-1. I agree that ideally there would be a fallback if the received NTP servers were broken but this bug