[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2021-05-25 Thread Adolfo Jayme
** Changed in: apt (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu. https://bugs.launchpad.net/bugs/1824088 Title: unattended upgrade ran one day after schedule

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
It seems systemd actually supports restarting oneshot services now, so any options for timestamps will be removed (anything other than 0 will behave as always), and systemd timers will have to be configured via drop-ins instead. Finally. That said, it seems a bit late for focal now. Hmm, yeah, I

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Magnus Jonsson
The thing is that it's only the delta that is handled in UTC not the iso-8601-part so it will work just fine. My first idé was to fix the interval calculations must like yours. The workaround for us was to set interval to always. We have local mirrors that can handle the load just fine even if

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
But if I live in UTC+11, I don't want it to run when the day has changed in UTC+0? As for date +%s being time zone dependent, hmm, I thought iso-8601 included a timezone, but it does not. A workaround for DST that might work for non-1-day intervals could be to change the length of a day to 22

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Magnus Jonsson
The interesting about the code is that it always only treat the timestamp of the file as "-MM-DD" and nothing else (this also includes "now"). The code has functions for allowing the interval to be set down to 1s but is does not mean anything to the outcome of the script as it always looks

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
https://salsa.debian.org/apt-team/apt/-/merge_requests/115 implements the proposed change for daily runs, and warns if intervals are configured to anything other than 1 or 0 (and soon, always), telling people to configure their systemd timer instead. -- You received this bug notification because

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
** Tags removed: patch -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu. https://bugs.launchpad.net/bugs/1824088 Title: unattended upgrade ran one day after schedule Status in apt package in Ubuntu: Triaged

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
Oh but we have the other issue where we have more interval options than systemd services. Sigh. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu. https://bugs.launchpad.net/bugs/1824088 Title: unattended

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
It seems reasonable that setting TZ=UTC0 for date --iso-8601 could help (as that's where a time zone is relevant, the +%s conversion it is not relevant for). But then this causes unwanted behaviour for people far off UTC, I guess, so it's not a solution - It's entirely unclear to me whether a

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
Arguably, a workaround might be to remove support for the interval options now, and then treat it as "one day", and just check that %Y-%m-%d for today != the one for the stamp. This addresses the problem with DST, and breaks every non-default configuration. Which is something we will have to live

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Ubuntu Foundations Team Bug Bot
The attachment "apt.systemd.daily.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
I know that we can sometimes miss a beat so to say, but fixing this will require fixing systemd to allow retrying of failed timer services, and then removing the options for intervals inside of apt. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages,

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Julian Andres Klode
I'm not convinced there is a bug here or that the patch actually fixes it. We convert our times to Unix time stamps, which are independent of time zones and DST. The proposed patch should not be doing anything. And no, we apt folks do not need or want a duplicate bug report in Debian. -- You

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Carl Winbäck
Awesome work Magnus. Well done! Since the bug is related to APT, is Debian then considered the upstream of this source? Would it be appropriate to also file a bug in their bug tracker? If so, I can arrange that. -- You received this bug notification because you are a member of Ubuntu Touch

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Magnus Jonsson
** Patch added: "apt.systemd.daily.diff" https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1824088/+attachment/5344224/+files/apt.systemd.daily.diff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu.

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-04-01 Thread Magnus Jonsson
Setting TZ for the complete script will not work as it will make strange behaviour if you are far away from UTC/GMT TZ. You can set it for just the date command that returns the epoch time. I did a patch that does that for the bionic version. It also applys directly on Focal. I attach the patch

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-03-31 Thread Carl Winbäck
How about this idea? What if we add this line to the beginning of usr/lib/apt/apt.systemd.daily: export TZ="UTC0" (I got this idea from the GNU Coreutils manual. See https://www.gnu.org/software/coreutils/manual/html_node/Relative-items- in-date-strings.html) -- You received this bug

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-03-31 Thread Carl Winbäck
If we look at lines 131 and 132 in /usr/lib/apt/apt.systemd.daily, we will se the following: interval="${interval%d}" interval=$((interval*60*60*24)) I’m not 100% certain but I think that this time logic is what cause the bug to occur, in accordance with what Magnus has pointed out in his

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-03-31 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: apt (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu.

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-03-31 Thread Magnus Jonsson
It will not run after 36h either. It will not run until next day because "yesterday" did not have 24 hours until next day. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu. https://bugs.launchpad.net/bugs/1824088

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-03-30 Thread Julian Andres Klode
It's hardly and issue given that the script runs twice per day, which compensates for that by running it after 36 hours instead of 24. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu.

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-03-30 Thread Julian Andres Klode
Yes we know that the script does not necessarily run once a day, that's not a surprise. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu. https://bugs.launchpad.net/bugs/1824088 Title: unattended upgrade ran

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2020-03-30 Thread Magnus Jonsson
This IS related to daylight saving. The script: /usr/lib/apt/apt.systemd.daily check that the script is not run twice at the same period. The script checks the date of today and the date of the last timestamp to determine the the diff. The interval is calculated using the number of seconds per

[Touch-packages] [Bug 1824088] Re: unattended upgrade ran one day after schedule

2019-04-10 Thread Carl Winbäck
** Attachment added: "Log data from apt" https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1824088/+attachment/5254618/+files/history.txt -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu.