[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-05-01 Thread Robie Basak
I wondered if ucf is expected to handle dpkg-divert -ed files in the first place, since that seemed odd to me. It does seem like that's a feature the code was intended to support, although it's unclear to me if it ever worked, and it's not really documented anywhere I can find except that is

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-05-01 Thread Robie Basak
> * run update-maintainer script FWIW, it's not necessary to mention this directly. It is correct to do it, but convention is to skip mentioning it in the changelog because otherwise we'd have to unnecessarily mention it on nearly every Ubuntu upload. -- You received this bug notification

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-04-30 Thread Heitor Alves de Siqueira
Thanks for the confirmation on Focal, @pponnuvel! I've tested your debdiff, and it seems to work correctly. Patch is also a straightforward cherry-pick from Debian. Sponsored for Jammy, with the update-maintainer changes. -- You received this bug notification because you are a member of Ubuntu

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-04-24 Thread Ponnuvel Palaniyappan
Thanks, Heitor. I'll remember to run `update-maintainer` going forward! Re. Focal: The syntax error and relevant code was introduced in 3.0040 whereas Focal is using older ucf. Thus Focal is unaffected. Likewise Lunar/Mantic/Noble have the fixed version already. So this is a Jammy- only backport.

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-04-24 Thread Heitor Alves de Siqueira
Hi Pon, thanks for the revised debdiff! This seems to be a non-quilt package, so your approach of directly patching the ucf/ucfr scripts is correct. The only thing missing is running the update-maintainer script, as the ubuntu1 version requires having an ubuntu.com address on the maintainers

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-04-24 Thread Ponnuvel Palaniyappan
Thanks, Dariusz! I've attached a new debdiff. ** Attachment added: "debdiff_2061825_new.txt" https://bugs.launchpad.net/ubuntu/+source/ucf/+bug/2061825/+attachment/5770060/+files/debdiff_2061825_new.txt -- You received this bug notification because you are a member of Ubuntu Touch seeded

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-04-24 Thread Dariusz Gadomski
Hey Pon, the debdiff contains changes to a bunch of files inside .pc which should not be included. Can you try generating the debdiff again wtihout these changes? Once of the ways would be to drop in a patch to d/patches and add it with quilt or apply it with the "patch" command and then run

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-04-18 Thread Ponnuvel Palaniyappan
Attaching the debdiff. ** Attachment added: "debdiff.txt" https://bugs.launchpad.net/ubuntu/+source/ucf/+bug/2061825/+attachment/5767388/+files/debdiff.txt -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ucf in Ubuntu.

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-04-17 Thread Ponnuvel Palaniyappan
** Tags added: sts ** Description changed: - ucf doesn't work correctly when local diversions in place. + [ Impact ] - This is due to a syntax error and has been fixed in Debian upstream: + When a dpkg-diversion is used to setup a package diversion and ucf for managing + the configuration

[Touch-packages] [Bug 2061825] Re: [SRU] ucf fails to work for local diversions on Jammy

2024-04-17 Thread Ponnuvel Palaniyappan
** Summary changed: - ucf fails to work for local diversions on Jammy + [SRU] ucf fails to work for local diversions on Jammy -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ucf in Ubuntu.