On 8/3/2013 7:25 PM, Strake wrote:
Besides that there's -i, which could be done easily by open()ing a
temporary file, writing to that, then renaming to the original filename.
This violates the doctrine to do one thing well. Alas, users want it,
and scripts use it.
Giving flags to users is
On 8/4/2013 11:53 AM, Felix Janda wrote:
Dave wrote:
On 8/3/2013 7:25 PM, Strake wrote:
Besides that there's -i, which could be done easily by open()ing a
temporary file, writing to that, then renaming to the original filename.
This violates the doctrine to do one thing well. Alas, users want
grep in hg tip won't build without this patch.
xfdopen is not needed (we already have the file open, and we wouldn't
want to die early if by some peculiar chance that were irrelevant).
diff -r b570b2bfbf7d toys/pending/grep.c
--- a/toys/pending/grep.c Sun Aug 04 01:22:49 2013 -0500
+++
Hello,
fdlength in lib.c does not seem to work properly, I noticed this when
toybox's insmod sometimes failed mysteriously.
I have attached a patch that should fix the issue, along with a test case
that evidences the issue (use -std=c99).
Regards,
Achille
patch-fix-fdlength.diff
Description:
