Re: [Toybox] [PATCH] Fix vmstat for large machines.

2018-03-21 Thread enh
On Wed, Mar 21, 2018 at 11:28 AM, Rob Landley wrote: > On 03/16/2018 01:35 PM, enh wrote: >> -} else if (!(p = strafter(toybuf, vmstuff[i]))) goto error; >> -if (1 != sscanf(p, "%"PRIu64"%n", new++, &j)) goto error; >> +} else if (!(p = strafter(file, vmstuff[i]))) { >> + error_ex

Re: [Toybox] [PATCH] Fix vmstat for large machines.

2018-03-21 Thread Rob Landley
On 03/16/2018 01:35 PM, enh wrote: > -} else if (!(p = strafter(toybuf, vmstuff[i]))) goto error; > -if (1 != sscanf(p, "%"PRIu64"%n", new++, &j)) goto error; > +} else if (!(p = strafter(file, vmstuff[i]))) { > + error_exit("No %sin %s", vmstuff[i], name); > +} > +if (1 !=

[Toybox] bc style

2018-03-21 Thread Gavin Howard
Rob, In the interest of preventing a split between standalone and toybox bc's (when I submit it), I have a couple style questions. First, about booleans. I have read your thoughts and the LKML post by Linus. I disagree with Linus, not because I don't think there are nuances (there are, but I have