Re: [Toybox] [PATCH] Support fractional seconds (and other time units) in `top -d`.

2018-05-05 Thread Rob Landley
Yeah, sorry, the todo item this spun off is "lib/args.c updates" but I spent today distracted*. Rob * I.E. trying to figuring out how ubifs (and the ubi layer under it) work, preferably with qemu emulating flash, and how to genericize https://balau82.wordpress.com/2010/02/28/hello-world-for-bare-

Re: [Toybox] [PATCH] Implement `file -`.

2018-05-05 Thread Rob Landley
On 05/05/2018 06:19 PM, enh wrote: > AFK, but I'm using glibc too, from Debian testing.  I found it, the stdin case is using the stat.length value to see how much to read but never did the stat, so it's uninitialized stack crap. When it's zero... Oops. Oddly enough, the compiler did not complain!

Re: [Toybox] [PATCH] Implement `file -`.

2018-05-05 Thread enh
AFK, but I'm using glibc too, from Debian testing. On Sat, May 5, 2018, 16:01 Rob Landley wrote: > On 05/05/2018 02:14 PM, enh wrote: > > On Sat, May 5, 2018 at 10:53 AM, Rob Landley wrote: > > well, strictly i think only the ELF case actually needs this > > currently. we could fix the logic fo

Re: [Toybox] [PATCH] Implement `file -`.

2018-05-05 Thread Rob Landley
On 05/05/2018 02:14 PM, enh wrote: > On Sat, May 5, 2018 at 10:53 AM, Rob Landley wrote: > well, strictly i think only the ELF case actually needs this > currently. we could fix the logic for the non-ELF cases (see below) > and only copy to a temporary file for the ELF case. (alternatively, we > c

Re: [Toybox] [PATCH] Support fractional seconds (and other time units) in `top -d`.

2018-05-05 Thread enh
ping? On Thu, May 3, 2018 at 3:25 PM, enh wrote: > LTP uses `top -d 0.1`, which isn't convincingly useful, but general > support for other time units might be useful, and switching to xparsetime > addresses both at once. > > Also fix 3169d948c049664bcf7216d4c4ae751881099d3e where I mistakenly > t

Re: [Toybox] [PATCH] Implement `file -`.

2018-05-05 Thread enh
On Sat, May 5, 2018 at 10:53 AM, Rob Landley wrote: > On 05/04/2018 12:53 PM, enh wrote: >> okay, here's an alternative patch that only does the temporary file >> dance for regular files... > > Aren't regular files already seekable? > > Do pipes show up as regular files for the originally unseekab

Re: [Toybox] [PATCH] Implement `file -`.

2018-05-05 Thread Rob Landley
On 05/04/2018 12:53 PM, enh wrote: > okay, here's an alternative patch that only does the temporary file > dance for regular files... Aren't regular files already seekable? Do pipes show up as regular files for the originally unseekable case (which I'm guessing is something like "cat a.out | file