Re: [Toybox] [PATCH] macOS: move getmountlist.c functions into portability.c.

2018-12-05 Thread David Seikel
> What ever it is, this isn't the first mailman driven mailing list I'm > having that problem with. I wonder if there is a simple to use > "convert base64 encoded ASCII emails to just plain damn ASCII emails" > utility I can bolt onto my mail filtering pipeline and be done with > it? I logged ont

Re: [Toybox] [PATCH] macOS: move getmountlist.c functions into portability.c.

2018-12-05 Thread David Seikel
Given the subject of this port of the discussion, apologies for the lack of attribution in the quotes below. > > Though now I'm getting annoyed at mailman sending plain ASCII text > > as base64 encoding. My email proggy can't handle quoting that. It > > didn't used to. > > I wonder if that's

Re: [Toybox] [PATCH] mktemp: fix the tests and the logic.

2018-12-05 Thread enh via Toybox
(sent. you can just run `./toybox mktemp -u tmp.XXX` to see the effect.) On Wed, Dec 5, 2018 at 5:27 PM enh wrote: > > which seems to have found a bug in the password code? > > i'll send you that patch as a follow up to this one, and you can look at why > i

[Toybox] [PATCH] mktemp: yet more tests, and yet more fixes.

2018-12-05 Thread enh via Toybox
In particular this reuses the password.c code for random ASCII bytes. --- lib/lib.h | 1 + lib/password.c| 35 +-- tests/mktemp.test | 6 ++ toys/lsb/mktemp.c | 24 ++-- 4 files changed, 46 insertions(+), 20 deletions(-) diff -

Re: [Toybox] [PATCH] mktemp: fix the tests and the logic.

2018-12-05 Thread enh via Toybox
which seems to have found a bug in the password code? i'll send you that patch as a follow up to this one, and you can look at why if mktemp reuses that code, long enough templates end in a string of '.'s... On Wed, Dec 5, 2018 at 4:08 PM enh wrote: > note that you've already got "random ascii"

Re: [Toybox] [PATCH] mktemp: fix the tests and the logic.

2018-12-05 Thread enh via Toybox
note that you've already got "random ascii" code in password.c --- i have a half-finished patch that switches mktemp over to reusing that instead... On Wed, Dec 5, 2018 at 3:40 PM Rob Landley wrote: > On 12/5/18 5:03 PM, enh via Toybox wrote: > > Multiple bugs: > > > > * We weren't outputting an

Re: [Toybox] [PATCH] mktemp: fix the tests and the logic.

2018-12-05 Thread Rob Landley
On 12/5/18 5:03 PM, enh via Toybox wrote: > Multiple bugs: > > * We weren't outputting anything in the case where we actually create a >   file or directory (but all the tests were for the -u case). > > * There are more gnarls to the behavior if TEMPLATE contains a '/'. The >   new tests cover th

[Toybox] [PATCH] mktemp: fix the tests and the logic.

2018-12-05 Thread enh via Toybox
Multiple bugs: * We weren't outputting anything in the case where we actually create a file or directory (but all the tests were for the -u case). * There are more gnarls to the behavior if TEMPLATE contains a '/'. The new tests cover these. Additionally, I've realized that glibc's mktemp(3)

Re: [Toybox] [PATCH] mktemp: add -t and fix behavior.

2018-12-05 Thread enh via Toybox
On Wed, Dec 5, 2018 at 10:12 AM enh wrote: > > On Wed, Dec 5, 2018 at 9:57 AM Rob Landley wrote: > > > > On 12/5/18 9:56 AM, enh via Toybox wrote: > > > Yes, that's what we've been talking about for days. Search for mktemp and > > > glibc. > > > > > > Bionic will warm you at compile time instead

Re: [Toybox] [PATCH] mktemp: add -t and fix behavior.

2018-12-05 Thread enh via Toybox
On Wed, Dec 5, 2018 at 9:57 AM Rob Landley wrote: > > On 12/5/18 9:56 AM, enh via Toybox wrote: > > Yes, that's what we've been talking about for days. Search for mktemp and > > glibc. > > > > Bionic will warm you at compile time instead, and musl should be silent. > > He's not gonna be the last

Re: [Toybox] [PATCH] mktemp: add -t and fix behavior.

2018-12-05 Thread Rob Landley
On 12/5/18 9:56 AM, enh via Toybox wrote: > Yes, that's what we've been talking about for days. Search for mktemp and > glibc.  > > Bionic will warm you at compile time instead, and musl should be silent.  He's not gonna be the last one to notice, though. Sigh, I may need to add a mktemp in por

Re: [Toybox] [PATCH] macOS: move getmountlist.c functions into portability.c.

2018-12-05 Thread Rob Landley
On 12/5/18 6:31 AM, David Seikel wrote: >> There's something strange about gmail and this mailing list.  I still >> can read your messages only from Elliot Hughes' replies (And of >> course I saw that message since you Cc'ed me). I can't even find your >> messages in the "Spam" folder in Thunderbir

Re: [Toybox] [PATCH] macOS: move getmountlist.c functions into portability.c.

2018-12-05 Thread Rob Landley
On 12/5/18 2:47 AM, Reverend Homer wrote: > There's something strange about gmail and this mailing list. I still can read > your messages only from Elliot Hughes' replies (And of course I saw that > message since you Cc'ed me). I can't even find your messages in the "Spam" > folder in Thunderbird!

Re: [Toybox] [PATCH] mktemp: add -t and fix behavior.

2018-12-05 Thread enh via Toybox
Yes, that's what we've been talking about for days. Search for mktemp and glibc. Bionic will warm you at compile time instead, and musl should be silent. On Wed, Dec 5, 2018, 03:11 Reverend Homer Oops, now I have link-time warning: > > > ld: generated/obj/mktemp.o: in function `mktemp_main': > >

Re: [Toybox] [PATCH] macOS: move getmountlist.c functions into portability.c.

2018-12-05 Thread David Seikel
> There's something strange about gmail and this mailing list.  I still > can read your messages only from Elliot Hughes' replies (And of > course I saw that message since you Cc'ed me). I can't even find your > messages in the "Spam" folder in Thunderbird! Switching to no longer using gmail seems

Re: [Toybox] [PATCH] mktemp: add -t and fix behavior.

2018-12-05 Thread Reverend Homer
Oops, now I have link-time warning: ld: generated/obj/mktemp.o: in function `mktemp_main': mktemp.c:(.text.mktemp_main+0xa9): warning: the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp' R.H. On 29/11/2018 03:15, enh via Toybox wrote: The new tests pass on the host (coreut

Re: [Toybox] [PATCH] macOS: move getmountlist.c functions into portability.c.

2018-12-05 Thread Reverend Homer
There's something strange about gmail and this mailing list.  I still can read your messages only from Elliot Hughes' replies (And of course I saw that message since you Cc'ed me). I can't even find your messages in the "Spam" folder in Thunderbird! Confused, R.H. On 05/12/2018 01:15, Rob L