Re: [Toybox] [PATCH] scan_key: support more terminals.

2019-04-11 Thread David Seikel
> > luckily i suspect in 2019 we mainly want function keys just so we > > can throw them away and get on to the next meaningful keypress! but > > i can easily put this back to one constant per key if you prefer. > > Unfortunately a command line utility doesn't get to _see_ the > function keys, s

[Toybox] weird help spacing

2019-04-11 Thread enh via Toybox
have you noticed that commands with multiple variants (like netcat) get fewer than normal blank lines at the end of their help, and commands with commented-out variants (like mount) get more than normal? rmmod actually does just have an extra blank line in the .c file. but tunctl and umount i can'

Re: [Toybox] alias tar="tar --restrict"

2019-04-11 Thread enh via Toybox
On Thu, Apr 11, 2019 at 5:46 PM Rob Landley wrote: > > On 4/11/19 7:12 PM, enh wrote: > >> Yeah but if their implementation's 20 years old and I had the short option > >> name > >> first... > > > > that would be a stronger argument if you were actually going to POSIX > > with this stuff. the trou

[Toybox] [PATCH] date: use xtzset.

2019-04-11 Thread enh via Toybox
I promised I'd clean this up months ago. Better late than never. --- toys/posix/date.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) From 8d1314c31de2235a5b44eb48bf240b65b5cf28a2 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Thu, 11 Apr 2019 17:47:47 -0700

Re: [Toybox] alias tar="tar --restrict"

2019-04-11 Thread Rob Landley
On 4/11/19 7:12 PM, enh wrote: >> Yeah but if their implementation's 20 years old and I had the short option >> name >> first... > > that would be a stronger argument if you were actually going to POSIX > with this stuff. the trouble is that they _do_... Posix removed "tar" and "cpio" from their

Re: [Toybox] [PATCH] grep: add --line-buffered and fix regular buffering.

2019-04-11 Thread enh via Toybox
On Thu, Apr 11, 2019 at 4:44 PM Rob Landley wrote: > > On 4/11/19 12:18 PM, enh wrote: > > Ping for direction here? I'm happy to implement whichever way you want to > > go. > > > > I think we had: > > > > 1. Don't implicitly flush in all the x* routines, add any missing explicit > > flushes (of w

Re: [Toybox] alias tar="tar --restrict"

2019-04-11 Thread enh via Toybox
On Thu, Apr 11, 2019 at 5:03 PM Rob Landley wrote: > > On 4/11/19 5:52 PM, enh wrote: > >>> (in general the other direction is dangerous too, but in this specific > >>> case i'm pretty sure no-one wants to change tapes on Android or during > >>> an AOSP build --- though you'd be surprised by some

Re: [Toybox] alias tar="tar --restrict"

2019-04-11 Thread Rob Landley
On 4/11/19 5:52 PM, enh wrote: >>> (in general the other direction is dangerous too, but in this specific >>> case i'm pretty sure no-one wants to change tapes on Android or during >>> an AOSP build --- though you'd be surprised by some of the requests we >>> do get from folks who don't value herme

Re: [Toybox] [PATCH] grep: add --line-buffered and fix regular buffering.

2019-04-11 Thread Rob Landley
On 4/11/19 12:18 PM, enh wrote: > Ping for direction here? I'm happy to implement whichever way you want to go. > > I think we had: > > 1. Don't implicitly flush in all the x* routines, add any missing explicit > flushes (of which I expect there will be very few).  > > 2. Don't use the x* routine

Re: [Toybox] alias tar="tar --restrict"

2019-04-11 Thread enh via Toybox
On Thu, Apr 11, 2019 at 3:29 PM Rob Landley wrote: > > On 4/11/19 11:34 AM, enh wrote: > > On Fri, Apr 5, 2019 at 8:44 PM Rob Landley wrote: > >> > >> I just added --restrict to require all the tarball's contents to extract > >> under a > >> single directory, and the obvious way to use it is the

Re: [Toybox] alias tar="tar --restrict"

2019-04-11 Thread Rob Landley
On 4/11/19 11:34 AM, enh wrote: > On Fri, Apr 5, 2019 at 8:44 PM Rob Landley wrote: >> >> I just added --restrict to require all the tarball's contents to extract >> under a >> single directory, and the obvious way to use it is the same as ls --color, >> via >> alias. >> >> $ tar cz linux-4.20

Re: [Toybox] [PATCH] scan_key: support more terminals.

2019-04-11 Thread Rob Landley
On 4/11/19 10:55 AM, enh wrote: > On Sat, Mar 23, 2019 at 4:11 PM Rob Landley wrote: >> >> On 3/23/19 2:44 PM, enh via Toybox wrote: >>> Although we can get away with ignoring termcap/terminfo on the output >>> side by restricting ourselves to generally-supported escape sequences, >> >> There's do

Re: [Toybox] [PATCH] grep: add --line-buffered and fix regular buffering.

2019-04-11 Thread enh via Toybox
Ping for direction here? I'm happy to implement whichever way you want to go. I think we had: 1. Don't implicitly flush in all the x* routines, add any missing explicit flushes (of which I expect there will be very few). 2. Don't use the x* routines as much. On Tue, Feb 26, 2019, 09:57 enh w

Re: [Toybox] alias tar="tar --restrict"

2019-04-11 Thread enh via Toybox
On Fri, Apr 5, 2019 at 8:44 PM Rob Landley wrote: > > I just added --restrict to require all the tarball's contents to extract > under a > single directory, and the obvious way to use it is the same as ls --color, via > alias. > > $ tar cz linux-4.20 l*.txt > ll.tgz > $ tar xvf ../ll.tgz --re

Re: [Toybox] [PATCH] scan_key: support more terminals.

2019-04-11 Thread enh via Toybox
On Sat, Mar 23, 2019 at 4:11 PM Rob Landley wrote: > > On 3/23/19 2:44 PM, enh via Toybox wrote: > > Although we can get away with ignoring termcap/terminfo on the output > > side by restricting ourselves to generally-supported escape sequences, > > There's documentation on this, by the way: > > h