[Toybox] Android sitrep

2019-08-28 Thread enh via Toybox
i guess now's a good time for another sitrep, since i've been out sick all week and so had time to poke at various things, and there's been quite a lot going on: * after the genuine dd bug found by the continuous tests was fixed, i've seen no more test failures there. * md5sum and sha*sum were

Re: [Toybox] [PATCH] find.test: fix test expectation for BSD libcs.

2019-08-28 Thread enh via Toybox
On Wed, Aug 28, 2019 at 4:19 PM Rob Landley wrote: > > On 8/28/19 4:55 PM, enh wrote: > > On Wed, Aug 28, 2019 at 2:44 PM Rob Landley wrote: > >> > >> On 8/26/19 11:20 PM, enh wrote: > >>> this comment had me worried: > >>> > >>> "Tweak DIRTREE_STATLESS so it returns zero stat for any error (I'm

Re: [Toybox] [PATCH]patch: support unified diffs with unusual timestamp formats

2019-08-28 Thread William Haddon
On 08/28/2019 07:21:31 PM, Rob Landley wrote: > On 8/28/19 5:15 PM, William Haddon wrote: > > I'm slightly confused about how the existing code is supposed to > handle > > filenames with tabs followed by digits. > > It doesn't, but I thought it would handle the rest of them. But it > turns out

Re: [Toybox] [PATCH]patch: support unified diffs with unusual timestamp formats

2019-08-28 Thread Rob Landley
On 8/28/19 5:15 PM, William Haddon wrote: > I'm slightly confused about how the existing code is supposed to handle > filenames with tabs followed by digits. It doesn't, but I thought it would handle the rest of them. But it turns out it doesn't because diff -u quotes filenames in that case, so

Re: [Toybox] [PATCH] find.test: fix test expectation for BSD libcs.

2019-08-28 Thread Rob Landley
On 8/28/19 4:55 PM, enh wrote: > On Wed, Aug 28, 2019 at 2:44 PM Rob Landley wrote: >> >> On 8/26/19 11:20 PM, enh wrote: >>> this comment had me worried: >>> >>> "Tweak DIRTREE_STATLESS so it returns zero stat for any error (I'm testing >>> that dev, ino, and blksize are all zero), and fill in

Re: [Toybox] [PATCH]patch: support unified diffs with unusual timestamp formats

2019-08-28 Thread Rob Landley
On 8/28/19 4:44 PM, Rob Landley wrote: > On 8/28/19 3:16 PM, William Haddon wrote: >> This supports patches that have timestamp formats like >> "--- a/libgomp/config/posix/time.c Thu Dec 24 11:24:47 2015 >> -0500" >> which do not begin with a digit. An example is the musl support patches >> for

Re: [Toybox] [PATCH] find.test: fix test expectation for BSD libcs.

2019-08-28 Thread enh via Toybox
On Wed, Aug 28, 2019 at 2:44 PM Rob Landley wrote: > > On 8/26/19 11:20 PM, enh wrote: > > this comment had me worried: > > > > "Tweak DIRTREE_STATLESS so it returns zero stat for any error (I'm testing > > that dev, ino, and blksize are all zero), and fill in file type from > > readdir()" > > >

Re: [Toybox] [PATCH]patch: support unified diffs with unusual timestamp formats

2019-08-28 Thread William Haddon
I'm slightly confused about how the existing code is supposed to handle filenames with tabs followed by digits. On 08/28/2019 05:44:44 PM, Rob Landley wrote: > On 8/28/19 3:16 PM, William Haddon wrote: > > This supports patches that have timestamp formats like > > "---

Re: [Toybox] [PATCH]patch: support unified diffs with unusual timestamp formats

2019-08-28 Thread Rob Landley
On 8/28/19 3:16 PM, William Haddon wrote: > This supports patches that have timestamp formats like > "--- a/libgomp/config/posix/time.cThu Dec 24 11:24:47 2015 > -0500" > which do not begin with a digit. An example is the musl support patches > for GCC 5 at

Re: [Toybox] [PATCH] find.test: fix test expectation for BSD libcs.

2019-08-28 Thread Rob Landley
On 8/26/19 11:20 PM, enh wrote: > this comment had me worried: > > "Tweak DIRTREE_STATLESS so it returns zero stat for any error (I'm testing > that dev, ino, and blksize are all zero), and fill in file type from > readdir()" > > and indeed, this breaks one of the find(1) tests i added. (and is

Re: [Toybox] [PATCH] find.test: fix test expectation for BSD libcs.

2019-08-28 Thread enh via Toybox
i've sent a patch ("[PATCH] Fix find(1) after c26870dab3462c6176936384b090df6b9ba46dee") to fix this bug plus another bug i found in find error reporting while poking about. On Mon, Aug 26, 2019 at 9:20 PM enh wrote: > > On Mon, Aug 26, 2019 at 9:17 PM enh wrote: > > > > On Mon, Aug 26, 2019 at

[Toybox] [PATCH] Fix find(1) after c26870dab3462c6176936384b090df6b9ba46dee.

2019-08-28 Thread enh via Toybox
Unlike ls, find does treat ENOENT specially. Add an extra test (and fix the behavior) for the case of ENOENT for a path provided on the command line --- unlike other ENOENT cases (typically dangling symlinks), ENOENT for a command line argument should report an error. Also remove obsolete `|sed`

[Toybox] [PATCH]patch: support unified diffs with unusual timestamp formats

2019-08-28 Thread William Haddon
This supports patches that have timestamp formats like "--- a/libgomp/config/posix/time.c Thu Dec 24 11:24:47 2015 -0500" which do not begin with a digit. An example is the musl support patches for GCC 5 at https://github.com/GregorR/musl-gcc-patches , which seem to have been generated by