[Toybox] [PATCH] hexedit: fix scrolling on legacy terminals

2019-09-25 Thread Jarno Mäkipää
Thanks for James McMechan for pointing this out. Using esc[1L and esc[1M escapes with cursor jump to 1, 1 to make scrolling effect instead of S and T fixes scrolling inside Linux terminal and tmux -Jarno From 74c1f5e12f1c73a2176a818370e9b9b7a0a2a6dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jarno=

Re: [Toybox] Fwd: hexedit uses VT-420 scroll ctrl sequences which dont work on tty1

2019-09-25 Thread Jarno Mäkipää
L and M escapes seems to work nicely. I will send patch to Rob for hexedit and continue working on vi thank you -Jarno On Thu, Sep 26, 2019 at 7:42 AM James McMechan wrote: > > The console_codes page does not seem to include SD/SU \e[1S/\e[1T. > > I however have used IL/DL \e[1L/\e[1M which ins

[Toybox] [PATCH] ln: -T should allow only 2 arguments

2019-09-25 Thread Jarno Mäkipää
To follow similar behavior than coreutils and busybox with this GNU extension -T should only allow maximum of 2 arguments even when accompanied with -f touch a b ln -sfT a b L I had this fixed in my other patch on list already but Rob added his own commit with -T so this is on top of current ma

Re: [Toybox] Fwd: hexedit uses VT-420 scroll ctrl sequences which dont work on tty1

2019-09-25 Thread James McMechan
The console_codes page does not seem to include SD/SU \e[1S/\e[1T. I however have used IL/DL \e[1L/\e[1M which insert/remove lines at the cursor. e.g. \e[1;1H\e[5L puts 5 blank lines at the top of screen scrolling everything down and \e[1;1H\e[2M deletes the top two lines scrolling everything up.

Re: [Toybox] [PATCH] ln: add -T, use FLAG()

2019-09-25 Thread Jarno Mäkipää
This second patch should fix the -T allow only 2 args All the previous test cases seems to pass. Should write test cases for this. -Jarno On Wed, Sep 25, 2019 at 11:40 PM Ryan Prichard wrote: > > It looks like coreutils and busybox allow only 2 args with -T. Do we need to > diagnose this? > >

Re: [Toybox] [PATCH] ln: add -T, use FLAG()

2019-09-25 Thread Ryan Prichard via Toybox
It looks like coreutils and busybox allow only 2 args with -T. Do we need to diagnose this? touch A B ln -sfT A B L ln: extra operand 'L' busybox ln -sfT A B L ln: -T accepts 2 args max toybox ln -sfT A B L ls -l L lrwxrwxrwx 1 rprichard primarygroup 1 Sep 25 13:38 L -> B With this patch, ln is

[Toybox] [PATCH] ln: add -T, use FLAG()

2019-09-25 Thread Jarno Mäkipää
Added: -T Replaced: & flag_# with FLAG(#) There was feature request on github. Apparently there is some android scripts with ln -sfT -Jarno From ed03f8cdeb5560b9ac7dd40d1ce1ef061b47ab77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jarno=20M=C3=A4kip=C3=A4=C3=A4?= Date: Wed, 25 Sep 2019 23:08:43 +03

Re: [Toybox] Fwd: hexedit uses VT-420 scroll ctrl sequences which dont work on tty1

2019-09-25 Thread Jarno Mäkipää
On Wed, Sep 25, 2019 at 8:23 PM Rob Landley wrote: > > On 9/24/19 1:18 AM, Jarno Mäkipää wrote: > > Hi > > > > I now tested to run hexedit in tmux: downscroll works but upscroll does > > not... > > Well we might say its tmux fault, but lots of people use tmux nowadays. > > And this behavior seeme

Re: [Toybox] Fwd: hexedit uses VT-420 scroll ctrl sequences which dont work on tty1

2019-09-25 Thread David Seikel
On Wed, 25 Sep 2019 12:24:13 -0500 Rob Landley said : > On 9/24/19 1:18 AM, Jarno Mäkipää wrote: > > Hi > > > > I now tested to run hexedit in tmux: downscroll works but upscroll > > does not... Well we might say its tmux fault, but lots of people > > use tmux nowadays. And this behavior seemed to

Re: [Toybox] Fwd: hexedit uses VT-420 scroll ctrl sequences which dont work on tty1

2019-09-25 Thread Rob Landley
On 9/24/19 1:18 AM, Jarno Mäkipää wrote: > Hi > > I now tested to run hexedit in tmux: downscroll works but upscroll does not... > Well we might say its tmux fault, but lots of people use tmux nowadays. > And this behavior seemed to be same in framebuffer console and xterms... I have a todo item