Re: [Toybox] How can I contribute

2019-10-17 Thread Rob Landley
On 10/17/19 3:14 PM, Ryan Prichard wrote: > I thought the order was the other way around (base character, then combining > character). I tested it with: The downside of "I had it backwards" is when you _do_ start to remember the correct way you reverse it again... Rob

Re: [Toybox] [PATCH] ls: Ensure file names are separated by 2 spaces

2019-10-17 Thread Rob Landley
I have various torture test utf8 in test/files/utf8. To see a trailing combining character eat a following space, you can do: $ head -c 5 tests/files/utf8/test3.txt; echo ' ' Or $ head -c 5 tests/files/utf8/test1.txt; echo 'X' The problem is, it's easy to see visually, but I'm not quite sure ho

Re: [Toybox] Android sitrep

2019-10-17 Thread Denys Nykula
> the tar "no ../ files outside this directory" check is > false positiving on "./" for some reason, gotta track that down. Here's a reproducible toy tar crash, might or might not be connected. git clone https://github.com/landley/toybox wget http://musl.cc/x86_64-linux-musl-native.tgz rm -r root

Re: [Toybox] How can I contribute

2019-10-17 Thread Ryan Prichard via Toybox
On Wed, Oct 16, 2019 at 3:27 PM Rob Landley wrote: > Right now toys/posix/ls.c only puts one space between filenames in -C or > -x mode > (which is the default output), and I have a todo item to increase that to 2 > spaces (which is what other implementations do). The reason is I > misunderstood

Re: [Toybox] What am I doing wrong with ndk-r20?

2019-10-17 Thread enh via Toybox
r21beta1 is out now, if you're looking for new things to break :-) https://android-developers.googleblog.com/2019/10/introducing-ndk-r21-our-first-long-term.html On Wed, Oct 9, 2019 at 9:27 AM enh wrote: > > On Wed, Oct 9, 2019 at 9:08 AM Rob Landley wrote: > > > > On 10/7/19 3:54 PM, enh wrote

Re: [Toybox] How can I contribute

2019-10-17 Thread Jarno Mäkipää
On Thu, Oct 17, 2019 at 1:27 AM Rob Landley wrote: > > On 10/14/19 3:07 PM, Denys Nykula wrote: > >> saw one of the Toybox talks and wanted to see how I could contribute > > > > Completing landley.net/toybox/cleanup.html on toys/pending/{dhcp,route}.c > > to help them out of pending would be most

Re: [Toybox] [PATCH] vi: changes to buffer drawing

2019-10-17 Thread Jarno Mäkipää
I dare to say that crunch_str calculates width right already. if i do void hello_main(void) { char* str = "lll\xcc\xb4\xcc\x97\n"; char* end = str; int width; width = crunch_str(&end, 3, stdout, 0,0); xprintf("\nwidth: %d\n",width); end = str; width = crunch_str(&end, 3, 0, 0,0);

Re: [Toybox] [PATCH] ls: Ensure file names are separated by 2 spaces

2019-10-17 Thread enh via Toybox
new tests? (including the difficult combining-character case?) On Thu, Oct 17, 2019 at 8:35 AM Andrew Ilijic wrote: > > From d4c03b672d8b18f7ce021e4fcb02e8bb86f38f5f Mon Sep 17 00:00:00 2001 > From: Andrew Ilijic > Date: Thu, 17 Oct 2019 11:03:19 -0400 > Subject: [PATCH] ls: Ensure file names ar

[Toybox] [PATCH] ls: Ensure file names are separated by 2 spaces

2019-10-17 Thread Andrew Ilijic
>From d4c03b672d8b18f7ce021e4fcb02e8bb86f38f5f Mon Sep 17 00:00:00 2001 From: Andrew Ilijic Date: Thu, 17 Oct 2019 11:03:19 -0400 Subject: [PATCH] ls: Ensure file names are separated by 2 spaces We need two spaces between filenames because that is the convention followed by other implementations.

Re: [Toybox] How can I contribute

2019-10-17 Thread Andrew Ilijic
Thank you Rob, I'll start by taking a look at the `ls` command and let you know how I make out. On Wed, Oct 16, 2019 at 6:27 PM Rob Landley wrote: > > On 10/14/19 3:07 PM, Denys Nykula wrote: > >> saw one of the Toybox talks and wanted to see how I could contribute > > > > Completing landley.net