Re: [Toybox] [PATCH] cpio: support reading concatenated cpio files.

2021-04-17 Thread Rob Landley
On 4/17/21 8:40 AM, Yi-yo Chiang wrote: > On Sat, Apr 17, 2021 at 7:32 PM Rob Landley > wrote: > > On 4/17/21 4:43 AM, Yi-yo Chiang wrote: > > On Sat, Apr 17, 2021 at 2:56 PM Rob Landley > >

Re: [Toybox] [PATCH] cpio: support reading concatenated cpio files.

2021-04-17 Thread Yi-yo Chiang via Toybox
On Sat, Apr 17, 2021 at 7:32 PM Rob Landley wrote: > On 4/17/21 4:43 AM, Yi-yo Chiang wrote: > > On Sat, Apr 17, 2021 at 2:56 PM Rob Landley > > wrote: > > > > On 4/16/21 1:44 PM, Yi-yo Chiang wrote: > > > I'm not sure what Elliot's goal is? I assume he's trying

Re: [Toybox] [PATCH] cpio: support reading concatenated cpio files.

2021-04-17 Thread Rob Landley
On 4/17/21 4:43 AM, Yi-yo Chiang wrote: > On Sat, Apr 17, 2021 at 2:56 PM Rob Landley > wrote: > > On 4/16/21 1:44 PM, Yi-yo Chiang wrote: > > I'm not sure what Elliot's goal is? I assume he's trying to extract a > > concatenated ramdisk, and I still see a pro

Re: [Toybox] [PATCH] cpio: support reading concatenated cpio files.

2021-04-17 Thread Rob Landley
On 4/16/21 5:20 PM, enh wrote: > funnily enough (or perhaps not, because yochiang knows a lot more about cpio > than i do...) it looks like the AOSP build is broken because of trailing > NULs... Do you mean toybox cpio isn't consuming the output of gnu/cpio? (It consumed its own output in the tes

Re: [Toybox] [PATCH] cpio: support reading concatenated cpio files.

2021-04-17 Thread Yi-yo Chiang via Toybox
> > > > i'll chase up the person using `toybox cpio` and move them over to the > hermetic > > prebuilt build toybox later. for now i'll try to reproduce this locally > and see > > what the trouble is... > > Is this a _new_ failure, or is this a failure of the concatenated files it > didn't handle b

Re: [Toybox] [PATCH] cpio: support reading concatenated cpio files.

2021-04-17 Thread Yi-yo Chiang via Toybox
On Sat, Apr 17, 2021 at 2:56 PM Rob Landley wrote: > On 4/16/21 1:44 PM, Yi-yo Chiang wrote: > > I'm not sure what Elliot's goal is? I assume he's trying to extract a > > concatenated ramdisk, and I still see a problem in the current solution. > > > > The buffer-format > > ( > https://www.kernel.

Re: [Toybox] [PATCH] cpio: support reading concatenated cpio files.

2021-04-17 Thread Rob Landley
On 4/16/21 3:48 PM, enh wrote: > On Fri, Apr 16, 2021 at 11:44 AM Yi-yo Chiang > wrote: > > I'm not sure what Elliot's goal is? I assume he's trying to extract a > concatenated ramdisk, and I still see a problem in the current solution.  > > > oops, i was goi