Re: [Toybox] You've seen the /dev/random shenanigans, right?

2023-09-19 Thread enh via Toybox
On Tue, Sep 19, 2023 at 2:48 PM Eric Biggers wrote: > > On Tue, Sep 19, 2023 at 12:44:17PM -0700, enh wrote: > > > now writing to /dev/random not only doesn't credit entropy (so it > > > still blocks) > > It's always been like that, at least back to the earliest git commit in Linux > history

Re: [Toybox] You've seen the /dev/random shenanigans, right?

2023-09-19 Thread enh via Toybox
On Tue, Sep 19, 2023 at 4:07 AM Rob Landley wrote: > > Looks like the kernel devs rewrote stuff in 2022 to make it more dependent on > systemd, and now writing to /dev/random not only doesn't credit entropy (so it > still blocks) but has an arbitrary delay about even mixing the data in. > >

Re: [Toybox] [PATCH] devmem: Fix 8 byte wide writes

2023-09-19 Thread Michael Shavit via Toybox
LGTM! Thanks :) . On Tue, Sep 19, 2023 at 4:34 AM Rob Landley wrote: > > On 9/18/23 18:08, Michael Shavit wrote: > > On Thu, Aug 31, 2023 at 3:57 AM Rob Landley wrote: > >> +unsigned long long atollu(char *str) > >> +{ > >> + char *end = str; > >> + unsigned long long llu = strtoul(str, ,

Re: [Toybox] Test suite gripe du jour.

2023-09-19 Thread Rob Landley
Wow I have a lot of old reply windows buried under other windows... On 8/7/23 11:06, enh wrote: >> P.S. I didn't respond to Elliott's last email about testing because I didn't >> know what to say. "I want absolutely everything because I have a dedicated >> staff >> to weed out false positives"

Re: [Toybox] [PATCH] devmem: Fix 8 byte wide writes

2023-09-19 Thread Rob Landley
On 9/18/23 18:08, Michael Shavit wrote: > On Thu, Aug 31, 2023 at 3:57 AM Rob Landley wrote: >> +unsigned long long atollu(char *str) >> +{ >> + char *end = str; >> + unsigned long long llu = strtoul(str, , 0); > > Sorry I didn't notice this earlier, but hort...@google.com pointed out > that

[Toybox] You've seen the /dev/random shenanigans, right?

2023-09-19 Thread Rob Landley
Looks like the kernel devs rewrote stuff in 2022 to make it more dependent on systemd, and now writing to /dev/random not only doesn't credit entropy (so it still blocks) but has an arbitrary delay about even mixing the data in. https://lwn.net/Articles/889452/ Apparently busybox copied code