Re: [Toybox] tsort

2023-10-11 Thread enh via Toybox
On Wed, Oct 11, 2023 at 2:26 PM Ray Gardner wrote: > > On Oct 11, 2023 at 2:42 AM Rob Landley wrote: > > On 10/10/23 17:46, Ray Gardner wrote: > > > After seeing your comments about tsort in your blog, I thought about > > > trying > > > to implement Knuth's algorithm, > > > > Is that the

Re: [Toybox] tsort

2023-10-11 Thread Ray Gardner
On Oct 11, 2023 at 2:42 AM Rob Landley wrote: > On 10/10/23 17:46, Ray Gardner wrote: > > After seeing your comments about tsort in your blog, I thought about trying > > to implement Knuth's algorithm, > > Is that the recommended algorithm here? https://man.openbsd.org/tsort mentions Knuth's

[Toybox] tsort

2023-10-11 Thread scsijon
I knew it from ibm mainframes and FEP's for aix, try this url for a simple explanation, it's pretty basic what it does. https://www.ibm.com/docs/da/aix/7.3?topic=t-tsort-command scsijon ___ Toybox mailing list Toybox@lists.landley.net

Re: [Toybox] [PATCH] Addition of the 'g' command to vi.c

2023-10-11 Thread enh via Toybox
On Wed, Oct 11, 2023 at 2:08 AM Rob Landley wrote: > > On 10/10/23 12:52, enh wrote: > >> In theory ASAN should be able to spot that one! In practice, if it's a > >> local > >> variable on the stack, not so much. > > > > you can add `-ftrivial-auto-var-init=pattern` to your CFLAGS. > > $

Re: [Toybox] vi 'b' command broken

2023-10-11 Thread enh via Toybox
On Wed, Oct 11, 2023 at 3:22 AM Rob Landley wrote: > > On 10/6/23 05:05, Rob Landley wrote: > > Apparently the widest unicode characters are: > > > > 1. ﷽ > > > > 2. ␫ > > > > 3. ∙ > > > > 4. ⸻ > > > > 5. ꧅ > > > > The first 4 of which xfce's terminal does NOT like. And thunderbird fits the > >

Re: [Toybox] tsort

2023-10-11 Thread enh via Toybox
On Wed, Oct 11, 2023 at 1:42 AM Rob Landley wrote: > > On 10/10/23 17:46, Ray Gardner wrote: > > After seeing your comments about tsort in your blog, I thought about trying > > to > > implement Knuth's algorithm, > > Is that the recommended algorithm here? > > $ grep -i knuth

Re: [Toybox] vi 'b' command broken

2023-10-11 Thread Rob Landley
On 10/6/23 05:05, Rob Landley wrote: > Apparently the widest unicode characters are: > > 1. ﷽ > > 2. ␫ > > 3. ∙ > > 4. ⸻ > > 5. ꧅ > > The first 4 of which xfce's terminal does NOT like. And thunderbird fits the > first one in 3 columns while vim's giving it... 9 I think. And trying to add a

Re: [Toybox] [PATCH] Addition of the 'g' command to vi.c

2023-10-11 Thread Rob Landley
On 10/10/23 12:52, enh wrote: >> In theory ASAN should be able to spot that one! In practice, if it's a local >> variable on the stack, not so much. > > you can add `-ftrivial-auto-var-init=pattern` to your CFLAGS. $ CFLAGS="-ftrivial-auto-var-init=pattern" ASAN=1 make clean defconfig tests ...

Re: [Toybox] tsort

2023-10-11 Thread Rob Landley
On 10/10/23 17:46, Ray Gardner wrote: > After seeing your comments about tsort in your blog, I thought about trying to > implement Knuth's algorithm, Is that the recommended algorithm here? $ grep -i knuth busybox/coreutils/tsort.c $ grep -ir knuth busybox

Re: [Toybox] ASan freaks out when using tsort in multicall binaries

2023-10-11 Thread Rob Landley
On 10/9/23 19:53, Oliver Webb wrote: >> I tested this. If I build toybox sed without ASAN the 1 megabyte search and >> replace completes in 0.15 seconds. If I build it with ASAN, it takes 29.35 >> seconds. The gcc address sanitizer is slowing sed down 200 times. > > Huh, now sed passes it's tests