Re: [Toybox] [PATCH] readelf: decode RISCV_ATTRIBUTES sections.

2023-11-03 Thread enh via Toybox
(to be clear: if you want the arm32 attribute decoding too, i'm happy to write that. just be aware that it's going to be a big switch rather than the regular "odd or even?" for riscv, and there are quite a lot of arm32 attributes: https://llvm.org/doxygen/ARMAttributeParser_8cpp_source.html) On

[Toybox] [PATCH] readelf: decode RISCV_ATTRIBUTES sections.

2023-11-03 Thread enh via Toybox
arc, arm32, and csky all have these sections too, but I've never seen arc or csky in real life, and arm32 isn't as regular as riscv's "odd vs even" decoding, so we should probably wait until someone actually needs to decode those before adding the decoder? --- toys/other/readelf.c | 88

Re: [Toybox] tsort regrets

2023-11-03 Thread Rob Landley
On 11/2/23 18:00, Ray Gardner wrote: > Rob, feel free to post your reply on the list or your blog or wherever. > > As to the hash code, the only part I've taken from Python's > implementation is the probe sequence So... NOT the "linked lists descending from each hash bucket" approach then. >

[Toybox] Fwd: tsort regrets

2023-11-03 Thread Rob Landley
Got permission to forward it to the list... Forwarded Message Subject: Re: tsort regrets Date: Thu, 2 Nov 2023 13:47:05 -0500 From: Rob Landley To: Ray Gardner On 11/1/23 10:57, Ray Gardner wrote: > Hi Rob, > > I hope you are feeling better today. Better is a relative term.

Re: [Toybox] [PATCH] microcom: simple menu, new "paste file" functionality.

2023-11-03 Thread enh via Toybox
On Fri, Nov 3, 2023 at 6:58 AM Rob Landley wrote: > > Blah, forgot to click "send" and let the window get buried... > > On 10/28/23 12:18, enh wrote: > > On Sat, Oct 28, 2023 at 12:29 AM Rob Landley wrote: > >> > >> On 10/25/23 19:48, enh via Toybox wrote: > >> > Rather than take up yet another

Re: [Toybox] [PATCH] microcom: move from e[x]it to [q]uit.

2023-11-03 Thread enh via Toybox
On Fri, Nov 3, 2023 at 7:22 AM Rob Landley wrote: > > On 11/2/23 16:56, enh via Toybox wrote: > > This frees up 'x' for xmodem transfers later. > > Q to quit makes sense, adding xmodem... do you have an xmodem protocol > extension > in mind that doesn't pad the last packet up to 128 bytes? that

Re: [Toybox] [PATCH] microcom: move from e[x]it to [q]uit.

2023-11-03 Thread Rob Landley
On 11/3/23 09:27, Rob Landley wrote: >> and make it clear what new options >> should look like). > > I'd rather not apply the patch as is because of the above commit comment > grumbles, but don't object to code change itself. Should I switch the -64 to > &31 > while I'm there? Because the

Re: [Toybox] [PATCH] microcom: move from e[x]it to [q]uit.

2023-11-03 Thread Rob Landley
On 11/2/23 16:56, enh via Toybox wrote: > This frees up 'x' for xmodem transfers later. Q to quit makes sense, adding xmodem... do you have an xmodem protocol extension in mind that doesn't pad the last packet up to 128 bytes? What xmodem command are you going to run at the other end to consume

Re: [Toybox] [PATCH] microcom: simple menu, new "paste file" functionality.

2023-11-03 Thread Rob Landley
Blah, forgot to click "send" and let the window get buried... On 10/28/23 12:18, enh wrote: > On Sat, Oct 28, 2023 at 12:29 AM Rob Landley wrote: >> >> On 10/25/23 19:48, enh via Toybox wrote: >> > Rather than take up yet another key for the new functionality, I've moved >> > everything to a

[Toybox] [PATCH] file: add arm32 ELF flag decoding.

2023-11-03 Thread enh via Toybox
Also fix finding the flags in the ELF header for riscv32; the existing code only worked for 64-bit ELF files. --- lib/elf.c | 7 +-- tests/file.test | 2 +- toys/posix/file.c | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) From c7a4bcbe819b8d3e50d42bd2bc3ff80259713586 Mon

Re: [Toybox] [PATCH] riscv: decode ELF header e_flags.

2023-11-03 Thread Rob Landley
On 11/1/23 18:45, enh wrote: > do you want a patch with the arm32 flags too? Yes please. I applied your patch and then moved stuff to elf.c and tidied it a little. Could you confirm the riscv flags still print right with the new trick? I haven't got a test binary here. (I should break down and

Re: [Toybox] [PATCH] riscv: decode ELF header e_flags.

2023-11-03 Thread enh via Toybox
On Thu, Nov 2, 2023 at 12:06 PM Rob Landley wrote: > > On 11/1/23 18:45, enh wrote: > > do you want a patch with the arm32 flags too? > > Yes please. (sent.) > I applied your patch and then moved stuff to elf.c and tidied it a > little. Could you confirm the riscv flags still print right with

[Toybox] [PATCH] microcom: move from e[x]it to [q]uit.

2023-11-03 Thread enh via Toybox
This frees up 'x' for xmodem transfers later. Also, if we're going to have a single line of help, switch to the more common format for such prompts (and, if nothing else, fix the previously inconsistent spacing between options and make it clear what new options should look like). ---