Thomas wrote:
> > Wait, your git --describe is finding a random tarball in some other
> > directory?
> >
> > That's really broken.
> ...
> > That's a pretty clear yocto bug (one I can't reproduce), but if you're
> > adding a workaround for this yocto bug the easy thing to do is keep
> > GITHASH if
Just commenting on this:
Rob Landley wrote:
> As for the lib/portability.h patch: FreeBSD doesn't have features.h, but
> Linux and MacOS X agree on that one? Odd. Speaking of which, we have
> __FreeBSD__ without #including features.h?
The compiler might define it similarly to how it defines __lin
Rich Felker wrote:
...
> > glibc is the process of deprecating, and musl/uClibc would follow suit,
> > if not just drop the include altogether.
>
> musl has never had the issue. :-) because we don't implicitly include
> sys/sysmacros.h at all. The set of programs that have any use for
> these macr
Lipi C. H. Lee wrote:
> implement simple 'wget' and port name can be specified in URL if default
> port 80 is not used.
> It may be added to toys/pending directory.
Thanks for your submission!
Some comments below.
In general, try simplifying the error messages:
http://lists.landley.net/pipermai
---
Maybe it is better to have the test somewhere else.
---
toys/posix/ls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/toys/posix/ls.c b/toys/posix/ls.c
index 15796ff..3346968 100644
--- a/toys/posix/ls.c
+++ b/toys/posix/ls.c
@@ -539,7 +539,7 @@ void ls_main(void)
for
enh wrote:
> On Mon, May 4, 2015 at 10:57 AM, Felix Janda wrote:
[..]
> > I just wanted to say that not everything is yet fixed. For example
> > 'ls --color' does not work at all. (Seems to be related to the option
> > parsing.)
>
> works for me. are
Rob Landley wrote:
> On 05/02/2015 02:54 PM, enh wrote:
> > anyone else having trouble with "make menuconfig"? getprop and setprop
> > aren't showing up for me, and i don't see where to set
> > CONFIG_TOYBOX_ON_ANDROID and generated/mkflags segfaults if i have ls
> > configured and...
> >
> > actu
Rob Landley wrote:
> On 03/28/2015 04:31 PM, Felix Janda wrote:
> > ---
> > toys/posix/head.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/toys/posix/head.c b/toys/posix/head.c
> > index 42f945b..8e77b01 100644
> >
Rob Landley wrote:
> On 03/28/2015 04:31 PM, Felix Janda wrote:
> > ---
> > toys/posix/head.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/toys/posix/head.c b/toys/posix/head.c
> > index 42f945b..8e77b01 100644
> >
This seems to be a bug in musl which will be fixed in musl-1.1.8.
Felix
___
Toybox mailing list
Toybox@lists.landley.net
http://lists.landley.net/listinfo.cgi/toybox-landley.net
---
toys/posix/head.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/toys/posix/head.c b/toys/posix/head.c
index 42f945b..8e77b01 100644
--- a/toys/posix/head.c
+++ b/toys/posix/head.c
@@ -56,6 +56,7 @@ void head_main(void)
if (arg && *arg == '-' && arg[1]) {
TT.line
$ answer=42
$ var=$(for i in $(seq $answer); do printf a; done)
$ printf "%s\n\n" $var > file
$ toybox grep -x $var file
aa
Segmentation fault
I haven't yet investigated the cause.
42 is the minimal value for the segfault to trigger.
Possibly relevant: I'
David Halls wrote:
> I'm trying to compile libiconv. It has this in its configure script:
>
> sed -e '/^func_dirname ()$/,/^} # func_dirname /c\
> func_dirname ()\
> {\
> \case ${1} in\
> \ */*) func_dirname_result="${1%/*}${2}" ;;\
> \ * ) func_dirname_result="${3}" ;;\
> \es
---
toys/other/inotifyd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/toys/other/inotifyd.c b/toys/other/inotifyd.c
index f2e11ca..86f1a67 100644
--- a/toys/other/inotifyd.c
+++ b/toys/other/inotifyd.c
@@ -55,7 +55,6 @@ void inotifyd_main(void)
if (!masks) mask = 0xfff; // default to
Rob Landley wrote:
> On 01/08/2015 03:38 PM, Felix Janda wrote:
> > sed doesn't allow embedded newlines in the replacement for s///, e.g.
> >
> > s/walrus/wal\
> > rus/
>
> Indeed, that's the next sed bug I'm wrestling with right now.
>
> &g
sed doesn't allow embedded newlines in the replacement for s///, e.g.
s/walrus/wal\
rus/
It is not obvious to me how to fix this. There is some code for dealing
with line continuations but I don't see how to use it.
Felix
___
Toybox mailing list
Toybox
Rob Landley wrote:
[..]
> I believe the toybox behavior is right?
>
> We can simplify the above test by removing the p; entries that don't add
> a line to the output:
>
> echo -ne '1\n2\n3\n4\n' | sed -n '1{N;N;d};2,3p;4p'
>
> Toybox just prints one 4, and gnu prints two of them. The differenc
Rob Landley wrote:
> Clarification received from The Austin Group.
>
> (Unfortunately the PDF he mentions costs $2500, and is thus completely
> irrelevant in 2014.)
It also seems to be rendered correctly on the POSIX man page.
https://www.kernel.org/pub/linux/docs/man-pages/man-pages-posix/man-p
See the attached patch. Now all du tests are passed.
Felix
# HG changeset patch
# User Felix Janda
# Date 1411230095 -7200
# Sat Sep 20 18:21:35 2014 +0200
# Node ID edb1ee770843fb2528e42a77d40fbbdbc96e56ca
# Parent 434c4ae19f0559ab3ba6cd3d0a288b44c3c23949
Fix du test: du symlink ->
Isaac Dunham wrote:
[..]
> A trickier bug is that rm -r dir will skip dir, saying
> "rm: dir: is a directory"
> I guess the fix involves rm -r calling rmdir instead of unlink.
unlinkat() also removes directories when given AT_REMOVEDIR.
The following patch makes rm pass the tests and it still ask
luck...@vp.pl wrote:
[..]
> getty.c requires sys/ttydefaults.h. Error of my compilation:
>
> toys/pending/getty.c:168:29: error: 'CERASE' undeclared (first use in
> this function)
>
> The CERASE macro and more similar macros just are defined at
> sys/ttydefaults.h in
> musl libc. This header fi
4096)
do
printf "$iso" >> iso
printf "$utf" >> utf
done
testing "iconv" "iconv -f iso-8859-1 iso" "$(cat utf)" "" ""
testing "iconv -c" "iconv -cs -f utf-8 iso" "a" "" ""
Rob Landley wrote:
> On 04/13/14 17:18, Felix Janda wrote:
> > Rob Landley wrote:
[..]
> >> Really the only interesting errno case from iconv is illegal sequence.
> >> The rest just say "ran out of input" or "ran out of output" which is
> >>
Rob Landley wrote:
> On 04/13/14 04:37, Felix Janda wrote:
> > Isaac Dunham wrote:
> > [..]
> >> locale and iconv were already triaged.
> > [..]
> >
> > iconv is actually something I'm missing on my current musl based system.
> > Attached i
Isaac Dunham wrote:
[..]
> locale and iconv were already triaged.
[..]
iconv is actually something I'm missing on my current musl based system.
Attached is a simple version using the libc's iconv.
Cheers,
Felix
/* iconv.c - Convert character encoding
*
* Copyright 2014 Felix Jan
Rob Landley wrote:
> Taking the remaining holiday time to close old reply windows and such.
> I've ahd this one open a while... :)
>
> On 09/06/2013 05:35:27 PM, Felix Janda wrote:
[...]
> > > Are we normally blocking a lot of signals in other commands? Using
> &
Rob Landley wrote:
[...]
> D) Full of unicode characters where multiple input bytes become one
> output character. (I am assuming fixed width font even for unicode; any
> non-english speaker think that's a really bad assumption?)
A unicode character can consume 0, 1 or 2 columns on the termina
Ashwini Sharma wrote:
> Hi Rob, All,
>
> Attached is the TFTPD implementation.
> Add it to hg, if you find it fine.
>
> Let me know for any comments/improvements.
>
> -Ashwini
Thanks for your submission. Some comments sprinkled into the code below.
Felix
> /* tftpd.c - TFTP server.
> *
> *
Rob Landley wrote:
> Catching up on email while waiting at the airport. (Ohio Linuxfest!)
>
> On 09/06/2013 04:48:10 PM, Felix Janda wrote:
> > Rob Landley wrote:
> > > What The Hurd implements is not. Those religious fanatics are simply
> > > not relevant, exce
Rob Landley wrote:
> On 09/10/2013 04:22:41 PM, Felix Janda wrote:
> > Rob Landley wrote:
> > > And yet a call to pselect needs its own sigprocmask() call as setup?
> > > So... why are we using pselect again?
> >
> > Didn't I say so? Before the call to
Ashwini Sharma wrote:
> On Wed, Sep 11, 2013 at 5:30 AM, Felix Janda wrote:
>
> > Ashwini Sharma wrote:
[...]
> > > Didn't use show_help(), as this doesn't exit whereas an exit is intended
> > > for route.
> > > may be show_help() can
Rob Landley wrote:
> On 09/01/2013 08:54:27 AM, Felix Janda wrote:
> > diff -r 587b7572aac2 -r 752d22ece0fe lib/lib.h
> > --- a/lib/lib.h Sun Sep 01 15:13:58 2013 +0200
> > +++ b/lib/lib.h Sun Sep 01 15:25:08 2013 +0200
> > @@ -201,4 +201,7 @@
> &
Ashwini Sharma wrote:
> On Sat, Sep 7, 2013 at 11:47 PM, Isaac wrote:
>
> > On Mon, Sep 02, 2013 at 11:15:14AM +0900, Ashwini Sharma wrote:
> > > HI Rob & list,
> > >
> > > Attached is the patch for _route_ command. It does display, add and del
> > > functions for routing tables.
> > > Have a l
> > >// If lseek() doesn't work on this stream, return now.
> > > - if (pos<0) return 0;
> > > + if (pos == -1) return 0;
> >
> > And yet you compare it with a negative. Maybe the bit patterns work
> > out, but I'm uncomfortable with that. I can see a compiler optimizing
> > this out sim
Rob Landley wrote:
> On 08/31/2013 05:53:09 AM, Felix Janda wrote:
> > This should now hopefully fix the earlier segfaults.
> >
> > In the case that lseek doesn't work and we count from the end
> > the algorithms for tail -n and tail -c are now more separate.
&g
Rob Landley wrote:
> On 09/01/2013 08:54:27 AM, Felix Janda wrote:
> > Both syslogd and dhcpd wait for sockets, signals or a timeout.
> > Currently,
> > they use select() with its timeout to listen to the sockets and a
> > self-pipe for the signals.
> >
> >
Just commenting to selected passages.
Rob Landley wrote:
> On 08/30/2013 09:01:30 AM, Jacek Bukarewicz wrote:
[...]
>
> > - I believe that in mkdir.c line 60 the intent was to check if
> > flag "p" is not set.
I believe Jacek was talking about line 57, my bug from commit 763 you
noticed b
not run
in the foreground syslogd will daemonize() again when restarting. Could
one detect in daemonize() whether daemonizing is necessary?
Felix
# HG changeset patch
# User Felix Janda
# Date 1378041908 -7200
# Node ID 752d22ece0fe3fa9763fd0b6e231e653cc173890
# Parent 587b7572aac2a649885034581
# HG changeset patch
# User Felix Janda
# Date 1378041238 -7200
# Node ID 587b7572aac2a64988503458155e1f2546672525
# Parent 3cd61d16aabec82505da96a142663cedbba8d12a
fix for xpidfile()
diff -r 3cd61d16aabe -r 587b7572aac2 lib/xwrap.c
--- a/lib/xwrap.c Sat Aug 31 12:30:41 2013 +0200
+++ b
es. They behave differently when a file occurs on the command
line more than once.
# HG changeset patch
# User Felix Janda
# Date 1377945041 -7200
# Node ID 3cd61d16aabec82505da96a142663cedbba8d12a
# Parent 9a059e9b3a17a372fc8b225f512af57c72f4eeaa
tail: Some fixes
- Rewrite most of the no
g network logging. If it can't open a usual
logging file, it opens /dev/console instead.
Is there a system behind this? How about just failing when
something goes wrong before entering the select loop? Do we care
about cleaning up the socket files when we crash?
# HG changeset patch
# U
Rob Landley wrote:
> On 08/24/2013 05:20:06 AM, Felix Janda wrote:
[...]
> > If none of these have been applied yet, I could prepare new patches
> > which don't leave the toy broken in between them.
>
> I like the incremental nature of it, but I'm still not sure wh
patches
which don't leave the toy broken in between them.
# HG changeset patch
# User Felix Janda
# Date 1377338685 -7200
# Node ID d177bfe52a4b94b4d24806c0b3b9423d0e55b53f
# Parent 378ab7bde3df8fc8de3e3b3ec3d2bd665610ea37
syslogd: cleanup
- fix bugs in previous cleanups
- remove config f
# HG changeset patch
# User Felix Janda
# Date 1377291029 -7200
# Node ID 378ab7bde3df8fc8de3e3b3ec3d2bd665610ea37
# Parent 42d4b68e3490ab722c637d6d211a18454deb450d
syslogd: stop abusing arg_list
diff -r 42d4b68e3490 -r 378ab7bde3df toys/pending/syslogd.c
--- a/toys/pending/syslogd.cFri Aug
# HG changeset patch
# User Felix Janda
# Date 1377289195 -7200
# Node ID 42d4b68e3490ab722c637d6d211a18454deb450d
# Parent 63b8e54d2c6f72064afc9e469f2c692cffd33ec4
syslogd: cleanup
- simplify resolveconfig() -> now logger_lookup is also used in syslogd.c
- inline addrfds
- small cosmeti
Rob Landley wrote:
> On 08/20/2013 12:29:08 PM, Felix Janda wrote:
> > Rob Landley wrote:
> > > On 08/19/2013 02:26:55 PM, Felix Janda wrote:
> > > > Hi,
> > > >
> > > > I saw the comment in changeset 1017 on possible bugs in
# HG changeset patch
# User Felix Janda
# Date 1377113085 -7200
# Node ID 8d575549fe192e2c1ec2da977bec88cd1433c411
# Parent 97383e221a4a8b8d73a104a89858b6ea361de6fb
syslogd: cleanup
- remove flag macros
- remove some unecessary gotos
- inline open_udp_socks() and getport()
- simplify resulting
# HG changeset patch
# User Felix Janda
# Date 1377033348 -7200
# Node ID c8e6b5f10c57bcca7859b4c2891dfdf346ecac6d
# Parent f9271a80fedc23b91559f0527da8e9c22d152b5d
syslogd: cleanup
- Remove structure fd_pair so that sigfd can go into GLOBALS
- Remove struct typedefs
- Inline setup_signal
Rob Landley wrote:
> On 08/18/2013 11:55:22 AM, Felix Janda wrote:
> > Rob Landley wrote:
> > > On 08/10/2013 04:22:58 PM, Felix Janda wrote:
> > > > Right now syslogd.c contains code from declaring
> > the
> > > > arrays
> > > > prior
Rob Landley wrote:
> On 08/19/2013 02:26:55 PM, Felix Janda wrote:
> > Hi,
> >
> > I saw the comment in changeset 1017 on possible bugs in GNU grep.
> >
> > The failing tests are for me:
> >
> > testing "grep -vo" "grep -vo one inpu
Felix Janda wrote:
[...]
> So how about the following hack?
>
> Keep them in separate files. Have one common config symbol, tear everything
> out of logger.c but logger_main, declare SYSLOG_NAMES in syslogd.c, put
> something like the current lookup() in logger.c to syslogd.c and m
Hi,
I saw the comment in changeset 1017 on possible bugs in GNU grep.
The failing tests are for me:
testing "grep -vo" "grep -vo one input" "two\nthree\n" "onetwoonethreeone\n" ""
testing "grep -Fx ''" "grep -Fx '' input" "one one one\n" "one one one\n" ""
testing "grep -F -e blah -e ''" "grep -
Rob Landley wrote:
> On 06/22/2013 02:32:12 AM, Felix Janda wrote:
> > > > > If you split an empty file, does it create one empty output
> > file,
> > > > or no
> > > > > output files?
[..]
> > Maybe file a defect at austingroupbugs?
>
Rob Landley wrote:
> On 08/10/2013 04:22:58 PM, Felix Janda wrote:
> > Right now syslogd.c contains code from declaring the
> > arrays
> > prioritynames and facilitynames, which map human readable strings to
> > numerical ids. logger.c contains very similar array defi
Right now syslogd.c contains code from declaring the arrays
prioritynames and facilitynames, which map human readable strings to
numerical ids. logger.c contains very similar array definitions.
declares these arrays only when SYSLOG_NAMES has been
#defined. The structure with the descriptive nam
Hello,
below a patch doing the inlining as suggested by Isaac and
another patch which moves the common functionality for
daemonizing in klogd and syslogd to lib/pending.c.
Cheers,
Felix
# HG changeset patch
# User Felix Janda
# Date 1376156111 -7200
# Node ID
Below is a patch to add a simple version like you proposed. It would
be very simple to add the -o and the -k options (if there is need).
I'm not sure about the correct permissions of the possibly newly
created file.
Felix
# HG changeset patch
# User Felix Janda
# Date 1376073962 -720
Dave wrote:
> On 8/3/2013 7:25 PM, Strake wrote:
> >
> >> Besides that there's -i, which could be done easily by open()ing a
> >> temporary file, writing to that, then renaming to the original filename.
> > This violates the doctrine to do one thing well. Alas, users want it,
> > and scripts use it
Isaac wrote:
> On Fri, Aug 02, 2013 at 10:35:30PM +0200, Felix Janda wrote:
> > Isaac wrote:
> > > On Sat, Jul 27, 2013 at 09:56:53AM +0200, Felix Janda wrote:
> > [...]
> > > > Anyway Isaac is doing (or planning to do) a major rewrite enabling lspci
> >
Isaac wrote:
> On Sat, Jul 27, 2013 at 09:56:53AM +0200, Felix Janda wrote:
[...]
> > Anyway Isaac is doing (or planning to do) a major rewrite enabling lspci
> > to read the pciid database for human readable names of vendors and devices.
>
> I have a question or two in rega
Kyungwan Han wrote:
> Hi, felix
>
> I'm reading lspci code, and I have a question about below code.
>
> 25 struct {
> 26 char class[16], vendor[16], device[16], module[256];
> 27 } *bufs = (void*)(toybuf + 2);
>
> Could I know why you use '*bufs = (void*)(toybuf + 2);' instead of '*bu
Strake wrote:
> On 28/07/2013, Felix Janda wrote:
> > Some comments below.
>
> Thanks.
Thanks for your new patch.
[...]
> >> + for (ii = 0; ii < toys.optc; ii++) {
> >
> > You don't really need the index. Just loop over toys.optargs, which are
>
Some comments below.
Strake wrote:
> From feeb53bf11e949e48f80752a642fe551c284d7a7 Mon Sep 17 00:00:00 2001
> From: Strake
> Date: Sun, 28 Jul 2013 09:30:35 -0500
> Subject: [PATCH] add renice
>
> ---
> toys/pending/renice.c | 48
> 1 file change
Rob Landley wrote:
> On 07/24/2013 05:58:01 PM, Felix Janda wrote:
> > Various fixes to logger in below patch.
> >
> > Mainly inline parse_priority(). Many other small changes e.g.
> > s/const//,
> > move around some variables, ...
> >
> > -Felix
&
Isaac wrote:
[...]
> > Just for the record: resource is 399 and config 256 bytes. (Extended config
> > for pci
> > express devices is 4096 bytes.)
> >
>
> Here resource is 4096 bytes.
4096 seems to be the default size of a sysfs entry. Fun with sysfs:
$ cd "/sys/bus/pci/devices/:00:00.0"
$
Rob Landley wrote:
> On 07/22/2013 02:05:26 PM, Felix Janda wrote:
> > > 75 lines total.
> >
> > Down to 70 after application of the below patch with small fixes.
> >
> > It felt more sensible to me to read 2 more bytes and ignore them than
>
Isaac wrote:
> On Thu, Jul 25, 2013 at 10:31:47AM +0200, Felix Janda wrote:
> > Isaac wrote:
[...]
> > > By the way, there are requests for more features (-v/-vv and text output)
> > > that would mean slightly different approaches to getting data;
> > > (p)r
Isaac wrote:
> On Wed, Jul 24, 2013 at 09:20:51PM +0200, Felix Janda wrote:
> > Attached Isaac's toy edited to use toybuf instead of
> > dynamic memory allocation. It could look prettier, though...
> >
> > Felix
> >
> Broken:
> /toybox lspci -e
>
Various fixes to logger in below patch.
Mainly inline parse_priority(). Many other small changes e.g. s/const//,
move around some variables, ...
-Felix
# HG changeset patch
# User Felix Janda
# Date 1374706109 -7200
# Node ID 8cc26924c2ef2e862c975a31167a685e18f555ec
# Parent
Attached Isaac's toy edited to use toybuf instead of
dynamic memory allocation. It could look prettier, though...
Felix
/*
* lspci - written by Isaac Dunham
USE_LSPCI(NEWTOY(lspci, "emkns:", TOYFLAG_USR|TOYFLAG_BIN))
config LSPCI
bool "lspci"
default n
help
usage: lspci [-ekmn]
L
Sandeep Sharma wrote:
[...]
> hi,
> I have some questions actually :-
>
> > > - fd = openat(dirfd, fname, O_RDONLY);
> > > - if (fd < 0) {
> > > -return NULL;
> > > - }
> > > - lseek(fd, offset, SEEK_SET);
> > > + char *buf = calloc(1, nbyte+1);
> > > +
> why callo
Isaac wrote:
[...]
> On Mon, Jul 22, 2013 at 09:05:26PM +0200, Felix Janda wrote:
> > Are there any more options you have in mind that should be implemented?
>
> -s DEVICE is highly desireable, but I didn't get it working right.
> (-s shows only the device that has a m
Georgi Chorbadzhiyski wrote:
> On 7/22/13 10:05 PM, Felix Janda wrote:
> > Isaac wrote:
> >>
> >> I've written an lspci implementation.
> >
> > Cool.
> >
> >> Currently it supports -emkn; -e is an extension ("class" is a 24-b
Isaac wrote:
>
> I've written an lspci implementation.
Cool.
> Currently it supports -emkn; -e is an extension ("class" is a 24-bit number,
> but lspci only shows 16 bits; one person on the Puppy forums mentioned
> that they need those last 8 bits).
> -n is a no-op for compatability with standard
Rob Landley wrote:
> Description of the paste cleanup that accidentally got checked in
> during commit 944 because hg import -f has side effects.
>
>http://landley.net/hg/toybox/rev/944
>
> (Yes, that commit description is actively ironic. Scroll down to
> patch.c.)
[...]
The accidental
nd || instead. Are many shell
scripts in the wild using these options? Should they be implemented,
it looks like some code could be shared with find.
Maybe it would be better to use a goto for the error handling in test.c.
Felix
# HG changeset patch
# User Felix Janda
# Date 13741895
Rob Landley wrote:
[...]
> > than count*sizeof(toybuf) and contain no newlines.
>
> Count is initialized in a for loop and starts at 0 on line 164 so I
> dunno what this means...
Sorry for the confusion. I meant the number of lines tail is told to
output.
[...]
> > diff -r f8db1f6ec4ab toys/po
Just three superficial remarks:
The *error_[msg,exit] functions should be used instead of [err,warn]x
from err.h. These functions use xexit() instead of exit(). In xexit()
calls exit() unless toys.rebound nonzero (e.g. when invoked from toysh)
and in this case it long_jmps to toys.rebound.
T
Isaac wrote:
> On Wed, Jul 03, 2013 at 08:56:46PM +0200, Felix Janda wrote:
> > Rob Landley wrote:
> > > Tail has a double free somewhere. (Aboriginal's more/buildall.sh is
> > > complaining, that uses toybox in host-tools.) Haven't had time to track
&g
Rob Landley wrote:
> Tail has a double free somewhere. (Aboriginal's more/buildall.sh is
> complaining, that uses toybox in host-tools.) Haven't had time to track
> it down yet, wondering if anybody else could spot it.
>
> From the behavior it's looking like it's on file close...
[...]
It se
ls segfaults if there is only one file to display. The problem seems to be:
static void listfiles(int dirfd, struct dirtree *indir)
{
...
for (ul = 0; ul= 0) xprintf("%s", toybuf+255-curcol);
}
...
Felix
___
Toybox mailing list
Toybox@lists.landle
Hello,
here's a version of paste. It doesn't deal with wide characters yet and
likely behaves very badly when given too many files or delimiters.
--Felix
# HG changeset patch
# User Felix Janda
# Date 1372511034 -7200
# Node ID a31b59b82edf66fcbb7efe94a1eeede28cee7e7
> > > If you split an empty file, does it create one empty output file,
> > or no
> > > output files?
> >
> > "The split utility shall read an input file and write one or more
> > output files."
>
> So the implementation in ubuntu is nonconforming then?
I tested also busybox's implementation
Rob Landley wrote:
> The split command creates output files. If an output file exists, does
> it truncate it? Append to it? Fail? Posix doesn't say.
See XCU 1.1.1 System Interfaces - File Read, Write, and Creation.
> If you split an empty file, does it create one empty output file, or no
> ou
On 2013-05-30 at 10:22, Rob Landley wrote:
> Sigh, my idea from the other night didn't pan out. I was hoping that I
> could always pass a long to xprintf(), and then just store the xprintf
> format string and a pointer to the value, dereference it as a long *,
> and let xprintf figure out how
anup of stat.
Felix
# HG changeset patch
# User Felix Janda
# Date 1369511894 -7200
# Node ID 915bbb8cadb6876f652d2ddb44d848aadbb9934c
# Parent ecb0befac82a01118c615d93f1e522ac62596988
stat: Add support for stat'ing multiple files
diff -r ecb0befac82a -r 915bbb8cadb6 toys/pending/stat.c
--- a/
Hello,
the build of toybox was broken if CONFIG_TOYBOX_HELP was enabled but
CONFIG_HELP was disabled (and help.h was not yet generated). The
attached patch fixes it.
Felix
# HG changeset patch
# User Felix Janda
# Date 1367349103 -7200
# Node ID f2a8f8981c83cb496f61bdd7e5692f4c8cbcb477
# Parent
> I know toybox supports only short option, so toybox cannot treat '--help'
> option.
Are you sure? Have you read
http://landley.net/toybox/code.html#lib_args
? (Search for "--longopts".)
Notice that toybox also has a help toy. You can use
toybox help command
to see the help text for "comman
> Are the long options handled completely at present?
>
> I think the long options are not handled if they don't have a corresponding
> short-option.
Have you read
http://landley.net/toybox/code.html#lib_args
? (Search for "--longopts".)
I did a small test and longopts without corresponding
Hi,
find -mtime didn't work as expected in the first place and I've broken
it even more with the cleanups. The attached patch should fix it (and
simplify the relevant code a bit).
Felix
# HG changeset patch
# User Felix Janda
# Date 1367010929 -7200
On 04/22/13 at 06:51pm, Rob Landley wrote:
> I've lost the plot somewhere, neither of these patches apply to my
> current tree. Last two commit to that file I have (from you) are:
>
> changeset: 872:793972c94560
> user:Felix Janda
> date:Sat Apr 20 00:1
On 04/21/13 at 11:01pm, Rob Landley wrote:
> [snip]
> > Ok, I thought more about the extra jumping around than about the
> > integer
> > checks. But actually it should only 2 additional jumps (jumping to the
> > case label and jumping out of the switch with "break").
>
> Disk access should total
On 04/21/13 at 11:30pm, Rob Landley wrote:
> On 04/21/2013 04:40:16 PM, Felix Janda wrote:
> > > If you can come up with a clean way to share the code, go for it.
> >
> > Ok, actually I'd only put something like get_access_str() of stat into
> > the lib.
>
there is also a
comment
void find_main(void)
{
/* parse filters, if present */
build_filter_list();
/* FIXTHIS - parse actions, if present */
dirtree_read(TT.dir, check_node_callback);
}
That seems to be obsolete (or I don't understand it at all).
Felix
# HG changeset patch
# User F
On 04/21/13 at 12:09am, Rob Landley wrote:
> On 04/19/2013 05:28:27 PM, Felix Janda wrote:
> > [snip]
> > The functionality of get_access_str() is also implemented in the ls
> > toy
> > (likely much better). Should something like it be in the library?
>
> On
On 04/21/13 at 12:38pm, Rob Landley wrote:
> On 04/20/2013 01:39:10 PM, Felix Janda wrote:
> > Hello,
> >
> > some more find cleanup in an attached patch.
> >
> > The main change was to make some code in build_filter_list() less
> > repetitive using a s
dex "i" in build_filter_list().
Felix
BTW: POSIX-1.2008 TC1 is out
# HG changeset patch
# User Felix Janda
# Date 1366471541 -7200
# Node ID 9419e28b582891a34eb1734dbec1643e573a1f3d
# Parent 1700c6bfc8f5d87b9f382bb8e334d43bda5f0720
More find cleanup
diff -r 1700c6bfc8f5 -r 9419e28b5828 toys/pendi
support... My local
man page does even not document the -Z option to stat.
Felix
# HG changeset patch
# User Felix Janda
# Date 1366399776 -7200
# Node ID 4138b8889ce7999abecf4243e7a88906facbca1a
# Parent a612857eb52d49922508911d2ba853fd8939d0bf
stat: Reindent from 4 to 2 spaces
diff -r
de, fnext);
return result;
}
Here skip is a static int intialized to 0. skip tells evaluate to return
after *fnext has been updated.
find now passes the tests I've written but these miss out still a lot of
stuff which can go wrong.
Cheers,
Felix
# HG change
On 04/16/13 at 10:41am, Isaac Dunham wrote:
> ...
> I forget where Landley commented on this, but he mentioned a few issues:
Here:
http://lists.landley.net/pipermail/toybox-landley.net/2013-April/000891.html
Felix
___
Toybox mailing list
Toybox@lists.l
1 - 100 of 127 matches
Mail list logo
