Hi Rob,
Thanks Alot, will start on it .
Thanks
Haroon.
From: Rob Landley
Sent: Wednesday, August 22, 2018 5:02 PM
To: haroon maqsood; toybox@lists.landley.net
Subject: Re: [Toybox] [CLEANUP][watch.c]
On 08/22/2018 06:10 AM, haroon maqsood wrote:
> carrying
On 08/22/2018 06:10 AM, haroon maqsood wrote:
> carrying on from the point of knowing what is expected, would you be able to
> point me towards a something in the pending directory that you have not
> started
> on , that i can skim through and perhaps try and cleanup, just to avoid
> duplicating e
i can skim through and perhaps try and cleanup, just to avoid
duplicating efforts.
Thanks
Haroon.
From: Rob Landley
Sent: Tuesday, August 21, 2018 3:22 PM
To: haroon maqsood; toybox@lists.landley.net
Subject: Re: [Toybox] [CLEANUP][watch.c]
On 08/20/2018 03:13 AM, h
On 08/20/2018 02:43 PM, enh wrote:
> (less importantly, i wondered if the \e escapes in interestingtimes.c are your
> plan for the future and will replace \033, or should be \e for consistency.
> personally, i find \e less unreadable -- i even prefer \x1b to \033 -- but \e
> is
> not actually in t
On 08/20/2018 02:39 PM, enh wrote:
> speaking of terminal_size, is there a reason it doesn't call
> terminal_probesize
> if the ioctl fails? it seems like terminal_probesize is only used in top, in
> response to a signal (presumably for SIGWINCH). whereas terminal_size is used
> in
> all kinds of
On 08/20/2018 03:13 AM, haroon maqsood wrote:
> Hi Rob,
> Thanks a lot for the feedback,
> Noted, i will be more careful next time .
It's a hard problem to get right. (Well, by my standards anyway.)
If you do "watch -n 2 sleep 5" on debian you get no output for 5 seconds, and
then it updates eve
(less importantly, i wondered if the \e escapes in interestingtimes.c are
your plan for the future and will replace \033, or should be \e for
consistency. personally, i find \e less unreadable -- i even prefer \x1b to
\033 -- but \e is not actually in the standard.)
On Mon, Aug 20, 2018 at 12:39 P
On Sun, Aug 19, 2018 at 2:44 PM Rob Landley wrote:
> On 08/16/2018 08:37 PM, haroon maqsood wrote:
> > Hi PFA,
> > my attempt at cleanup of watch.c in pending.
> > Thanks
> > Haroon
>
> A little more description of what you did would be nice. Let's see...
> requiring
> -n to be at least one secon
Hi Rob,
Thanks a lot for the feedback,
Noted, i will be more careful next time .
Haroon
From: Rob Landley
Sent: Sunday, August 19, 2018 9:44 PM
To: haroon maqsood; toybox@lists.landley.net
Subject: Re: [Toybox] [CLEANUP][watch.c]
On 08/16/2018 08:37 PM, haroon
On 08/16/2018 08:37 PM, haroon maqsood wrote:
> Hi PFA,
> my attempt at cleanup of watch.c in pending.
> Thanks
> Haroon
A little more description of what you did would be nice. Let's see... requiring
-n to be at least one second makes sense, although debian's can do "-n 0.1".
(That gets into the
Hi,
please ignore the mistake of PFA, in the greeting , its very late here 😝
Haroon
From: haroon maqsood
Sent: Friday, August 17, 2018 1:37 AM
To: toybox@lists.landley.net
Subject: [CLEANUP][watch.c]
Hi PFA,
my attempt at cleanup of watch.c in pending.
Thanks
Haro
Hi PFA,
my attempt at cleanup of watch.c in pending.
Thanks
Haroon
From cf2626c0cc19cf0bcc831c289c6fb85ffd54382b Mon Sep 17 00:00:00 2001
From: "maqsood3...@live.com"
Date: Fri, 17 Aug 2018 02:25:37 +0100
Subject: [PATCH] watch cleanup
---
toys/pending/watch.c | 77 +++---
12 matches
Mail list logo
