Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-20 Thread enh via Toybox
thanks! (and apologies yet again that i never remember your name... i suck at names!) On Thu, Jul 20, 2023, 13:19 Eric Molitor wrote: > I can take a look this weekend. > > - Eric > > On Thu, 20 Jul 2023, 8:32 pm enh via Toybox, > wrote: > >> heh, and the revert commit _did_ get a green ci run.

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-20 Thread Eric Molitor
I can take a look this weekend. - Eric On Thu, 20 Jul 2023, 8:32 pm enh via Toybox, wrote: > heh, and the revert commit _did_ get a green ci run. so, yeah, definitely > bad. but now we need the guy who set up the github ci in the first place to > hit us with his cluestick... :-) (how is a failu

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-20 Thread enh via Toybox
heh, and the revert commit _did_ get a green ci run. so, yeah, definitely bad. but now we need the guy who set up the github ci in the first place to hit us with his cluestick... :-) (how is a failure to parse not a red cross with a link to logs, just like if it parsed but the _actions_ failed?! ma

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-20 Thread Rob Landley
On 7/20/23 09:07, enh wrote: > at this point, i'm pretty sure that change silently broke it --- i've never > seen > a gap without runs over this many changes, or this amount of time. > > revert  > https://github.com/landley/toybox/commit/c45e800803364c6e1f343e431f98e19a1bc1148f > ? Done. I won

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-20 Thread enh via Toybox
at this point, i'm pretty sure that change silently broke it --- i've never seen a gap without runs over this many changes, or this amount of time. revert https://github.com/landley/toybox/commit/c45e800803364c6e1f343e431f98e19a1bc1148f ? On Wed, Jul 12, 2023 at 2:10 PM enh wrote: > yeah, i'll

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-12 Thread enh via Toybox
yeah, i'll keep an eye out and let you know if it doesn't start up again... On Tue, Jul 11, 2023 at 10:10 PM Rob Landley wrote: > On 7/11/23 17:15, enh wrote: > > especially since we suspiciously haven't had any CI run at all since > that change > > went in: https://github.com/landley/toybox/com

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-11 Thread Rob Landley
On 7/11/23 17:15, enh wrote: > especially since we suspiciously haven't had any CI run at all since that > change > went in: https://github.com/landley/toybox/commits/master > (i'd expected as least an error, but not even a "ran and failed"!) I hit that problem back when we added the mac tests an

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-11 Thread enh via Toybox
On Mon, Jul 10, 2023 at 11:20 PM Rob Landley wrote: > On 7/10/23 18:58, enh via Toybox wrote: > > Untested (because I don't know how to test such changes without merging > > them), but seems plausible based on the documentation at > > > https://docs.github.com/en/actions/learn-github-actions/vari

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-10 Thread Rob Landley
On 7/11/23 01:21, Rob Landley wrote: > On 7/10/23 18:58, enh via Toybox wrote: >> Untested (because I don't know how to test such changes without merging >> them), but seems plausible based on the documentation at >> https://docs.github.com/en/actions/learn-github-actions/variables#about-environmen

Re: [Toybox] [PATCH] Enable ASan for github CI.

2023-07-10 Thread Rob Landley
On 7/10/23 18:58, enh via Toybox wrote: > Untested (because I don't know how to test such changes without merging > them), but seems plausible based on the documentation at > https://docs.github.com/en/actions/learn-github-actions/variables#about-environment-variables > > --- >  .github/workflows

[Toybox] [PATCH] Enable ASan for github CI.

2023-07-10 Thread enh via Toybox
Untested (because I don't know how to test such changes without merging them), but seems plausible based on the documentation at https://docs.github.com/en/actions/learn-github-actions/variables#about-environment-variables --- .github/workflows/toybox.yml | 2 ++ 1 file changed, 2 insertions(+) Fr